)]}'
{"id":"openstack%2Fswift~790690","triplet_id":"openstack%2Fswift~master~I196381388b56e41c98ec9d87f08009cbf6755038","project":"openstack/swift","branch":"master","topic":"p-shard-update-tombstones","hashtags":[],"change_id":"I196381388b56e41c98ec9d87f08009cbf6755038","subject":"Update ShardRange tombstones using update_meta method","status":"NEW","created":"2021-05-11 13:18:35.000000000","updated":"2021-05-11 14:52:19.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8fb417bc3a63188ee91daa7f9235c9bd4ba6696c","_number":790690,"virtual_id_number":790690,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-05-11 14:18:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":1,"date":"2021-05-11 14:52:19.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-11 14:18:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-11 14:52:19.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"}],"messages":[{"id":"90c6198ac036be405038dae71679bdb64301e7dd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-05-11 13:18:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aa33597cd31bea2db04b073db176cae47330eab3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-11 14:18:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9fd7a900fb98439398844f4c97e9b60f : SUCCESS in 9m 23s\n- grenade https://zuul.opendev.org/t/openstack/build/4a7dfa31ebb04e14b52ebf6c749803e6 : SUCCESS in 47m 58s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/925481b8e792486d8cd90445ea2a5bd1 : SUCCESS in 32m 38s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/4c4a0915ffad49afbb331ff3ca527d73 : SUCCESS in 9m 07s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/d320d167f1484e2f8e3704bfef6dfef0 : SUCCESS in 6m 29s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/8f43aa5e617a4a5c8926cb2d56364b16 : SUCCESS in 12m 24s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/34c89575de264bf6a128eccf8d9dbe08 : SUCCESS in 15m 52s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/5d8eb5b0091646a6a89688fbde527cc8 : SUCCESS in 19m 37s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/a151d66229ec4afeabb7801d54f490f9 : SUCCESS in 20m 18s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/b2fd63107a1c4c53b77f7e2563786b88 : SUCCESS in 13m 18s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/30c7542eb5ca4fcf9fc9adc7c930855a : SUCCESS in 21m 51s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/9a76f02d2dec40f7ab9cc9e71b30f371 : SUCCESS in 17m 37s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/c91e492b917445428597a2b074b25b4f : SUCCESS in 19m 09s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/ee82d38526764239a00ba65bb48ae28a : SUCCESS in 30m 54s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/3c4c6f73b48a41039ccbc7bed6078ac6 : SUCCESS in 18m 14s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/4eb672ac1bf84ea79a730fff1715cb3c : SUCCESS in 18m 57s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/61ddcdf5f4914614a16ddd2de26736aa : SUCCESS in 6m 10s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/0f63919493594e1eb3629b235d953a2c : SUCCESS in 17m 49s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/595571197c81405eb808eaeb60d3eb19 : SUCCESS in 35m 12s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/0aecd658d5e743178a2e4dbf053ee394 : SUCCESS in 50m 09s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/04766ff18230435e939065b176af41d9 : SUCCESS in 29m 54s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/d75f8292df8f4575910b60c5a8f48d90 : SUCCESS in 39m 39s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4e3d8dcafb224f248aaef1a55c6906d5 : SUCCESS in 13m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9ac2b66206c4400da65030ae68a56219 : SUCCESS in 6m 14s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/41ade902d7a047a6b8c1cddf5ee8b28f : SUCCESS in 27m 53s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/65478fbafe62425b970d3649128fba90 : SUCCESS in 53m 55s","accounts_in_message":[],"_revision_number":1},{"id":"8fb417bc3a63188ee91daa7f9235c9bd4ba6696c","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-05-11 14:52:19.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"df16e5463adaed287c9c5d0fe5fde143ceee88b0","revisions":{"df16e5463adaed287c9c5d0fe5fde143ceee88b0":{"kind":"REWORK","_number":1,"created":"2021-05-11 13:18:35.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/90/790690/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/90/790690/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/90/790690/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/90/790690/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/90/790690/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/90/790690/1"}}},"commit":{"parents":[{"commit":"9f2eff0e08c4d9db72046fbf603d0c491ea605a7","subject":"Update own_shard_range metadata less often","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9f2eff0e08c4d9db72046fbf603d0c491ea605a7"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-05-11 12:57:51.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-05-11 13:14:40.000000000","tz":60},"subject":"Update ShardRange tombstones using update_meta method","message":"Update ShardRange tombstones using update_meta method\n\nRemoves the ShardRange.update_tombstones method in favour of\npassing tombstones as an optional argument to update_meta.\n\nAlso, when updating metadata, tombstones will be set to -1,\nrepresenting \u0027unknown\u0027, if a value is not given. This ensures that a\nprevious \u0027known\u0027 value is not retained when the metadata timestamp is\nchanged and the own_shard_range merged into the broker DB.\n\nTombstones is always set when a shard updates its root container with\nits metadata.\n\nChange-Id: I196381388b56e41c98ec9d87f08009cbf6755038\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/df16e5463adaed287c9c5d0fe5fde143ceee88b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/df16e5463adaed287c9c5d0fe5fde143ceee88b0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}