)]}'
{"swift/container/backend.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4d0b6db67c255cc2df00acad73e77abefff439b5","unresolved":true,"context_lines":[{"line_number":1846,"context_line":"            default shard range is returned."},{"line_number":1847,"context_line":"        :return: an instance of :class:`~swift.common.utils.ShardRange`"},{"line_number":1848,"context_line":"        \"\"\""},{"line_number":1849,"context_line":"        own_shard_range \u003d self._own_shard_range(no_default\u003dno_default)"},{"line_number":1850,"context_line":"        if own_shard_range:"},{"line_number":1851,"context_line":"            info \u003d self.get_info()"},{"line_number":1852,"context_line":"            own_shard_range.update_meta("}],"source_content_type":"text/x-python","patch_set":2,"id":"e18c4f16_fa905d6f","side":"PARENT","line":1849,"updated":"2021-05-12 19:23:52.000000000","message":"this one might be a made up default, but we still mixin the info values","commit_id":"443677f104c0181490cc1ff04f95efbed0a6a0de"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4d0b6db67c255cc2df00acad73e77abefff439b5","unresolved":true,"context_lines":[{"line_number":1838,"context_line":"                   sr.epoch,"},{"line_number":1839,"context_line":"                   %s"},{"line_number":1840,"context_line":"            FROM %s AS st"},{"line_number":1841,"context_line":"            LEFT JOIN %s AS sr"},{"line_number":1842,"context_line":"            WHERE sr.name \u003d ?"},{"line_number":1843,"context_line":"            OR sr.name is null"},{"line_number":1844,"context_line":"            \"\"\" % ("}],"source_content_type":"text/x-python","patch_set":2,"id":"19a0625e_9092da9e","line":1841,"updated":"2021-05-12 19:23:52.000000000","message":"joining _just_so_ gives me a row with some null even if shard_range table is empty","commit_id":"10bdb46be4a664ad8c9719715ea6036441ea563a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4d0b6db67c255cc2df00acad73e77abefff439b5","unresolved":true,"context_lines":[{"line_number":1854,"context_line":"                if \u0027no such column: sr.reported\u0027 in str(err):"},{"line_number":1855,"context_line":"                    row \u003d do_query(conn, use_reported_column\u003dFalse)"},{"line_number":1856,"context_line":"                elif (\u0027no such table: %s\u0027 % SHARD_RANGE_TABLE) in str(err):"},{"line_number":1857,"context_line":"                    # XXX: we should get object \u0026 bytes right here too!!!"},{"line_number":1858,"context_line":"                    row \u003d None"},{"line_number":1859,"context_line":"                else:"},{"line_number":1860,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"482cbcc4_2bfe5f47","line":1857,"updated":"2021-05-12 19:23:52.000000000","message":"the extra migration code alone might be reason NOT to try and optimize this...\n\nhow many billions of extra sqlite queries do we eliminate over the course of swift vs the cost maintaining these extra 50 lines of code?","commit_id":"10bdb46be4a664ad8c9719715ea6036441ea563a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4d0b6db67c255cc2df00acad73e77abefff439b5","unresolved":true,"context_lines":[{"line_number":1860,"context_line":"                    raise"},{"line_number":1861,"context_line":"        own_shard_range \u003d None"},{"line_number":1862,"context_line":"        now \u003d Timestamp.now()"},{"line_number":1863,"context_line":"        sr_dict \u003d dict(row) if row else {}"},{"line_number":1864,"context_line":"        sr_info \u003d {k: v for k, v in sr_dict.items() if v is not None}"},{"line_number":1865,"context_line":"        if sr_info.get(\u0027name\u0027):"},{"line_number":1866,"context_line":"            own_shard_range \u003d ShardRange(meta_timestamp\u003dnow, **sr_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8c769caa_96d1f312","line":1863,"updated":"2021-05-12 19:23:52.000000000","message":"maybe we can simplify this bit if we never set \"row \u003d None\"","commit_id":"10bdb46be4a664ad8c9719715ea6036441ea563a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4d0b6db67c255cc2df00acad73e77abefff439b5","unresolved":true,"context_lines":[{"line_number":1869,"context_line":"                self.path, now,"},{"line_number":1870,"context_line":"                ShardRange.MIN, ShardRange.MAX,"},{"line_number":1871,"context_line":"                state\u003dShardRange.ACTIVE,"},{"line_number":1872,"context_line":"                meta_timestamp\u003dnow, **sr_info)"},{"line_number":1873,"context_line":"        return own_shard_range"},{"line_number":1874,"context_line":""},{"line_number":1875,"context_line":"    def get_own_shard_range(self, no_default\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"de9eca79_93672f27","line":1872,"updated":"2021-05-12 19:23:52.000000000","message":"maybe slightly smaller diff to do:\n\n    sr_dict[\u0027meta_timestamp\u0027] \u003d now\n\n... above and right here just do **sr_info","commit_id":"10bdb46be4a664ad8c9719715ea6036441ea563a"}]}
