)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"cc01d767648bb9363b6eaadd6a4558de2e6abdcb","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Javan Lacerda \u003cjavkaue@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-05-31 21:32:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"removing per_diff magic number"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug: https://bugs.launchpad.net/swift/+bug/1877662"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f5121c6_e3e18e6d","line":7,"updated":"2021-05-31 23:42:50.000000000","message":"Great first line, we then jump into why. Maybe something like:\n\n  Currently per_diff is hard coded as 1000 in the db replicator, this patch allows this per_diff to become configurable in container server.\n\nYou\u0027ve done awesome. Once landed the commit message is what we\u0027ll end up using in any git archeology and when generating the change log, so it\u0027s nice to have more context of what was the problem and what/how was it was fixed 😊","commit_id":"a7dd099d52a134b4f4230818e8cfcb4bffce2fa6"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"cc01d767648bb9363b6eaadd6a4558de2e6abdcb","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"removing per_diff magic number"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug: https://bugs.launchpad.net/swift/+bug/1877662"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I096fa6e5a6651224c678cdc7c0cd1356197f5bcc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9945543f_1ba194b8","line":9,"updated":"2021-05-31 23:42:50.000000000","message":"Thanks for taking this on!! \n\nHere is a link to how openstack way of commit messages (don\u0027t worry I still have to check this link every now and again): https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nIf your closing a bug then you need to put in: \n\n  Closes-Bug: #1877662\n\nAnd gerrit will turn that into a link to the launchpad bug. Pretty neat.","commit_id":"a7dd099d52a134b4f4230818e8cfcb4bffce2fa6"}],"swift/common/db_replicator.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"cc01d767648bb9363b6eaadd6a4558de2e6abdcb","unresolved":true,"context_lines":[{"line_number":1013,"context_line":"        while len(objects):"},{"line_number":1014,"context_line":"            new_broker.merge_items(objects)"},{"line_number":1015,"context_line":"            point \u003d objects[-1][\u0027ROWID\u0027]"},{"line_number":1016,"context_line":"            objects \u003d existing_broker.get_items_since(point, PER_DIFF_DEFAULT)"},{"line_number":1017,"context_line":"            sleep()"},{"line_number":1018,"context_line":"        new_broker.merge_syncs(existing_broker.get_syncs())"},{"line_number":1019,"context_line":"        self._post_rsync_then_merge_hook(existing_broker, new_broker)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d88d7051_68e8f71d","line":1016,"updated":"2021-05-31 23:42:50.000000000","message":"This is better then it was. But still really just 1000. The way the db replicators work, which isn\u0027t very intuitive is we have, say the container replicator running as a daemon. It has a per_diff (which you\u0027ve rightly defaulted with a constant towards the top of this file) because the account and container replicators inherit the db replicator.\n\nThis replicator daemon calls a REPLICATE http verb in container-server (or account) WSGI server:  https://github.com/openstack/swift/blob/master/swift/container/server.py#L810-L828\n\nWhich is using an instance of the ReplicatorRPC object where in here, who talks and deals with the db_replicator. Because the ReplicatorRPC is instanciated from the container and account servers, we may need to add a per_diff option there which can be piped into the creation of the rpc object.\n\nI think that\u0027s the missing peice of the puzzle 😊","commit_id":"a7dd099d52a134b4f4230818e8cfcb4bffce2fa6"}]}