)]}'
{"id":"openstack%2Fswift~793866","triplet_id":"openstack%2Fswift~master~I096fa6e5a6651224c678cdc7c0cd1356197f5bcc","project":"openstack/swift","branch":"master","topic":"javan.remove_magic_number","hashtags":[],"change_id":"I096fa6e5a6651224c678cdc7c0cd1356197f5bcc","subject":"removing per_diff magic number","status":"NEW","created":"2021-05-31 21:26:58.000000000","updated":"2021-05-31 23:42:50.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":3,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"cc01d767648bb9363b6eaadd6a4558de2e6abdcb","_number":793866,"virtual_id_number":793866,"owner":{"_account_id":33550,"name":"Javan Lacerda","display_name":"Javan Lacerda","email":"JavanJaue.TavaresLacerda@windriver.com","username":"javanlacerda"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-05-31 22:40:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"all":[{"value":-1,"date":"2021-05-31 23:42:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-31 22:10:11.000000000","updated_by":{"_account_id":33550,"name":"Javan Lacerda","display_name":"Javan Lacerda","email":"JavanJaue.TavaresLacerda@windriver.com","username":"javanlacerda"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2021-05-31 22:40:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-31 23:42:50.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"}],"messages":[{"id":"9f0dbae113e0d2a62fa6faa918a18ece80dacd3c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33550,"name":"Javan Lacerda","display_name":"Javan Lacerda","email":"JavanJaue.TavaresLacerda@windriver.com","username":"javanlacerda"},"date":"2021-05-31 21:26:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"69cfb807709f7c365ea760023e41692cf308fedc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33550,"name":"Javan Lacerda","display_name":"Javan Lacerda","email":"JavanJaue.TavaresLacerda@windriver.com","username":"javanlacerda"},"date":"2021-05-31 21:31:52.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"3cbf99def97f372ac203a37d1f2aad6825127e01","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33550,"name":"Javan Lacerda","display_name":"Javan Lacerda","email":"JavanJaue.TavaresLacerda@windriver.com","username":"javanlacerda"},"date":"2021-05-31 21:32:09.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"d3d2d1801382a0757a0164c260814651f4b150fa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-31 22:40:57.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e6492cb5a5ad48fe879b39d41bd8f81c : SUCCESS in 8m 52s\n- grenade https://zuul.opendev.org/t/openstack/build/3c0fce4267c140e08b1426f4e2bd1ea9 : SUCCESS in 1h 04m 39s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/87a86bbda7de43909698df97b78e9109 : SUCCESS in 50m 59s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/f540f89a376b4b1f97e52bc91783681f : SUCCESS in 9m 36s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/eee601c1a5de487ead611d24295749ec : SUCCESS in 6m 44s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/4cf7ec8c762e400d8b9df69a9675517f : SUCCESS in 18m 36s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/73e15d82198045c2bc143112ecf28cfc : SUCCESS in 17m 07s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/87713e1f929247db92b2f47337f2581f : SUCCESS in 18m 13s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/64d4756fd6a24ac088fbf544442cd64b : SUCCESS in 16m 31s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/5ec86729b0144742a193d68deb838a93 : FAILURE in 16m 46s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/eb275156ffb74258909e62db7fc34f3e : SUCCESS in 33m 00s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/630d0faa549540a48c96e8e24eb4b9c1 : SUCCESS in 26m 34s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/c585a2d9a4bf4167aeb58c9c937b248b : SUCCESS in 18m 37s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/06a760d698d444a7a0053857be1f1cd1 : SUCCESS in 18m 01s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/4a0c7a4293fa425899cdb891ea6e3846 : SUCCESS in 17m 53s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/bac2d1f212e34c528b8bf25f1ccb9271 : SUCCESS in 23m 52s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/354c6f0d6560400ab6c8a419e916859a : SUCCESS in 7m 05s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/5ed9aeee70aa4b22b6b777dfd3c8e5f8 : SUCCESS in 20m 14s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/0ee0eb0159124f68baee435b5cb87076 : SUCCESS in 47m 18s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/a9df67873b3e4838bc0b2acf2fc6b203 : SUCCESS in 48m 45s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/1e0168bb338e45e596c152381dd2ddba : SUCCESS in 40m 29s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/ee4093fc5b774e8a9a75539dae9950ba : SUCCESS in 46m 36s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2ddb366d98584449839493fabf2fe33f : SUCCESS in 16m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/22755d4ddfa24b7aa73bf3268a65cb73 : SUCCESS in 5m 46s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/b6e62e988d3e4bf4a343496f027816ac : FAILURE in 23m 26s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f659bd6e356d4ebcb85e9f40d56a2fe6 : SUCCESS in 39m 15s","accounts_in_message":[],"_revision_number":3},{"id":"cc01d767648bb9363b6eaadd6a4558de2e6abdcb","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-05-31 23:42:50.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)\n\nWow, awesome! Thanks so much for taking on this bug, and getting a patch up. You\u0027re doing great. I\u0027ve left some comments inline. Feel free to ping me if you need any help. I\u0027m mattoliverau on irc 😊\n\nGerrit\u0027s review scoring is a bit wierd, the -1 I put on isn\u0027t a bad thing, all of my patches get a bunch on -1s before they eventually get a +2. it just means there is a little more work to get it into shape before we can put it on master and people release out to clusters in the wild ;)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a7dd099d52a134b4f4230818e8cfcb4bffce2fa6","revisions":{"d4821556104932d2f3ddf6b5e31a4a3919e41705":{"kind":"REWORK","_number":1,"created":"2021-05-31 21:26:58.000000000","uploader":{"_account_id":33550,"name":"Javan Lacerda","display_name":"Javan Lacerda","email":"JavanJaue.TavaresLacerda@windriver.com","username":"javanlacerda"},"ref":"refs/changes/66/793866/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/66/793866/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/793866/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/793866/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/793866/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/66/793866/1"}}},"commit":{"parents":[{"commit":"1ba17f63540c2c34cfbb1c5880f22d7294bf0593","subject":"Get TestDarkDataQuarantining passing when policy-0 is erasure-coded","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1ba17f63540c2c34cfbb1c5880f22d7294bf0593"}]}],"author":{"name":"javanlacerda","email":"javkaue@gmail.com","date":"2021-05-31 21:26:32.000000000","tz":-180},"committer":{"name":"javanlacerda","email":"javkaue@gmail.com","date":"2021-05-31 21:26:56.000000000","tz":-180},"subject":"removing per_diff magic number","message":"removing per_diff magic number\n\nChange-Id: I096fa6e5a6651224c678cdc7c0cd1356197f5bcc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/d4821556104932d2f3ddf6b5e31a4a3919e41705"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/d4821556104932d2f3ddf6b5e31a4a3919e41705"}]},"branch":"refs/heads/master"},"3a439aa0378c28045189715b68bc5ae715d00253":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-05-31 21:31:52.000000000","uploader":{"_account_id":33550,"name":"Javan Lacerda","display_name":"Javan Lacerda","email":"JavanJaue.TavaresLacerda@windriver.com","username":"javanlacerda"},"ref":"refs/changes/66/793866/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/66/793866/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/793866/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/793866/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/793866/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/66/793866/2"}}},"commit":{"parents":[{"commit":"1ba17f63540c2c34cfbb1c5880f22d7294bf0593","subject":"Get TestDarkDataQuarantining passing when policy-0 is erasure-coded","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1ba17f63540c2c34cfbb1c5880f22d7294bf0593"}]}],"author":{"name":"javanlacerda","email":"javkaue@gmail.com","date":"2021-05-31 21:26:32.000000000","tz":-180},"committer":{"name":"Javan Lacerda","email":"javkaue@gmail.com","date":"2021-05-31 21:31:52.000000000","tz":0},"subject":"removing per_diff magic number","message":"removing per_diff magic number\n\nBug: 1877662\n\nChange-Id: I096fa6e5a6651224c678cdc7c0cd1356197f5bcc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/3a439aa0378c28045189715b68bc5ae715d00253"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/3a439aa0378c28045189715b68bc5ae715d00253"}]},"branch":"refs/heads/master","description":"Edit commit message"},"a7dd099d52a134b4f4230818e8cfcb4bffce2fa6":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-05-31 21:32:09.000000000","uploader":{"_account_id":33550,"name":"Javan Lacerda","display_name":"Javan Lacerda","email":"JavanJaue.TavaresLacerda@windriver.com","username":"javanlacerda"},"ref":"refs/changes/66/793866/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/66/793866/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/793866/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/793866/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/793866/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/66/793866/3"}}},"commit":{"parents":[{"commit":"1ba17f63540c2c34cfbb1c5880f22d7294bf0593","subject":"Get TestDarkDataQuarantining passing when policy-0 is erasure-coded","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1ba17f63540c2c34cfbb1c5880f22d7294bf0593"}]}],"author":{"name":"javanlacerda","email":"javkaue@gmail.com","date":"2021-05-31 21:26:32.000000000","tz":-180},"committer":{"name":"Javan Lacerda","email":"javkaue@gmail.com","date":"2021-05-31 21:32:09.000000000","tz":0},"subject":"removing per_diff magic number","message":"removing per_diff magic number\n\nBug: https://bugs.launchpad.net/swift/+bug/1877662\n\nChange-Id: I096fa6e5a6651224c678cdc7c0cd1356197f5bcc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a7dd099d52a134b4f4230818e8cfcb4bffce2fa6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a7dd099d52a134b4f4230818e8cfcb4bffce2fa6"}]},"branch":"refs/heads/master","description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}