)]}'
{"id":"openstack%2Fswift~794869","triplet_id":"openstack%2Fswift~master~Ib0f35a61657b62019d8769871d79127e7d95b2ea","project":"openstack/swift","branch":"master","topic":"p-sharder-tiny-tail","hashtags":[],"change_id":"Ib0f35a61657b62019d8769871d79127e7d95b2ea","subject":"sharder: make default minimum_shard_size \u003d shrink_threshold + 1","status":"ABANDONED","created":"2021-06-04 17:40:37.000000000","updated":"2021-06-28 10:10:49.000000000","total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"11585345f64ac5ce1da56e3850924c86f470480a","_number":794869,"virtual_id_number":794869,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-04 18:46:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":-1,"date":"2021-06-04 17:43:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"REVIEWER":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-04 18:46:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-17 00:51:31.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"CC"}],"messages":[{"id":"f78d28042a10352d304175c2ecf95363686732ef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-06-04 17:40:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8541cec2e5ee8c65944fa196f98c1895c26f2613","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-06-04 17:43:31.000000000","message":"Patch Set 1: Code-Review-1\n\nI did this to see how it wold look.\n\nIt\u0027s annoying that the \u0027+ 1\u0027 is needed. \n\nI\u0027m really not sure I like coupling a sharding option to a shrinking option. Setting shrink_threshold to zero to prevent shrinking does not imply wanting to allow new shards to be as small as 1.","accounts_in_message":[],"_revision_number":1},{"id":"04f9f7061d0849718fb1f839ebef2aec1b2eacb7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 18:46:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aae118354ef84eeab4bb013b8a8c7010 : SUCCESS in 9m 58s\n- grenade https://zuul.opendev.org/t/openstack/build/195c9e53f846440ea784d5f7369c788f : SUCCESS in 46m 07s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/e8cbd9859a874bf0b7380d598a146b7f : SUCCESS in 39m 56s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/381ff7a9130a4296b1de5defb438cfc4 : SUCCESS in 8m 06s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/3ed083edaefc4353aea21aa434193359 : SUCCESS in 8m 17s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/c8510e1b91d64b2399f26235729c4b22 : SUCCESS in 13m 15s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/66d25868dcd542d4b872bf5128c9da1f : SUCCESS in 16m 36s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/d6efd56d45e44ea5b8c94810f99b8d6e : SUCCESS in 17m 34s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/6836456b298c466c8fcacaf72a5d5e76 : SUCCESS in 14m 21s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/8a4d43b3299347bd8b05820729f99b66 : SUCCESS in 17m 07s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/4dc64917387846cbaf3bf52226c11301 : SUCCESS in 16m 58s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/d35f636c845044939b2bde233cad12b2 : SUCCESS in 19m 18s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/ac4c27a52d0248a7b900ae8467976f37 : SUCCESS in 14m 36s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/c00c8a450af64d398a08ab1d9484aab4 : SUCCESS in 17m 00s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/14f17f78c1644f2ea62851a831aaaa5a : SUCCESS in 18m 41s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/d0fc391109b14949986a391381adf9b6 : SUCCESS in 20m 58s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/a82b8ccdd89b4ec59ca0bc22e469baae : SUCCESS in 7m 25s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/5e83de36a03d44cfb15ac549f2158f50 : SUCCESS in 23m 44s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/e36f60c1c24944aa91a13cd34205e444 : FAILURE in 39m 16s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/2daf90e7ab724c67818316d2cbd0342f : FAILURE in 46m 40s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/f29077c6dba24705b5ed3d7d13ce26a0 : SUCCESS in 31m 30s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/eadfed1b1bd444229a6ebc5f76c0fdcd : SUCCESS in 40m 14s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/da30e59e08dd4cb1abaa0bcae588de04 : SUCCESS in 18m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/279d406d11c0435791683cd3376dcd9e : SUCCESS in 7m 43s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/18ed55adce1a428bb18992c317554086 : SUCCESS in 19m 04s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ea380522f71a45bdb32f5076e207419b : SUCCESS in 1h 03m 51s","accounts_in_message":[],"_revision_number":1},{"id":"fa0a04c501dabdcc214815675bf0c0082fcc6d3e","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-06-17 00:51:31.000000000","message":"Patch Set 1:\n\n(1 comment)\n\n\u003e Setting shrink_threshold to zero to prevent shrinking does not imply wanting to allow new shards to be as small as 1.\n\nThat\u0027s a fair point -- but lacking this change, wouldn\u0027t the operator default to allowing new shards as small as 1 anyway?","accounts_in_message":[],"_revision_number":1},{"id":"11585345f64ac5ce1da56e3850924c86f470480a","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-06-28 10:10:49.000000000","message":"Abandoned\n\nabsolute default was increased to 100k in https://review.opendev.org/c/openstack/swift/+/794582/2","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5674a6062d022ee06ce1c1b6a5d299c2ae7ca72d","revisions":{"5674a6062d022ee06ce1c1b6a5d299c2ae7ca72d":{"kind":"REWORK","_number":1,"created":"2021-06-04 17:40:37.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/69/794869/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/69/794869/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/69/794869/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/69/794869/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/69/794869/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/69/794869/1"}}},"commit":{"parents":[{"commit":"ecb19c1f193734e85d3d63bd5231babe4aef5db4","subject":"sharder: avoid small tail shards","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ecb19c1f193734e85d3d63bd5231babe4aef5db4"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-06-04 17:38:31.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-06-04 17:38:31.000000000","tz":60},"subject":"sharder: make default minimum_shard_size \u003d shrink_threshold + 1","message":"sharder: make default minimum_shard_size \u003d shrink_threshold + 1\n\nshrink_threshold can be set to zero to prevent shrinking, but\nminimum_shard_size must be \u003e 0.\n\nChange-Id: Ib0f35a61657b62019d8769871d79127e7d95b2ea\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5674a6062d022ee06ce1c1b6a5d299c2ae7ca72d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5674a6062d022ee06ce1c1b6a5d299c2ae7ca72d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}