)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3e05830a111428f41177dfe32c899592f358823e","unresolved":true,"context_lines":[{"line_number":1627,"context_line":"        :param suffixes: optional list of suffix directories to be searched"},{"line_number":1628,"context_line":"        :param min_nondurable_age: when considering non-durable data, only"},{"line_number":1629,"context_line":"                                   yield it if it\u0027s been on disk longer than"},{"line_number":1630,"context_line":"                                   this many seconds"},{"line_number":1631,"context_line":"        \"\"\""},{"line_number":1632,"context_line":"        dev_path \u003d self.get_dev_path(device)"},{"line_number":1633,"context_line":"        if not dev_path:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b92bce9_e85e4d60","line":1630,"updated":"2021-06-22 17:09:39.000000000","message":"ok, but might be better to yield the non-durable and get it reverted to a primary but not *delete* it yet","commit_id":"f615b14024fec1f266e71a244d6319526241213e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3e05830a111428f41177dfe32c899592f358823e","unresolved":true,"context_lines":[{"line_number":1678,"context_line":"                        # be ssync\u0027d"},{"line_number":1679,"context_line":"                        continue"},{"line_number":1680,"context_line":"                    if min_age and \u0027data_info\u0027 in diskfile_info and \\"},{"line_number":1681,"context_line":"                            not diskfile_info[\u0027data_info\u0027][\u0027durable\u0027]:"},{"line_number":1682,"context_line":"                        try:"},{"line_number":1683,"context_line":"                            fname \u003d diskfile_info[\u0027data_file\u0027]"},{"line_number":1684,"context_line":"                            mtime \u003d os.stat(fname).st_mtime"}],"source_content_type":"text/x-python","patch_set":1,"id":"a5cccc53_555c1484","line":1681,"range":{"start_line":1681,"start_character":58,"end_line":1681,"end_character":69},"updated":"2021-06-22 17:09:39.000000000","message":"durable key won\u0027t exist for replicated Diskfiles","commit_id":"f615b14024fec1f266e71a244d6319526241213e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3e05830a111428f41177dfe32c899592f358823e","unresolved":true,"context_lines":[{"line_number":1680,"context_line":"                    if min_age and \u0027data_info\u0027 in diskfile_info and \\"},{"line_number":1681,"context_line":"                            not diskfile_info[\u0027data_info\u0027][\u0027durable\u0027]:"},{"line_number":1682,"context_line":"                        try:"},{"line_number":1683,"context_line":"                            fname \u003d diskfile_info[\u0027data_file\u0027]"},{"line_number":1684,"context_line":"                            mtime \u003d os.stat(fname).st_mtime"},{"line_number":1685,"context_line":"                            if time.time() - mtime \u003c min_age:"},{"line_number":1686,"context_line":"                                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"08a5f047_5680867f","line":1683,"range":{"start_line":1683,"start_character":36,"end_line":1683,"end_character":62},"updated":"2021-06-22 17:09:39.000000000","message":"this is ok, but I\u0027m nervous that a change in get_ondisk_files (which is a bit of a mess :/) could result in some corner case throwing a KeyError, so it might be more defensive to build the path to file again using diskfile_info[\u0027data_info\u0027][\u0027filename\u0027] since we have checked locally that [\u0027data_info\u0027] exists.","commit_id":"f615b14024fec1f266e71a244d6319526241213e"}]}