)]}'
{"id":"openstack%2Fswift~797864","triplet_id":"openstack%2Fswift~master~Idd2440277516dac14ea0155da32af2fc8b603ba7","project":"openstack/swift","branch":"master","topic":"p-log-capture","hashtags":[],"change_id":"Idd2440277516dac14ea0155da32af2fc8b603ba7","subject":"Further refactor of debug_logger","status":"NEW","created":"2021-06-24 10:00:59.000000000","updated":"2021-06-24 15:43:57.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":4,"unresolved_comment_count":4,"has_review_started":true,"meta_rev_id":"51d7ff7b1ffd3e14a68c773c486b269855e7a13a","_number":797864,"virtual_id_number":797864,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-06-24 11:14:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-24 11:14:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-24 15:43:57.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"CC"}],"messages":[{"id":"caf3ed7218368dcfbdee6e6d21ebdbfe88f6cb62","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-06-24 10:00:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"70dd0c8cc0b940e002b7659448458e42a4ebb807","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 11:14:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/96f358516681436aa0dd023a936edf01 : SUCCESS in 9m 37s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/f37b6c73f31b4d87b4e623941a44a079 : SUCCESS in 10m 21s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/56ed7f9d0cb64184a334ac50f2c63216 : SUCCESS in 9m 26s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/f8c52d472e314413877d81f440958760 : SUCCESS in 16m 38s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/1e8546c269b74cf4bf796646adf567a2 : SUCCESS in 16m 25s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/f6ce86ef8c164f758f82883e1966151b : SUCCESS in 17m 55s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/889d7c1ffe2a4587aeb591e5c1520b9b : SUCCESS in 25m 40s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/719e05e738f44b308315c5028ff6067b : SUCCESS in 25m 24s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/2cfca278d73144a9a616ab193030d949 : SUCCESS in 21m 14s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/f8c78c8e52954b5d972aa551eab11c5c : SUCCESS in 24m 47s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/d17bc47f05aa4764b5fcf8ba9f836192 : SUCCESS in 19m 52s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/edbb5168ea3d4a62a8ba4d04ed7e57ee : SUCCESS in 18m 29s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/24b03ed2859a430f8800601220161fce : SUCCESS in 17m 03s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/83f3069131e14fd8b4bb03e8271669d5 : SUCCESS in 20m 56s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/17ae3b4473294d28be3d17b1b3df2ab4 : SUCCESS in 7m 41s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/451ac8721d3146ad91b68360bdf25710 : FAILURE in 27m 24s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/9820a87c3655490bb189d0d56a22c328 : SUCCESS in 53m 23s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/3326c5b6753f4022af6f27bb9863165c : SUCCESS in 47m 59s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/0fcd6d52046e4f738837346f43e3999d : SUCCESS in 39m 07s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/9704dc81d2f345eebdd3b2cf9710924d : SUCCESS in 43m 14s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/90bedbacf1b34c01b305d34a93d8ab82 : SUCCESS in 18m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1412e9cfe12649868e5cd4686f615227 : SUCCESS in 7m 12s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/42645bbdab484a6b8ab9a5159f038e82 : SUCCESS in 31m 33s","accounts_in_message":[],"_revision_number":1},{"id":"84262d447096e7ba3c275efcc5920db44f6ae38e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 11:16:48.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/6e196716df90456696cf8911db28fb7f : SUCCESS in 1h 04m 33s (non-voting)\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/71a1a2f6ff77446595ba4f79a1969f0b : SUCCESS in 1h 09m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c317e9941fe9bd94e2697752b24c6fe75ea784d4","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-06-24 15:32:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"51d7ff7b1ffd3e14a68c773c486b269855e7a13a","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-06-24 15:43:57.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nI\u0027m starting to get confused...","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4b72e5091d98d8da579382ddf2c601c961499e59","revisions":{"4b72e5091d98d8da579382ddf2c601c961499e59":{"kind":"REWORK","_number":1,"created":"2021-06-24 10:00:59.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/64/797864/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/64/797864/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/64/797864/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/64/797864/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/64/797864/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/64/797864/1"}}},"commit":{"parents":[{"commit":"40aace89f0070a06d1654edcfacadccb140c65b4","subject":"Capture logs when running custom daemons in probe tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/40aace89f0070a06d1654edcfacadccb140c65b4"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-06-24 09:54:29.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-06-24 09:57:43.000000000","tz":60},"subject":"Further refactor of debug_logger","message":"Further refactor of debug_logger\n\nMove log capture functionality from FakeLogger to DebugLogAdapter\nfor consistency with system log capture pattern. FakeLogger will\nno longer capyure logs but is currently only used as a fake syslog\nhandler.\n\nSome unit tests were previously calling\nDebugLogAdapter.logger.get_lines_for_level i.e. calling\nFakeLogger.get_lines_for_level. This was not necessary since\nDebugLogAdapter would forward a call to get_lines_for_level, but will\nnow not work because get_lines_for_level is only implemented by\nDebugLogAdapter.\n\nChange-Id: Idd2440277516dac14ea0155da32af2fc8b603ba7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4b72e5091d98d8da579382ddf2c601c961499e59"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4b72e5091d98d8da579382ddf2c601c961499e59"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}