)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"bd0ea01c06a7110da3eb8a5f5dce796b1f4928e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04688788_978a9a3e","updated":"2021-12-21 02:42:00.000000000","message":"I\u0027m hesitant to add -1 to this, because the problem is not\na fault of this patch, but the tests are a little screwy.\n\nLook how Simeon added checking to version into tests.\nYou\u0027ll notice that he also looks if the underlying, installed\nmodule has version 2. Then if yes, he mocks resolve(), and\nif not query(). But doesn\u0027t it reveal an underlying problem:\ntests will work one way or the other depending on the situation?\n\nThe right answer I would think is to use something like\nMockedResolver() from test_configured_nameservers everywhere.","commit_id":"d09883eb8007c377061ae147cc2b378228e61ed5"}],"etc/proxy-server.conf-sample":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b8bcfee2cd32dcd9a9d6c1b5455aa1ef026c7771","unresolved":true,"context_lines":[{"line_number":876,"context_line":"# nameservers \u003d"},{"line_number":877,"context_line":"#"},{"line_number":878,"context_line":"# If needed, use TCP rather than UDP (default) to query nameservers"},{"line_number":879,"context_line":"# tcp \u003d False"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"# Note: Put staticweb just after your auth filter(s) in the pipeline"},{"line_number":882,"context_line":"[filter:staticweb]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1c61ed40_cc38b0e7","line":879,"updated":"2021-06-28 17:31:39.000000000","message":"Is the primary concern about whether the nameserver dropped support entirely for UDP? Might want to call out that this affects all nameservers (if multiple are specified).\n\nAlternatively, we could make it per-nameserver by allowing configs like\n\n 127.0.0.1, tcp:127.0.0.2, 127.0.0.3:5353, tcp:[::1], udp:[::1]:5353\n\n(to borrow from the example above) where the default would be udp.","commit_id":"8816e73f3af8fddab9853f0c63bf0beeb3ae9261"}],"swift/common/middleware/cname_lookup.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b8bcfee2cd32dcd9a9d6c1b5455aa1ef026c7771","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        if lib_major_version \u003d\u003d 1:"},{"line_number":63,"context_line":"                answer \u003d resolver.query(domain, \u0027CNAME\u0027).rrset"},{"line_number":64,"context_line":"                result \u003d answer.items[0].to_text()"},{"line_number":65,"context_line":"        elif lib_major_version \u003d\u003d 2:"},{"line_number":66,"context_line":"                answer \u003d resolver.resolve(domain, \u0027CNAME\u0027, tcp\u003dtcp).rrset"},{"line_number":67,"context_line":"                result \u003d answer[0].to_text()"},{"line_number":68,"context_line":"        ttl \u003d answer.ttl"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a4fd17b_6d0a6652","line":65,"updated":"2021-06-28 17:31:39.000000000","message":"I think this would be better as an else block -- dnspython preserved the old query() API in moving to v2, I\u0027d be surprised if they completely removed the new resolve() API in any eventual v3.","commit_id":"8816e73f3af8fddab9853f0c63bf0beeb3ae9261"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b8bcfee2cd32dcd9a9d6c1b5455aa1ef026c7771","unresolved":true,"context_lines":[{"line_number":64,"context_line":"                result \u003d answer.items[0].to_text()"},{"line_number":65,"context_line":"        elif lib_major_version \u003d\u003d 2:"},{"line_number":66,"context_line":"                answer \u003d resolver.resolve(domain, \u0027CNAME\u0027, tcp\u003dtcp).rrset"},{"line_number":67,"context_line":"                result \u003d answer[0].to_text()"},{"line_number":68,"context_line":"        ttl \u003d answer.ttl"},{"line_number":69,"context_line":"        result \u003d result.rstrip(\u0027.\u0027)"},{"line_number":70,"context_line":"        return ttl, result"}],"source_content_type":"text/x-python","patch_set":1,"id":"619f4513_137c4503","line":67,"updated":"2021-06-28 17:31:39.000000000","message":"Have you done any benchmarks with dnspython\u003e\u003d2? I\u0027m a little worried about eventlet\u0027s lack of support (see https://github.com/eventlet/eventlet/issues/619) and in particular I\u0027m wondering whether the resolve() call will block all concurrent greenthreads.","commit_id":"8816e73f3af8fddab9853f0c63bf0beeb3ae9261"}]}