)]}'
{"id":"openstack%2Fswift~798914","triplet_id":"openstack%2Fswift~master~Iae4ae0f0e3cf9a5de4219643b12af785b69bce20","project":"openstack/swift","branch":"master","topic":"p-relinker-tombstones-exist","hashtags":[],"change_id":"Iae4ae0f0e3cf9a5de4219643b12af785b69bce20","subject":"relinker: don\u0027t bother checking for previous tombstone links","status":"ABANDONED","created":"2021-06-30 15:10:08.000000000","updated":"2021-07-01 11:07:15.000000000","total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"943270cefa9fc703aac0bb10236d197a862fd784","_number":798914,"virtual_id_number":798914,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-06-30 16:14:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-06-30 22:12:39.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-30 16:14:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-30 22:12:39.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2021-07-01 05:51:11.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"CC"}],"messages":[{"id":"15896c5eebc3d61e6da8df332c78055a0325f89d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-06-30 15:10:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de236bad2450a5ec2d04f2afe36ddf232b4eeef2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-30 16:14:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a4129af2ae8d4677b936877c656497a4 : SUCCESS in 12m 25s\n- grenade https://zuul.opendev.org/t/openstack/build/a99259d53c174b78bcaf3743a45870e7 : SUCCESS in 1h 02m 38s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/44d475c1fc9445108bc5ca418d0d05e1 : SUCCESS in 42m 43s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/b3fc35aa39cc4e62a41e1f01733d1b19 : SUCCESS in 10m 38s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/82f92f5fa89c47d0896e155cf4cc2df6 : SUCCESS in 10m 55s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/b22245c722874f789145caccf250b72b : SUCCESS in 17m 30s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/1ad300a540f544d983d99e9c9ff4e9e5 : SUCCESS in 18m 47s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/79d9bcf10c0143af9ca5d12d71da2fc9 : SUCCESS in 19m 42s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/329a96cca4ca4838ba6843acbe817db1 : SUCCESS in 18m 13s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/2d8c854f17cc43cdb5c47d38b91e290f : SUCCESS in 18m 31s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/b252f004cba146cbb431c9cb636a524e : SUCCESS in 18m 46s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/d267ef1946904d54a84552416c3132ae : SUCCESS in 21m 13s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/1067e6bd17794047960cac99f22a64e4 : SUCCESS in 22m 01s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/d566992b129c4ed2b6d1f37ff7f12a97 : SUCCESS in 20m 05s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/e1bf3b0b255f4758a54584f95840f6d6 : SUCCESS in 19m 48s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/dab97f7bb01248e7a0dbfd3ef44be9a0 : SUCCESS in 19m 01s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/e7923fddbac746eaa3dc78d98fb4e153 : SUCCESS in 8m 55s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/889f9481fe1c4a28863178ceb6557623 : SUCCESS in 24m 11s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/7f7379f7cf744f548755db74a8887063 : SUCCESS in 54m 26s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/253bb5c32a704afe81fd01cc8a57266d : SUCCESS in 51m 44s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/e4e170319d0545b59e5faaac8450bad4 : SUCCESS in 41m 25s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/94af7b1185804c62ae6f3e9aa5905518 : SUCCESS in 44m 17s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/91f92cdd311e40a5bf4c941ebf2c641c : SUCCESS in 18m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/17236b60c4ad4e8eac55436d2655bcdf : SUCCESS in 8m 31s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/91b7f25abc954acf9b0984ab9d0d94cc : SUCCESS in 25m 09s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3a3d21b76d5446e0bf9cb7e4c01de0a0 : SUCCESS in 57m 58s","accounts_in_message":[],"_revision_number":1},{"id":"b4fb1b731efd45b2c9cfa7e5d110610619d27675","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-30 16:24:48.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/057ed76aede44fb3949b312c3e9802cb : SUCCESS in 1h 12m 42s (non-voting)\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/f4946338c14c467c89d456ed8184f7bf : SUCCESS in 50m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"49f08044ea4d5b28d7b74e5b7a674755303c0f06","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-06-30 17:00:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0636bb0c130e6a3d4ce7d3c67f834da89d3af23e","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-06-30 22:12:39.000000000","message":"Patch Set 1: Code-Review+1\n\n(4 comments)\n\nthere\u0027s a lot of things I like in here, should definately squash everything down","accounts_in_message":[],"_revision_number":1},{"id":"6d8537f44c519acd7d308fa407ff31913a7d9ec3","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-07-01 05:51:11.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nLove patches that removes a bunch of (now) unneeded code 😊","accounts_in_message":[],"_revision_number":1},{"id":"766f393ea32425dc8ae89baea9039a1e87de9dc9","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-07-01 11:07:05.000000000","message":"Patch Set 1:\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"943270cefa9fc703aac0bb10236d197a862fd784","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-07-01 11:07:15.000000000","message":"Abandoned\n\nsquashed into https://review.opendev.org/c/openstack/swift/+/798849","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f7fbc48b587237f795982bfd338d8e2c25002a22","revisions":{"f7fbc48b587237f795982bfd338d8e2c25002a22":{"kind":"REWORK","_number":1,"created":"2021-06-30 15:10:08.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/14/798914/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/14/798914/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/14/798914/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/14/798914/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/14/798914/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/14/798914/1"}}},"commit":{"parents":[{"commit":"c03ed5c550b7db79671606a8455af0d7260a78db","subject":"relinker: tolerate existing tombstone with same X-Timestamp","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c03ed5c550b7db79671606a8455af0d7260a78db"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-06-30 15:01:21.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-06-30 15:08:39.000000000","tz":60},"subject":"relinker: don\u0027t bother checking for previous tombstone links","message":"relinker: don\u0027t bother checking for previous tombstone links\n\nSince [1] the relinker had special case handling for EEXIST errors\ncaused by a different inode tombstone already existing in the next\npartition power location: the relinker would check to see if the\nexisting next part power tombstone linked to a tombstone in a previous\npart power (i.e. \u003c current part power) location, and if so tolerate\nthe EEXIST.\n\nThis special case handling is no longer necessary because the relinker\nwill now tolerate an EEXIST when linking a tombstone provided the two\nfiles have the same timestamp. There is therefore no need to search\nprevious part power locations for a tombstone that does link with the\nnext part power location.\n\nThe link_check_limit is no longer used but the --link-check-limit\ncommand line option is still allowed (although ignored) for backwards\ncompatibility.\n\n[1] Related-Change-Id: If9beb9efabdad64e81d92708f862146d5fafb16c\n\nChange-Id: Iae4ae0f0e3cf9a5de4219643b12af785b69bce20\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/f7fbc48b587237f795982bfd338d8e2c25002a22"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/f7fbc48b587237f795982bfd338d8e2c25002a22"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}