)]}'
{"swift/container/sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4fad56b684e3781aa585b701264a9c4948f04ea9","unresolved":true,"context_lines":[{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        own_shard_range \u003d broker.get_own_shard_range(no_default\u003dTrue)"},{"line_number":1582,"context_line":"        if own_shard_range is None:"},{"line_number":1583,"context_line":"            # A default should never be SHRINKING or SHRUNK but because we"},{"line_number":1584,"context_line":"            # may write own_shard_range back to broker, let\u0027s make sure"},{"line_number":1585,"context_line":"            # it can\u0027t be defaulted."},{"line_number":1586,"context_line":"            self.logger.warning(\u0027Failed to get own_shard_range for %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9570d1d3_82657f5f","line":1583,"range":{"start_line":1583,"start_character":40,"end_line":1583,"end_character":59},"updated":"2021-07-09 21:20:22.000000000","message":"I guess we\u0027re thinking about these states because of the block down at 1642? But there are other places where we use own_shard_range...\n\nI guess any time we\u0027re in _cleave_shard_range, we expect to already have our own shard range? (And it should be marked for sharding/shrinking).","commit_id":"6709bb8891e59572cb6a1877addf7f7a3f9e6d56"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4fad56b684e3781aa585b701264a9c4948f04ea9","unresolved":true,"context_lines":[{"line_number":1670,"context_line":""},{"line_number":1671,"context_line":"        self.logger.info("},{"line_number":1672,"context_line":"            \u0027Replicating new shard container %s for %s\u0027,"},{"line_number":1673,"context_line":"            quote(shard_broker.path), shard_broker.get_own_shard_range())"},{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"        success, responses \u003d self._replicate_object("},{"line_number":1676,"context_line":"            shard_part, shard_broker.db_file, node_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c1d182aa_a0c7ec79","line":1673,"range":{"start_line":1673,"start_character":38,"end_line":1673,"end_character":72},"updated":"2021-07-09 21:20:22.000000000","message":"Off-topic: I wonder why this doesn\u0027t just use own_shard_range...","commit_id":"6709bb8891e59572cb6a1877addf7f7a3f9e6d56"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"287b2fa6894556e7febe77eb15b0ebe9ccf3cd3a","unresolved":true,"context_lines":[{"line_number":1670,"context_line":""},{"line_number":1671,"context_line":"        self.logger.info("},{"line_number":1672,"context_line":"            \u0027Replicating new shard container %s for %s\u0027,"},{"line_number":1673,"context_line":"            quote(shard_broker.path), shard_broker.get_own_shard_range())"},{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"        success, responses \u003d self._replicate_object("},{"line_number":1676,"context_line":"            shard_part, shard_broker.db_file, node_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9621035_0686bcbd","line":1673,"range":{"start_line":1673,"start_character":38,"end_line":1673,"end_character":72},"in_reply_to":"c1d182aa_a0c7ec79","updated":"2021-07-16 22:11:19.000000000","message":"Submitted https://review.opendev.org/c/openstack/swift/+/801145","commit_id":"6709bb8891e59572cb6a1877addf7f7a3f9e6d56"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4fad56b684e3781aa585b701264a9c4948f04ea9","unresolved":true,"context_lines":[{"line_number":1919,"context_line":""},{"line_number":1920,"context_line":"    def _process_broker(self, broker, node, part):"},{"line_number":1921,"context_line":"        broker.get_info()  # make sure account/container are populated"},{"line_number":1922,"context_line":"        state \u003d broker.get_db_state()"},{"line_number":1923,"context_line":"        self.logger.debug(\u0027Starting processing %s state %s\u0027,"},{"line_number":1924,"context_line":"                          quote(broker.path), state)"},{"line_number":1925,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8e8f4c_89f2e438","line":1922,"updated":"2021-07-09 21:20:22.000000000","message":"Right, so the assertion is that we should never get to SHARDING (i.e., has multiple db files) without recording our own shard range.","commit_id":"6709bb8891e59572cb6a1877addf7f7a3f9e6d56"}]}