)]}'
{"swift/proxy/server.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4b545b86283ff2d5325989435252e7a64060673a","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        self.allow_account_management \u003d \\"},{"line_number":232,"context_line":"            config_true_value(conf.get(\u0027allow_account_management\u0027, \u0027no\u0027))"},{"line_number":233,"context_line":"        self.allow_modify_pipeline \u003d \\"},{"line_number":234,"context_line":"            config_true_value(conf.get(\u0027allow_modify_pipeline\u0027, \u0027yes\u0027))"},{"line_number":235,"context_line":"        self.container_ring \u003d container_ring or Ring(swift_dir,"},{"line_number":236,"context_line":"                                                     ring_name\u003d\u0027container\u0027)"},{"line_number":237,"context_line":"        self.account_ring \u003d account_ring or Ring(swift_dir,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d9c64e5_0daad28a","line":234,"updated":"2021-08-09 20:28:21.000000000","message":"I believe load app also has access to conf as ctx.config - but possibly not yet merged with global_conf - so if we HAVE to read this from a config file we might want to do it here","commit_id":"2f8a221706d42029f266ffb4872dd27e8bc78685"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"021b8184b59b2fe54d6ce1eb60a8e1bf0fedc122","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        self.allow_account_management \u003d \\"},{"line_number":232,"context_line":"            config_true_value(conf.get(\u0027allow_account_management\u0027, \u0027no\u0027))"},{"line_number":233,"context_line":"        self.allow_modify_pipeline \u003d \\"},{"line_number":234,"context_line":"            config_true_value(conf.get(\u0027allow_modify_pipeline\u0027, \u0027yes\u0027))"},{"line_number":235,"context_line":"        self.container_ring \u003d container_ring or Ring(swift_dir,"},{"line_number":236,"context_line":"                                                     ring_name\u003d\u0027container\u0027)"},{"line_number":237,"context_line":"        self.account_ring \u003d account_ring or Ring(swift_dir,"}],"source_content_type":"text/x-python","patch_set":1,"id":"211d2fcb_53451bab","line":234,"in_reply_to":"6d9c64e5_0daad28a","updated":"2021-08-09 21:29:10.000000000","message":"Yeah -- I could maybe get behind that. But I never much *liked* the allow_modify_pipeline option to loadapp (or internal_client...); doing it as a config option feels much more obvious (to me).","commit_id":"2f8a221706d42029f266ffb4872dd27e8bc78685"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4b545b86283ff2d5325989435252e7a64060673a","unresolved":true,"context_lines":[{"line_number":738,"context_line":"        if not self.allow_modify_pipeline:"},{"line_number":739,"context_line":"            self.logger.debug("},{"line_number":740,"context_line":"                \"Pipeline modification disabled; pipeline is \\\"%s\\\"\", pipe)"},{"line_number":741,"context_line":"            return"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        pipeline_was_modified \u003d False"},{"line_number":744,"context_line":"        for filter_spec in reversed(required_filters):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cf00791a_219d1c7f","line":741,"updated":"2021-08-09 20:28:21.000000000","message":"the caller of this has the app, and the config in hand - it\u0027s weird have to triggers with the same name applied in different ways so close together","commit_id":"2f8a221706d42029f266ffb4872dd27e8bc78685"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4b545b86283ff2d5325989435252e7a64060673a","unresolved":true,"context_lines":[{"line_number":763,"context_line":"            self.logger.info(\"Pipeline was modified. \""},{"line_number":764,"context_line":"                             \"New pipeline is \\\"%s\\\".\", pipe)"},{"line_number":765,"context_line":"        else:"},{"line_number":766,"context_line":"            self.logger.debug(\"Pipeline is \\\"%s\\\"\", pipe)"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"def parse_per_policy_config(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"2e5c084f_e5b0c55f","line":766,"updated":"2021-08-09 20:28:21.000000000","message":"I this all this logging is great; I\u0027m happy to see it preserved","commit_id":"2f8a221706d42029f266ffb4872dd27e8bc78685"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"021b8184b59b2fe54d6ce1eb60a8e1bf0fedc122","unresolved":true,"context_lines":[{"line_number":763,"context_line":"            self.logger.info(\"Pipeline was modified. \""},{"line_number":764,"context_line":"                             \"New pipeline is \\\"%s\\\".\", pipe)"},{"line_number":765,"context_line":"        else:"},{"line_number":766,"context_line":"            self.logger.debug(\"Pipeline is \\\"%s\\\"\", pipe)"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"def parse_per_policy_config(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"be9ce087_b9406e70","line":766,"in_reply_to":"2e5c084f_e5b0c55f","updated":"2021-08-09 21:29:10.000000000","message":"100% -- I feel like this has saved me a lot of back and forth on launchpad bugs involving pipeline shenanigans. It\u0027s part of why I wanted to be able to log\n\n\u003e Pipeline modification disabled; pipeline is ...\n\nabove.","commit_id":"2f8a221706d42029f266ffb4872dd27e8bc78685"}]}