)]}'
{"swift/common/wsgi.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"04709b451e09b32afe4e03f408bcd1d85c1858b3","unresolved":true,"context_lines":[{"line_number":393,"context_line":"        # create the app and allow it to setup config attrs"},{"line_number":394,"context_line":"        app \u003d ctx.app_context.create()"},{"line_number":395,"context_line":"        if not allow_modify_pipeline:"},{"line_number":396,"context_line":"            app.allow_modify_pipeline \u003d False"},{"line_number":397,"context_line":"        # give app the opportunity to modify the pipeline context"},{"line_number":398,"context_line":"        func \u003d getattr(app, \u0027modify_wsgi_pipeline\u0027, lambda: None)"},{"line_number":399,"context_line":"        func(PipelineWrapper(ctx))"}],"source_content_type":"text/x-python","patch_set":1,"id":"db38c387_8095274d","line":396,"updated":"2021-08-09 21:16:27.000000000","message":"I\u0027m getting some spooky action-at-a-distance vibes, but I guess that\u0027s to be expected whenever we\u0027ve got something involving modify_wsgi_pipeline :-/\n\nAnd it doesn\u0027t even remove the need for the funky\n\n    if not allow_modify_pipeline and utils.config_true_value(\n            conf.get(\u0027allow_modify_pipeline\u0027, \u0027yes\u0027)):\n        raise ConfigFileError(\u0027unmodified pipeline requested, but config \u0027\n                              \u0027file is set to modify\u0027)\n\nblock in my hacked-up alternate InternalClient... I\u0027ll end up calling loadapp with allow_modify_pipeline\u003dFalse, but then ignore the result and spawn a proxy-server subprocess that only knows about the config :-(","commit_id":"5e8762e5e885b5b53c36bdc4490068a07377dc08"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"04709b451e09b32afe4e03f408bcd1d85c1858b3","unresolved":true,"context_lines":[{"line_number":396,"context_line":"            app.allow_modify_pipeline \u003d False"},{"line_number":397,"context_line":"        # give app the opportunity to modify the pipeline context"},{"line_number":398,"context_line":"        func \u003d getattr(app, \u0027modify_wsgi_pipeline\u0027, lambda: None)"},{"line_number":399,"context_line":"        func(PipelineWrapper(ctx))"},{"line_number":400,"context_line":"        # cache the freshly created app so we don\u0027t have to redo"},{"line_number":401,"context_line":"        # initialization checks and log startup messages again"},{"line_number":402,"context_line":"        ctx.app_context.create \u003d lambda: app"}],"source_content_type":"text/x-python","patch_set":1,"id":"51b3685d_ec3b37f1","line":399,"updated":"2021-08-09 21:16:27.000000000","message":"I *do* tend to prefer \"always call this thing; sometimes it will have an effect\" over \"check if it has a thing; if it does *and* this other condition, call it.\"","commit_id":"5e8762e5e885b5b53c36bdc4490068a07377dc08"}],"test/unit/common/test_wsgi.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"04709b451e09b32afe4e03f408bcd1d85c1858b3","unresolved":true,"context_lines":[{"line_number":1886,"context_line":""},{"line_number":1887,"context_line":"            # make sure you can turn off the pipeline modification if you want"},{"line_number":1888,"context_line":"            def blow_up(app, pipe):"},{"line_number":1889,"context_line":"                if app.allow_modify_pipeline:"},{"line_number":1890,"context_line":"                    raise self.fail(\"all your pipelinz are belong to us\")"},{"line_number":1891,"context_line":""},{"line_number":1892,"context_line":"            with mock.patch("}],"source_content_type":"text/x-python","patch_set":1,"id":"c14688ff_a6197e07","line":1889,"updated":"2021-08-09 21:16:27.000000000","message":"Hmm... so any hypothetical alternate wsgi apps that want/need to use swift\u0027s loadapp (may?) need to learn about this new attribute...\n\nWell, swiftonfile doesn\u0027t seem to use modify_wsgi_pipeline. It\u0027s probably fine.","commit_id":"5e8762e5e885b5b53c36bdc4490068a07377dc08"}]}