)]}'
{"id":"openstack%2Fswift~804106","triplet_id":"openstack%2Fswift~master~I61f47bf63e2924f3a49322921eb8401ad5d3b18c","project":"openstack/swift","branch":"master","topic":"container-server-return-specified-api-objs","hashtags":[],"change_id":"I61f47bf63e2924f3a49322921eb8401ad5d3b18c","subject":"DNM: set and forget root spi","status":"ABANDONED","created":"2021-08-10 15:56:57.000000000","updated":"2021-08-11 18:20:35.000000000","total_comment_count":3,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"5ce7bf8793ef538896d09785e5dfc99a6ec85622","_number":804106,"virtual_id_number":804106,"owner":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-08-10 17:36:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":1,"date":"2021-08-11 13:31:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":-1,"date":"2021-08-10 16:02:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-10 17:34:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-10 17:36:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-11 13:31:06.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"}],"messages":[{"id":"e7acb9134ea68fcbc061d974e44d90649d6ade3a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-08-10 15:56:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c6fb7f5a6b209bfaca3d5a150cba4747d11b8c7c","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-08-10 16:02:47.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nthe one thing i\u0027m not 100% on the parent patch is the flow when an uncached response from a not-yet-upgraded server doesn\u0027t return the spi\n\nI have some notion the reasoning behind the conditionals here are a little more obvious - curious for others initial reaction and feedback\n\nif an approach like this warrents further work we\u0027ll need to think about replacing the tests I removed","accounts_in_message":[],"_revision_number":1},{"id":"3027b3437c75560805a49a43205335a33e74b912","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-10 17:34:40.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/7ad89e967e4742b38febcfeb273a4fdd : SUCCESS in 36m 48s (non-voting)\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/f07e836ce8d94ebcb33c30e4fe942bf6 : SUCCESS in 36m 19s (non-voting)\n- swift-probetests-centos-8-arm64 https://zuul.opendev.org/t/openstack/build/2606cf23dd2749eaaa01ddce49635cd9 : SUCCESS in 1h 30m 41s (non-voting)\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/d01eef559d544b978dfc40648b977140 : SUCCESS in 43m 28s (non-voting)\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/5b2bcd82db32430fb940f5352809c559 : SUCCESS in 38m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"86d81690f64c036dd3f00f94d88856cd21478a00","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-10 17:36:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b46ee38916714934ab174e36c0d20023 : SUCCESS in 9m 08s\n- grenade https://zuul.opendev.org/t/openstack/build/105efd2b5db14408885b113eca8c9762 : SUCCESS in 1h 02m 08s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/b0e30b347f3b434bba1f6b36a8703905 : SUCCESS in 49m 03s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/bfdccd75d819478eba41001d74f5982f : SUCCESS in 9m 46s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/071e6efc7c304a61b12c5a9370266260 : SUCCESS in 9m 38s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/6988ec22c7964df3aa8e6afa0ae910ee : SUCCESS in 17m 00s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/eb29e6239f624898abe2cfb31943538a : SUCCESS in 16m 25s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/ce1ca30387374c73ad92fe99e48046d9 : SUCCESS in 18m 02s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/058bf08841a14b93906c9da2f3f35d71 : SUCCESS in 18m 07s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/45aa514b107c4a8b92c721193892ca93 : SUCCESS in 16m 51s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/712978b27da04e6b8f79ee3a6a6e5e4b : SUCCESS in 19m 40s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/c1e3ac88f1284cbeb1ebe26ce8a1e95f : SUCCESS in 18m 27s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/bcaf844844294110a61f56731fff1fa8 : SUCCESS in 21m 59s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/94fce495eb204ef190e11b0dc736d777 : SUCCESS in 21m 44s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/3c496a7217a8461ea6f996330279cd76 : SUCCESS in 17m 36s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/bd0d7b509e7c40029303a855c5788696 : SUCCESS in 19m 24s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/d264696f4ebb44619c5ce6e1dc3cfef4 : SUCCESS in 9m 41s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/a16b66210ad7408d861fcffbfdf6197c : SUCCESS in 28m 42s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/07147d3cf49d42bda5488e98567529c9 : SUCCESS in 1h 00m 01s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/4577e3febe6b446293b777b4b119fba3 : SUCCESS in 58m 29s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/a6f7c9976d46483aa80b0ba7ac2e71a5 : SUCCESS in 39m 56s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/910212c0f29d424f9c37e3bc530e28fc : SUCCESS in 40m 57s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/306ffa82f426456bb8489ad7bc8a8567 : SUCCESS in 17m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/da3e455af3594309865412a585b93a03 : SUCCESS in 7m 09s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/efca4b6de1fa46c8a35a27f87b83db72 : SUCCESS in 24m 27s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/02e59df294b44396b4fe54bfc7bc3e06 : SUCCESS in 46m 03s","accounts_in_message":[],"_revision_number":1},{"id":"ba547b4ecb73f9fe435f898725a0eb203d93987a","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-08-11 13:31:06.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)\n\nThis works, I put an alternative here, and fixed the test https://review.opendev.org/c/openstack/swift/+/804234\n\nI don\u0027t think we\u0027re fixing any bug with the parent[1], just making the code more explicit.\n\n[1] on the basis that, in the parent patch, the root response would always have the SPI header and so the subrequests will always have that SPI set.","accounts_in_message":[],"_revision_number":1},{"id":"5ce7bf8793ef538896d09785e5dfc99a6ec85622","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-08-11 18:20:35.000000000","message":"Abandoned\n\nI think https://review.opendev.org/c/openstack/swift/+/804234 is better","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9be40868ac9a87fd4f26ace1225e48395cdfe7fd","revisions":{"9be40868ac9a87fd4f26ace1225e48395cdfe7fd":{"kind":"REWORK","_number":1,"created":"2021-08-10 15:56:57.000000000","uploader":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"ref":"refs/changes/06/804106/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/06/804106/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/06/804106/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/06/804106/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/06/804106/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/06/804106/1"}}},"commit":{"parents":[{"commit":"63c6933f5d938bea47c365407ab7cea0b015b033","subject":"container-server: return objects of a given policy","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/63c6933f5d938bea47c365407ab7cea0b015b033"}]}],"author":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2021-08-10 15:55:01.000000000","tz":-300},"committer":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2021-08-10 15:55:01.000000000","tz":-300},"subject":"DNM: set and forget root spi","message":"DNM: set and forget root spi\n\nChange-Id: I61f47bf63e2924f3a49322921eb8401ad5d3b18c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9be40868ac9a87fd4f26ace1225e48395cdfe7fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9be40868ac9a87fd4f26ace1225e48395cdfe7fd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}