)]}'
{"swift/common/wsgi.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6b9ee7cb0b7d08e51ed82b133bc3eec707f2bad3","unresolved":true,"context_lines":[{"line_number":1053,"context_line":"    # Load configuration, Set logger and Load request processor"},{"line_number":1054,"context_line":"    try:"},{"line_number":1055,"context_line":"        (conf, logger, log_name) \u003d \\"},{"line_number":1056,"context_line":"            _initrp(conf_path, app_section, *args, **kwargs)"},{"line_number":1057,"context_line":"    except ConfigFileError as e:"},{"line_number":1058,"context_line":"        print(e)"},{"line_number":1059,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"8e26a6a4_0ef869a8","line":1056,"updated":"2021-08-17 20:06:26.000000000","message":"I don\u0027t really understand why the signature is like this - we don\u0027t seem to actually *use* args in _initrp","commit_id":"5121b0a58b460159ef9a601ed1bfecb11e442a0a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52b4a94db900688b05ba0e771af313c0e9eb6ecb","unresolved":true,"context_lines":[{"line_number":1053,"context_line":"    # Load configuration, Set logger and Load request processor"},{"line_number":1054,"context_line":"    try:"},{"line_number":1055,"context_line":"        (conf, logger, log_name) \u003d \\"},{"line_number":1056,"context_line":"            _initrp(conf_path, app_section, *args, **kwargs)"},{"line_number":1057,"context_line":"    except ConfigFileError as e:"},{"line_number":1058,"context_line":"        print(e)"},{"line_number":1059,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"3b63608b_a7015a4c","line":1056,"in_reply_to":"8e26a6a4_0ef869a8","updated":"2021-08-17 23:53:54.000000000","message":"Yeah, I got nothing there.","commit_id":"5121b0a58b460159ef9a601ed1bfecb11e442a0a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6b9ee7cb0b7d08e51ed82b133bc3eec707f2bad3","unresolved":true,"context_lines":[{"line_number":1085,"context_line":"    utils.eventlet_monkey_patch()"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"    # Ensure the configuration and application can be loaded before proceeding."},{"line_number":1088,"context_line":"    global_conf \u003d {\u0027log_name\u0027: log_name}"},{"line_number":1089,"context_line":"    loadapp(conf_path, global_conf\u003dglobal_conf)"},{"line_number":1090,"context_line":"    if \u0027global_conf_callback\u0027 in kwargs:"},{"line_number":1091,"context_line":"        kwargs[\u0027global_conf_callback\u0027](conf, global_conf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c727e6f_65caa855","line":1088,"updated":"2021-08-17 20:06:26.000000000","message":"i guess there\u0027s no way for a run_server caller to modify this tho","commit_id":"5121b0a58b460159ef9a601ed1bfecb11e442a0a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6b9ee7cb0b7d08e51ed82b133bc3eec707f2bad3","unresolved":true,"context_lines":[{"line_number":1090,"context_line":"    if \u0027global_conf_callback\u0027 in kwargs:"},{"line_number":1091,"context_line":"        kwargs[\u0027global_conf_callback\u0027](conf, global_conf)"},{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"    allow_modify_pipeline \u003d kwargs.get(\u0027allow_modify_pipeline\u0027, True)"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"    # set utils.FALLOCATE_RESERVE if desired"},{"line_number":1096,"context_line":"    utils.FALLOCATE_RESERVE, utils.FALLOCATE_IS_PERCENT \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"11f84272_f85c0378","line":1093,"updated":"2021-08-17 20:06:26.000000000","message":"it\u0027d be better if this was in signature; or at least the doc string","commit_id":"5121b0a58b460159ef9a601ed1bfecb11e442a0a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52b4a94db900688b05ba0e771af313c0e9eb6ecb","unresolved":true,"context_lines":[{"line_number":1090,"context_line":"    if \u0027global_conf_callback\u0027 in kwargs:"},{"line_number":1091,"context_line":"        kwargs[\u0027global_conf_callback\u0027](conf, global_conf)"},{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"    allow_modify_pipeline \u003d kwargs.get(\u0027allow_modify_pipeline\u0027, True)"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"    # set utils.FALLOCATE_RESERVE if desired"},{"line_number":1096,"context_line":"    utils.FALLOCATE_RESERVE, utils.FALLOCATE_IS_PERCENT \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"0b423c7f_e936adf2","line":1093,"in_reply_to":"11f84272_f85c0378","updated":"2021-08-17 23:53:54.000000000","message":"#willfix","commit_id":"5121b0a58b460159ef9a601ed1bfecb11e442a0a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6b9ee7cb0b7d08e51ed82b133bc3eec707f2bad3","unresolved":true,"context_lines":[{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"    no_fork_sock \u003d strategy.no_fork_sock()"},{"line_number":1104,"context_line":"    if no_fork_sock:"},{"line_number":1105,"context_line":"        run_server(conf, logger, no_fork_sock, global_conf\u003dglobal_conf,"},{"line_number":1106,"context_line":"                   ready_callback\u003dstrategy.signal_ready,"},{"line_number":1107,"context_line":"                   allow_modify_pipeline\u003dallow_modify_pipeline)"},{"line_number":1108,"context_line":"        return 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"b3c747c4_7df3b502","line":1105,"updated":"2021-08-17 20:06:26.000000000","message":"isn\u0027t this the same global_conf that\u0027s already plumbed all the way down to loadapp?","commit_id":"5121b0a58b460159ef9a601ed1bfecb11e442a0a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52b4a94db900688b05ba0e771af313c0e9eb6ecb","unresolved":true,"context_lines":[{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"    no_fork_sock \u003d strategy.no_fork_sock()"},{"line_number":1104,"context_line":"    if no_fork_sock:"},{"line_number":1105,"context_line":"        run_server(conf, logger, no_fork_sock, global_conf\u003dglobal_conf,"},{"line_number":1106,"context_line":"                   ready_callback\u003dstrategy.signal_ready,"},{"line_number":1107,"context_line":"                   allow_modify_pipeline\u003dallow_modify_pipeline)"},{"line_number":1108,"context_line":"        return 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"fd07a85b_0aaee209","line":1105,"in_reply_to":"b3c747c4_7df3b502","updated":"2021-08-17 23:53:54.000000000","message":"Yup -- I was noticing that this feels suspicious, too. Either this shouldn\u0027t pass global_conf, or we should start passing it down below when spawning workers. But IDK which, and didn\u0027t want to get into it right now.","commit_id":"5121b0a58b460159ef9a601ed1bfecb11e442a0a"}]}