)]}'
{"id":"openstack%2Fswift~804696","triplet_id":"openstack%2Fswift~master~I7a9aa13bbe06bc6360040f489d4cbc220f09e2be","project":"openstack/swift","branch":"master","topic":"container-server-return-specified-api-objs","hashtags":[],"change_id":"I7a9aa13bbe06bc6360040f489d4cbc220f09e2be","subject":"container: return correct record type and policy index headers","status":"NEW","created":"2021-08-16 10:33:01.000000000","updated":"2021-08-16 14:37:18.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0574576aa8d073307d9a1ff82fd7dabfc99f4777","_number":804696,"virtual_id_number":804696,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-08-16 13:53:29.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-16 12:01:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"09a2f0a0d542125e77dd4b7bee87b14b32d5689f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-08-16 10:33:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2e635b03b9c4b44945072632b81441fa66fb15ab","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-08-16 10:35:00.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"a1844b75754dac47ea59aea11c0ab334c37fed86","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-08-16 10:57:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2b0ffccae1c4b0ed8325de775ba3e36405327dd6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-16 12:01:34.000000000","message":"Patch Set 3: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0ecc05368da74a4ba39a61a593c4ac9f : SUCCESS in 10m 12s\n- grenade https://zuul.opendev.org/t/openstack/build/77364f8d89584847b57a66ff881d3ec3 : SUCCESS in 59m 10s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/bc8365cae07b45128c490d10877f959d : SUCCESS in 44m 58s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/49bd06930ee3471995d6541a5ea973c3 : SUCCESS in 8m 44s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/0a5286d159484090bb36b3ade7d31e11 : SUCCESS in 9m 17s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/cf9ded6cf28a42de8a4b3bf4f5a40b40 : SUCCESS in 22m 32s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/21de96d778b04097ba0e568ba6da1cf2 : SUCCESS in 16m 50s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/6aaaaade0ad645c7bc446bf1accfad66 : SUCCESS in 17m 57s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/ce58eb1423b04eb4a9ada77ab5cc9303 : SUCCESS in 17m 51s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/290880eed85447cbb6f751125202d5d3 : SUCCESS in 15m 55s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/75fc6df14c5047598967cfa55e1994bb : SUCCESS in 18m 20s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/62974110c20c40a893cc0497a6890648 : SUCCESS in 32m 04s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/e2bc5423ab344d1a8bb50fc8f82f493c : SUCCESS in 21m 46s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/e876d85fbad44fb398e63cd7ce79973b : SUCCESS in 16m 30s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/1c208b35dafa4968a3d9aaf0c514f32c : SUCCESS in 20m 26s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/44cdb12f3f3c4034856aedc30d946f6c : SUCCESS in 23m 19s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/0ca9278d6b7f415f9da4bdfcb75686d0 : SUCCESS in 7m 11s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/f2ac67ad9bc74559b06c07a75c63a9b8 : SUCCESS in 24m 00s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/5337726d531942b6a96f6d732fe052b7 : SUCCESS in 55m 33s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/e75eebb597c14f3db8b413d504227ae9 : SUCCESS in 57m 00s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/e1d82adec50b4361bccc0b485a121c91 : SUCCESS in 44m 40s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/2892205771914141863e20ec25d0ac3f : SUCCESS in 42m 36s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/aa402c78b8f24c10af284c9dc7951841 : SUCCESS in 20m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6d6db8f58a0d48b38f7371f762d6311d : FAILURE in 7m 33s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/7709a8b4a7d14c888091ab835bc281f3 : SUCCESS in 29m 20s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6d27f4616518474693b73f23af1dd7cc : SUCCESS in 45m 43s","accounts_in_message":[],"_revision_number":3},{"id":"91dedf5932a1544cc0e5ddd1df7568f4f0230e85","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-16 12:47:22.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/f3480eb181eb4adc99eddebbdb2187b6 : SUCCESS in 42m 59s (non-voting)\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/0c2bef9900ab4ca1b3fecc249a07cf5b : SUCCESS in 48m 59s (non-voting)\n- swift-probetests-centos-8-arm64 https://zuul.opendev.org/t/openstack/build/591ef71a082f480ba9152dce49e0d42e : FAILURE in 1h 46m 13s (non-voting)\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/71cf00f419454f4c96cd5aad88d58250 : SUCCESS in 42m 23s (non-voting)\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/6dce3dc243ea42cf8de4102f4f984924 : SUCCESS in 44m 33s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d04f57911da7c72ee81c0aa613284762749e2fa7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-08-16 12:50:54.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"b90899443d96d80244b7a257a18c697e8a511007","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-16 13:53:29.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cbf52172ea694916aa7d7832054cfffe : SUCCESS in 11m 43s\n- grenade https://zuul.opendev.org/t/openstack/build/90c5dc4780614dfc933a834867aaff90 : SUCCESS in 57m 28s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/546e1a45a5b54074a1799337c643274f : SUCCESS in 41m 08s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/80cc905157f744a58a837d9e9fc2f9a2 : SUCCESS in 8m 20s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/562b4a6816884e78b44f9421e9de80bd : SUCCESS in 9m 22s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/e38aa17bb0f5417f8e4ce041ce84a597 : SUCCESS in 21m 18s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/fe7016a67c57432e9fd4fddd693ed4f1 : SUCCESS in 20m 18s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/59d17efd1302466a8e608a497b7a92b5 : SUCCESS in 20m 13s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/535adbb8cac646858e8ba807e6b0508d : SUCCESS in 21m 11s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/abc5f321f9784043ac95c8b94aa4fb99 : SUCCESS in 22m 10s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/818ef5706cd74af8a8b9524b68d358ce : SUCCESS in 21m 52s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/d520213273364d3d9253fdc48a370b47 : SUCCESS in 20m 32s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/07c9cb0b370646cd83753bf34778b4c8 : SUCCESS in 17m 48s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/43f7acee5e884fa194a914fee7b8d1cc : SUCCESS in 21m 02s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/4a770c101ed349f29d163a3194e23394 : SUCCESS in 20m 05s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/091d1fd183c64452a79f5f7564586cf6 : SUCCESS in 20m 07s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/343518227d124586b0180ff9a2aa76ad : SUCCESS in 6m 12s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/40efd21e365d4da0a9fb14477536bbbf : SUCCESS in 24m 41s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/d06bcdc1f5db47b2868beb745d8490f9 : SUCCESS in 52m 38s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/a4a261fc20fb46ecb3f4d88a383d6a36 : SUCCESS in 57m 37s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/5c88920ba672477c868f19185ce3978a : SUCCESS in 41m 52s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/8b4bd8e0d2cf414296089ce77e20d257 : SUCCESS in 39m 33s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7fccf23a71e64ac58a9023d40310709c : SUCCESS in 15m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fac37830c0ce4e6391e4df5d0c3e6456 : SUCCESS in 6m 52s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/d1826f421d564d16a565e18d2e3d3fd2 : SUCCESS in 25m 56s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7c44b165d1cc45e5808099c4e3464791 : SUCCESS in 44m 03s","accounts_in_message":[],"_revision_number":4},{"id":"0574576aa8d073307d9a1ff82fd7dabfc99f4777","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-16 14:37:18.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/98aefc8296794b6f9585b894ae1fabea : SUCCESS in 40m 59s (non-voting)\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/cc5a622dd7d146c1bbc3cb5fa2e4a3f2 : SUCCESS in 41m 52s (non-voting)\n- swift-probetests-centos-8-arm64 https://zuul.opendev.org/t/openstack/build/25f6ec38265a46fba87658e20e786320 : SUCCESS in 1h 33m 43s (non-voting)\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/ab4e408917774d439c9fb4b322b6c9e6 : SUCCESS in 44m 36s (non-voting)\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/1e9888ce7f95479c8940cfcbdd22f28e : SUCCESS in 43m 45s (non-voting)","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2fcc887dfeed8a1feaa41eaa15d825c8a293c47b","revisions":{"79eaa50e2846e6765eeaab44503f05b4de9e731a":{"kind":"REWORK","_number":1,"created":"2021-08-16 10:33:01.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/96/804696/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/96/804696/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/96/804696/1"}}},"commit":{"parents":[{"commit":"fb6a1acfc249ee56ae4a37cfdb1af4ffd5ebfc42","subject":"container GET: return 503 if policy index mismatches","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/fb6a1acfc249ee56ae4a37cfdb1af4ffd5ebfc42"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-08-16 10:27:24.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-08-16 10:27:24.000000000","tz":60},"subject":"container: return correct record type and policy index headers","message":"container: return correct record type and policy index headers\n\nWhen the proxy container controller constructs a listing from shards\nit populates the body of the original root container response with\nobject records from the shards. However, the response headers were not\nmodified and so still had \u0027X-Backend-Record-Type\u0027 equal to\n\u0027shard\u0027. The response headers also did not have a\n\u0027X-Backend-Record-Storage-Policy-Index\u0027 header. In both respects the\nresponse differed from a listing response from an unsharded container.\n\nThis patch modifies the original root response \u0027X-Backend-Record-Type\u0027\nvalue to \u0027object\u0027 and adds \u0027X-Backend-Record-Storage-Policy-Index\u0027\nheader with value equal to either the request\n\u0027X-Backend-Storage-Policy-Index\u0027 header or, if that is not present,\nthe root response\u0027s \u0027X-Backend-Record-Storage-Policy-Index\u0027 header.\n\nChange-Id: I7a9aa13bbe06bc6360040f489d4cbc220f09e2be\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/79eaa50e2846e6765eeaab44503f05b4de9e731a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/79eaa50e2846e6765eeaab44503f05b4de9e731a"}]},"branch":"refs/heads/master"},"637943ef7d2d0d6edfc985b3be68b10a2e149f4b":{"kind":"NO_CHANGE","_number":2,"created":"2021-08-16 10:35:00.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/96/804696/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/96/804696/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/96/804696/2"}}},"commit":{"parents":[{"commit":"20459d9877bec42982895fcf403ac22a2731a1ac","subject":"container GET: return 503 if policy index mismatches","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/20459d9877bec42982895fcf403ac22a2731a1ac"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-08-16 10:27:24.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-08-16 10:34:52.000000000","tz":60},"subject":"container: return correct record type and policy index headers","message":"container: return correct record type and policy index headers\n\nWhen the proxy container controller constructs a listing from shards\nit populates the body of the original root container response with\nobject records from the shards. However, the response headers were not\nmodified and so still had \u0027X-Backend-Record-Type\u0027 equal to\n\u0027shard\u0027. The response headers also did not have a\n\u0027X-Backend-Record-Storage-Policy-Index\u0027 header. In both respects the\nresponse differed from a listing response from an unsharded container.\n\nThis patch modifies the original root response \u0027X-Backend-Record-Type\u0027\nvalue to \u0027object\u0027 and adds \u0027X-Backend-Record-Storage-Policy-Index\u0027\nheader with value equal to either the request\n\u0027X-Backend-Storage-Policy-Index\u0027 header or, if that is not present,\nthe root response\u0027s \u0027X-Backend-Record-Storage-Policy-Index\u0027 header.\n\nChange-Id: I7a9aa13bbe06bc6360040f489d4cbc220f09e2be\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/637943ef7d2d0d6edfc985b3be68b10a2e149f4b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/637943ef7d2d0d6edfc985b3be68b10a2e149f4b"}]},"branch":"refs/heads/master"},"c8356f74c52c87773c4790d902c0448fb007c53b":{"kind":"REWORK","_number":3,"created":"2021-08-16 10:57:06.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/96/804696/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/96/804696/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/96/804696/3"}}},"commit":{"parents":[{"commit":"777288d224c31c6f4f2e219006818cd7bfe20e02","subject":"container GET: return 503 if policy index mismatches","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/777288d224c31c6f4f2e219006818cd7bfe20e02"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-08-16 10:27:24.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-08-16 10:56:54.000000000","tz":60},"subject":"container: return correct record type and policy index headers","message":"container: return correct record type and policy index headers\n\nWhen the proxy container controller constructs a listing from shards\nit populates the body of the original root container response with\nobject records from the shards. However, the response headers were not\nmodified and so still had \u0027X-Backend-Record-Type\u0027 equal to\n\u0027shard\u0027. The response headers also did not have a\n\u0027X-Backend-Record-Storage-Policy-Index\u0027 header. In both respects the\nresponse differed from a listing response from an unsharded container.\n\nThis patch modifies the original root response \u0027X-Backend-Record-Type\u0027\nvalue to \u0027object\u0027 and adds \u0027X-Backend-Record-Storage-Policy-Index\u0027\nheader with value equal to either the request\n\u0027X-Backend-Storage-Policy-Index\u0027 header or, if that is not present,\nthe root response\u0027s \u0027X-Backend-Record-Storage-Policy-Index\u0027 header.\n\nChange-Id: I7a9aa13bbe06bc6360040f489d4cbc220f09e2be\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c8356f74c52c87773c4790d902c0448fb007c53b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c8356f74c52c87773c4790d902c0448fb007c53b"}]},"branch":"refs/heads/master"},"2fcc887dfeed8a1feaa41eaa15d825c8a293c47b":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2021-08-16 12:50:54.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/96/804696/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/96/804696/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/804696/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/96/804696/4"}}},"commit":{"parents":[{"commit":"2992f14176ca31918a02cbf5f52fe2a2852750db","subject":"container GET: return 503 if policy index mismatches","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2992f14176ca31918a02cbf5f52fe2a2852750db"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-08-16 10:27:24.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-08-16 12:50:24.000000000","tz":60},"subject":"container: return correct record type and policy index headers","message":"container: return correct record type and policy index headers\n\nWhen the proxy container controller constructs a listing from shards\nit populates the body of the original root container response with\nobject records from the shards. However, the response headers were not\nmodified and so still had \u0027X-Backend-Record-Type\u0027 equal to\n\u0027shard\u0027. The response headers also did not have a\n\u0027X-Backend-Record-Storage-Policy-Index\u0027 header. In both respects the\nresponse differed from a listing response from an unsharded container.\n\nThis patch modifies the original root response \u0027X-Backend-Record-Type\u0027\nvalue to \u0027object\u0027 and adds \u0027X-Backend-Record-Storage-Policy-Index\u0027\nheader with value equal to either the request\n\u0027X-Backend-Storage-Policy-Index\u0027 header or, if that is not present,\nthe root response\u0027s \u0027X-Backend-Record-Storage-Policy-Index\u0027 header.\n\nChange-Id: I7a9aa13bbe06bc6360040f489d4cbc220f09e2be\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2fcc887dfeed8a1feaa41eaa15d825c8a293c47b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2fcc887dfeed8a1feaa41eaa15d825c8a293c47b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}