)]}'
{"api-ref/source/storage-account-services.inc":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"64d4e4d7aa07e05bd469f9b9e33c2de45a7f9420","unresolved":true,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"If an exception occurs interrupting the account deletion, it is"},{"line_number":379,"context_line":"automatically resumed the next time the request is made with the same"},{"line_number":380,"context_line":"parameters."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"It\u0027s only with the -v option that the response headers are output to stdout."},{"line_number":383,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ff666da6_a9c0dfd1","line":380,"updated":"2021-08-24 16:30:26.000000000","message":"What\u0027s the main idea behind this paragraph? That in the face of server errors or timeouts, the request should be safe to retry?\n\nThe phrase \"it is automatically resumed\" makes it seem like an active process, where data is deleted inline with the request. The actual implementation is asynchronous, though -- it might be worth linking to the account-reaper docs at https://docs.openstack.org/swift/latest/overview_reaper.html","commit_id":"065c4ee4811d64ba1933e5fbbe3fb9369b99a3d0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"64d4e4d7aa07e05bd469f9b9e33c2de45a7f9420","unresolved":true,"context_lines":[{"line_number":379,"context_line":"automatically resumed the next time the request is made with the same"},{"line_number":380,"context_line":"parameters."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"It\u0027s only with the -v option that the response headers are output to stdout."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Take care when performing this operation because deleting an account is a"},{"line_number":385,"context_line":"one-way operation that is not trivially recoverable. It\u0027s crucial to note that in"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3d44775f_d778eb7f","line":382,"updated":"2021-08-24 16:30:26.000000000","message":"Doesn\u0027t the -i below get us headers?\n\n $ curl -i http://saio:8090/v1/AUTH_delete_test -X DELETE\n HTTP/1.1 204 No Content\n Content-Type: text/html; charset\u003dUTF-8\n Content-Length: 0\n X-Account-Status: Deleted\n X-Trans-Id: tx7ebc48e541cf4d7ca06bf-00612507ac\n X-Openstack-Request-Id: tx7ebc48e541cf4d7ca06bf-00612507ac\n Date: Tue, 24 Aug 2021 14:52:28 GMT","commit_id":"065c4ee4811d64ba1933e5fbbe3fb9369b99a3d0"},{"author":{"_account_id":33856,"name":"Nicholas Njihia","display_name":"nicknjihian","email":"nicholas.njihia@canonical.com","username":"nicknjihian"},"change_message_id":"c183d3b517dc4449c184e5adf2967980368fef77","unresolved":true,"context_lines":[{"line_number":379,"context_line":"automatically resumed the next time the request is made with the same"},{"line_number":380,"context_line":"parameters."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"It\u0027s only with the -v option that the response headers are output to stdout."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Take care when performing this operation because deleting an account is a"},{"line_number":385,"context_line":"one-way operation that is not trivially recoverable. It\u0027s crucial to note that in"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"8cdbf27d_b83dd042","line":382,"in_reply_to":"3d44775f_d778eb7f","updated":"2021-08-27 12:19:33.000000000","message":"Thank you for your valuable and valued feedback. I can\u0027t overstate how much I value your feedback. That\u0027s true. It does. Thank you for pointing this out.","commit_id":"065c4ee4811d64ba1933e5fbbe3fb9369b99a3d0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"64d4e4d7aa07e05bd469f9b9e33c2de45a7f9420","unresolved":true,"context_lines":[{"line_number":403,"context_line":"   X-Storage-Token: AUTH_tk824cd8ffbbef4103a9b8be457e229be8"},{"line_number":404,"context_line":"   X-Trans-Id: tx54dd505d781745aa8c973-006124ba92"},{"line_number":405,"context_line":"   X-Openstack-Request-Id: tx54dd505d781745aa8c973-006124ba92"},{"line_number":406,"context_line":"   Date: Tue, 24 Aug 2021 09:23:30 GMT"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":""},{"line_number":409,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"0e11f325_9f4a0500","line":406,"updated":"2021-08-24 16:30:26.000000000","message":"This looks like an auth response...","commit_id":"065c4ee4811d64ba1933e5fbbe3fb9369b99a3d0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"64d4e4d7aa07e05bd469f9b9e33c2de45a7f9420","unresolved":true,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"If the account or authentication token is not valid, the operation"},{"line_number":411,"context_line":"returns the ``Unauthorized (401)``. If you try to delete an account without"},{"line_number":412,"context_line":"the admin token, a ``403 Forbidden`` response code is returned."},{"line_number":413,"context_line":"If you try specify the URL, a ``404 Not Found`` response code is returned."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"Error response codes:200,401,403,404."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"0f881762_6f4ff8bd","line":412,"range":{"start_line":411,"start_character":68,"end_line":412,"end_character":15},"updated":"2021-08-24 16:30:26.000000000","message":"Maybe rephrase as \"with a non-admin token\"?","commit_id":"065c4ee4811d64ba1933e5fbbe3fb9369b99a3d0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"64d4e4d7aa07e05bd469f9b9e33c2de45a7f9420","unresolved":true,"context_lines":[{"line_number":410,"context_line":"If the account or authentication token is not valid, the operation"},{"line_number":411,"context_line":"returns the ``Unauthorized (401)``. If you try to delete an account without"},{"line_number":412,"context_line":"the admin token, a ``403 Forbidden`` response code is returned."},{"line_number":413,"context_line":"If you try specify the URL, a ``404 Not Found`` response code is returned."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"Error response codes:200,401,403,404."},{"line_number":416,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"e4a76e46_d01a079a","line":413,"updated":"2021-08-24 16:30:26.000000000","message":"I\u0027m having trouble parsing this. Do you mean,\n\n\u003e If the account does not exist or is already flagged for deletion, a ``404 Not Found`` response code is returned.\n\n?","commit_id":"065c4ee4811d64ba1933e5fbbe3fb9369b99a3d0"},{"author":{"_account_id":33856,"name":"Nicholas Njihia","display_name":"nicknjihian","email":"nicholas.njihia@canonical.com","username":"nicknjihian"},"change_message_id":"c183d3b517dc4449c184e5adf2967980368fef77","unresolved":true,"context_lines":[{"line_number":410,"context_line":"If the account or authentication token is not valid, the operation"},{"line_number":411,"context_line":"returns the ``Unauthorized (401)``. If you try to delete an account without"},{"line_number":412,"context_line":"the admin token, a ``403 Forbidden`` response code is returned."},{"line_number":413,"context_line":"If you try specify the URL, a ``404 Not Found`` response code is returned."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"Error response codes:200,401,403,404."},{"line_number":416,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"14197589_4e949de2","line":413,"in_reply_to":"e4a76e46_d01a079a","updated":"2021-08-27 12:19:33.000000000","message":"This is a typo I unfortunately saw after I\u0027d sent this out for review. Yes, you\u0027re right.","commit_id":"065c4ee4811d64ba1933e5fbbe3fb9369b99a3d0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"64d4e4d7aa07e05bd469f9b9e33c2de45a7f9420","unresolved":true,"context_lines":[{"line_number":412,"context_line":"the admin token, a ``403 Forbidden`` response code is returned."},{"line_number":413,"context_line":"If you try specify the URL, a ``404 Not Found`` response code is returned."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"Error response codes:200,401,403,404."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7b1fcf74_24310a5d","line":415,"range":{"start_line":415,"start_character":21,"end_line":415,"end_character":24},"updated":"2021-08-24 16:30:26.000000000","message":"I thought we sent back a 204 on success...","commit_id":"065c4ee4811d64ba1933e5fbbe3fb9369b99a3d0"},{"author":{"_account_id":33856,"name":"Nicholas Njihia","display_name":"nicknjihian","email":"nicholas.njihia@canonical.com","username":"nicknjihian"},"change_message_id":"c183d3b517dc4449c184e5adf2967980368fef77","unresolved":true,"context_lines":[{"line_number":412,"context_line":"the admin token, a ``403 Forbidden`` response code is returned."},{"line_number":413,"context_line":"If you try specify the URL, a ``404 Not Found`` response code is returned."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"Error response codes:200,401,403,404."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"f05f6679_027d6fe4","line":415,"range":{"start_line":415,"start_character":21,"end_line":415,"end_character":24},"in_reply_to":"7b1fcf74_24310a5d","updated":"2021-08-27 12:19:33.000000000","message":"Yes it does. Once again your feedback is greatly valued and credit is owed to you in this commit.","commit_id":"065c4ee4811d64ba1933e5fbbe3fb9369b99a3d0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"64d4e4d7aa07e05bd469f9b9e33c2de45a7f9420","unresolved":true,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"   - account: account"},{"line_number":424,"context_line":"   - X-Auth-Token: X-Auth-Token"},{"line_number":425,"context_line":"   - Accept: Accept"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Response Parameters"},{"line_number":428,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"cc1f080c_e7bdbbf2","line":425,"updated":"2021-08-24 16:30:26.000000000","message":"I\u0027d drop Accept -- I don\u0027t think it has any impact on the response.","commit_id":"065c4ee4811d64ba1933e5fbbe3fb9369b99a3d0"}]}