)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"25e1fedb6f4d72ccfd6b091bd8609dee666287f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"31a0ec95_12a9bdb0","updated":"2022-04-29 03:18:29.000000000","message":"Yeah, having this should help with tests in v2 serialisation. Although we should also make sure there is a specifing device ID test for the new format too. Just for coverage.","commit_id":"f81e53642c31fad5838af5a5a0f57042b84c4694"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d3c0f2a0d1c2b1a021c1d5cd03c93b6cf1ed6c61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7e3ed5b9_acd3eab2","updated":"2022-01-14 21:12:12.000000000","message":"recheck","commit_id":"f81e53642c31fad5838af5a5a0f57042b84c4694"}],"swift/common/ring/builder.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f4e1ce60aa3517fa6a4ccbbc520ae6729ef4d590","unresolved":true,"context_lines":[{"line_number":415,"context_line":"            raise exceptions.DuplicateDeviceError("},{"line_number":416,"context_line":"                \u0027Duplicate device id: %d\u0027 % dev[\u0027id\u0027])"},{"line_number":417,"context_line":"        if dev[\u0027id\u0027] \u003e (2 ** 16) - 2:"},{"line_number":418,"context_line":"            raise ValueError(\u0027Device id %d is too large\u0027 % dev[\u0027id\u0027])"},{"line_number":419,"context_line":"        # Add holes to self.devs to ensure self.devs[dev[\u0027id\u0027]] will be the dev"},{"line_number":420,"context_line":"        while dev[\u0027id\u0027] \u003e\u003d len(self.devs):"},{"line_number":421,"context_line":"            self.devs.append(None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e435a2dc_02bce3c0","line":418,"updated":"2021-09-11 04:58:46.000000000","message":"OK so this patch is just adding the ability to provide the dev id. The ability to add a dev id \u003e then 2 bytes happens in the follow up. Got it.","commit_id":"407933464c972a347eb6767247dcffb43ef66568"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c062082414eb979e4f607e48474311a90db8da7b","unresolved":true,"context_lines":[{"line_number":415,"context_line":"            raise exceptions.DuplicateDeviceError("},{"line_number":416,"context_line":"                \u0027Duplicate device id: %d\u0027 % dev[\u0027id\u0027])"},{"line_number":417,"context_line":"        if dev[\u0027id\u0027] \u003e (2 ** 16) - 2:"},{"line_number":418,"context_line":"            raise ValueError(\u0027Device id %d is too large\u0027 % dev[\u0027id\u0027])"},{"line_number":419,"context_line":"        # Add holes to self.devs to ensure self.devs[dev[\u0027id\u0027]] will be the dev"},{"line_number":420,"context_line":"        while dev[\u0027id\u0027] \u003e\u003d len(self.devs):"},{"line_number":421,"context_line":"            self.devs.append(None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e06bda68_a439b76d","line":418,"in_reply_to":"e435a2dc_02bce3c0","updated":"2021-09-13 22:34:11.000000000","message":"Yeah, this is all about making it easier to test the variable-width dev ids -- I did *not* want to have to actually have rings with \u003e66k devs just to watch them kick over to 4-byte dev ids.","commit_id":"407933464c972a347eb6767247dcffb43ef66568"}],"test/unit/cli/test_ringbuilder.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"25e1fedb6f4d72ccfd6b091bd8609dee666287f7","unresolved":true,"context_lines":[{"line_number":402,"context_line":"        self.assertEqual(dev[\u0027meta\u0027], \u0027some meta data\u0027)"},{"line_number":403,"context_line":"        self.assertEqual(dev[\u0027id\u0027], 65000)"},{"line_number":404,"context_line":"        self.assertEqual(len(ring.devs), 65001)"},{"line_number":405,"context_line":"        self.assertEqual(ring.devs[4:-1], [None] * 64996)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def test_add_duplicate_devices(self):"},{"line_number":408,"context_line":"        self.create_sample_ring()"}],"source_content_type":"text/x-python","patch_set":10,"id":"a8a89890_b5ceb3df","line":405,"updated":"2022-04-29 03:18:29.000000000","message":"We should have a test for the new_format too. It\u0027s kinda outside the scope of this change, but we don\u0027t seem to test it.","commit_id":"f81e53642c31fad5838af5a5a0f57042b84c4694"}]}