)]}'
{"swift/container/server.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"b31daf73641d14effdd56e6d2173607014a4047b","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            return HTTPNotFound()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def _update_or_create(self, req, broker, timestamp):"},{"line_number":231,"context_line":"        if not os.path.exists(broker.db_file):"},{"line_number":232,"context_line":"            try:"},{"line_number":233,"context_line":"                broker.initialize(timestamp)"},{"line_number":234,"context_line":"            except DatabaseAlreadyExists:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FYvM%3D","line":231,"updated":"2014-03-18 08:03:38.000000000","message":"I think you could simply remove the if-clause, just leaving the try...except...else block?","commit_id":"2e8bc44c9d0586813587a5711f8e857a31393326"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"67a2c3808a4e2897b794b3d9d3c1dbbde76e6f2b","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            return HTTPNotFound()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def _update_or_create(self, req, broker, timestamp):"},{"line_number":231,"context_line":"        if not os.path.exists(broker.db_file):"},{"line_number":232,"context_line":"            try:"},{"line_number":233,"context_line":"                broker.initialize(timestamp)"},{"line_number":234,"context_line":"            except DatabaseAlreadyExists:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FYNE%3D","line":231,"in_reply_to":"AAAAWH%2F%2FYvM%3D","updated":"2014-03-18 09:13:40.000000000","message":"I looked at that and I think that\u0027s true.\n\nBut when you dig through initialize it\u0027s kinda heavyweight, seems wasteful to create a new tempfile database and apply all the schema\u0027s on every PUT just to throw them away when the LBYL check is cheap.  I\u0027m mostly just trying to fix the bug without any dramatic changes to existing behavior - it\u0027d be a whole \u0027nother patch to benchmark dropping the early bypass.","commit_id":"2e8bc44c9d0586813587a5711f8e857a31393326"}]}