)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cef9ffd8a7d276fb7bbf2dd6261bfb5047cce2dc","unresolved":false,"context_lines":[{"line_number":672,"context_line":"            # thats not available here so setup a 4K buffer and increase later"},{"line_number":673,"context_line":"            # when the writes come in."},{"line_number":674,"context_line":"            self._write_buffer \u003d mmap.mmap(-1, 4096, mmap.MAP_PRIVATE)"},{"line_number":675,"context_line":"        except Exception:"},{"line_number":676,"context_line":"            self._old_flags \u003d None"},{"line_number":677,"context_line":"            self._write_buffer \u003d None"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_c7fc9841","line":675,"updated":"2015-01-22 01:40:15.000000000","message":"Please never do except Exception:.","commit_id":"0e098aaeef9ed02288dbdb5b3d70ec28574ff0b0"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cef9ffd8a7d276fb7bbf2dd6261bfb5047cce2dc","unresolved":false,"context_lines":[{"line_number":688,"context_line":"        :returns: the total number of bytes written to an object"},{"line_number":689,"context_line":"        \"\"\""},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        if self._old_flags:"},{"line_number":692,"context_line":"            # increase write_buffer to chunk length if chunk length is"},{"line_number":693,"context_line":"            # 4K aligned"},{"line_number":694,"context_line":"            if len(chunk) % 4096 \u003d\u003d 0 and len(chunk) \u003e len(self._write_buffer):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_c703b8b6","line":691,"updated":"2015-01-22 01:40:15.000000000","message":"this miraclously works because O_LARGEFILE is always set, but you really should be checking for None, IMHO","commit_id":"0e098aaeef9ed02288dbdb5b3d70ec28574ff0b0"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cef9ffd8a7d276fb7bbf2dd6261bfb5047cce2dc","unresolved":false,"context_lines":[{"line_number":700,"context_line":"                # try to write the chunk with aligned write_buffer"},{"line_number":701,"context_line":"                if len(chunk) \u003d\u003d len(self._write_buffer):"},{"line_number":702,"context_line":"                    self._write_buffer.seek(0)"},{"line_number":703,"context_line":"                    self._write_buffer.write(chunk)"},{"line_number":704,"context_line":"                    written \u003d os.write(self._fd, self._write_buffer)"},{"line_number":705,"context_line":"                    self._upload_size +\u003d written"},{"line_number":706,"context_line":"                    chunk \u003d chunk[written:]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_872530c4","line":703,"updated":"2015-01-22 01:40:15.000000000","message":"It looks like you copy the chunk in the aligned buffer so that O_DIRECT would work. Does this actually win us anything?","commit_id":"0e098aaeef9ed02288dbdb5b3d70ec28574ff0b0"}]}