)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"19ef7c6d52d05363aacac729e753b91b87a5d1f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0434574d_c3bccaff","updated":"2021-10-26 16:48:43.000000000","message":"change seems sane; at least the part about timestamps - I don\u0027t understand the test diff","commit_id":"acde736ce2a1dbfdfbd0e0df24b704d0f0107318"}],"test/unit/container/test_backend.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"19ef7c6d52d05363aacac729e753b91b87a5d1f1","unresolved":true,"context_lines":[{"line_number":3752,"context_line":"                         actual.get(\u0027X-Container-Sysmeta-Shard-Root\u0027))"},{"line_number":3753,"context_line":"        self.assertEqual(expected, broker.get_sharding_sysmeta(\u0027Root\u0027))"},{"line_number":3754,"context_line":""},{"line_number":3755,"context_line":"        expected \u003d \"{\u0027key\u0027: \u0027value\u0027}\""},{"line_number":3756,"context_line":"        with mock_timestamp_now() as now:"},{"line_number":3757,"context_line":"            broker.set_sharding_sysmeta(\u0027test\u0027, expected)"},{"line_number":3758,"context_line":"        actual \u003d broker.metadata"}],"source_content_type":"text/x-python","patch_set":1,"id":"3e169b67_9b2e4f52","line":3755,"updated":"2021-10-26 16:48:43.000000000","message":"maybe json.dumps() instead of quoting the dict literal?\n\nI don\u0027t see how this is a reasonable test for the new Timestamp behavior tho....","commit_id":"acde736ce2a1dbfdfbd0e0df24b704d0f0107318"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d43d19f420569bd1d0fb50b90b665c7cd64bd7d8","unresolved":true,"context_lines":[{"line_number":3752,"context_line":"                         actual.get(\u0027X-Container-Sysmeta-Shard-Root\u0027))"},{"line_number":3753,"context_line":"        self.assertEqual(expected, broker.get_sharding_sysmeta(\u0027Root\u0027))"},{"line_number":3754,"context_line":""},{"line_number":3755,"context_line":"        expected \u003d \"{\u0027key\u0027: \u0027value\u0027}\""},{"line_number":3756,"context_line":"        with mock_timestamp_now() as now:"},{"line_number":3757,"context_line":"            broker.set_sharding_sysmeta(\u0027test\u0027, expected)"},{"line_number":3758,"context_line":"        actual \u003d broker.metadata"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8f6afe4_d61957e2","line":3755,"in_reply_to":"3e169b67_9b2e4f52","updated":"2021-10-26 17:31:09.000000000","message":"The issue was that the test was not representative of real usage, and so would fail without *some* change. We\u0027d stuff an *actual dict* into the container\u0027s metadata dict, json.dumps() that, and round-trip it back.","commit_id":"acde736ce2a1dbfdfbd0e0df24b704d0f0107318"}]}
