)]}'
{"id":"openstack%2Fswift~818558","triplet_id":"openstack%2Fswift~master~I7f6458af3ed753ef8700a456d5a977b847f17ee8","project":"openstack/swift","branch":"master","topic":"p-reconstructor-purge-non-durable","attention_set":{},"removed_from_attention_set":{"7847":{"account":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"last_update":"2021-11-19 21:18:21.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7f6458af3ed753ef8700a456d5a977b847f17ee8","subject":"reconstructor: remove non-durable files on handoffs","status":"MERGED","created":"2021-11-19 14:39:31.000000000","updated":"2021-11-19 21:21:15.000000000","submitted":"2021-11-19 21:18:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"818558-p-reconstructor-purge-non-durable","meta_rev_id":"6118637eb4a8bce5ea14b757a01b5c5f7f68b7e6","_number":818558,"virtual_id_number":818558,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-11-19 21:18:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-11-19 19:16:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-11-19 19:16:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-19 15:47:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-19 19:16:54.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"}],"messages":[{"id":"ffc6e0e5ec86948c352fe1dae63e62040c5258b6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-11-19 14:39:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e53b85bb7f8689b608ef96f2b0e3aa70c810e950","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-19 15:47:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/218853dd567341bdac098c3ba74babaa : SUCCESS in 8m 43s\n- grenade https://zuul.opendev.org/t/openstack/build/d84fcba2557e4da88c646d37ec0146ff : SUCCESS in 1h 04m 28s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/712b84eab3344e0bb8c0cf6c9b528427 : SUCCESS in 44m 05s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/2cc16b7a2c134587b5d4f5d1435f313a : SUCCESS in 10m 04s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/da96ece12db6473093548ceb19146fb3 : SUCCESS in 6m 10s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/6b9c400609544366a13bbbcc810679a5 : SUCCESS in 16m 25s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/5e7415ab7ec5453b9fcc7a27e99d5a83 : SUCCESS in 21m 11s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/891a5ad982724726bff16f5d62dd7058 : SUCCESS in 17m 08s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/0fa112447c9f4ca4ba2ed9187576cc53 : SUCCESS in 14m 51s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/159b63fa10674c7c961a6ded469ac054 : SUCCESS in 16m 33s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/5c0faec6deca49f5a36c27348c8e9c1c : SUCCESS in 16m 51s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/bc2e5591cb544b45a3fdf14f7631a688 : SUCCESS in 19m 16s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/426885572b9c4308adb93a5a0fbea25e : SUCCESS in 23m 38s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/ea333e9b6c51423d9696a69f57cb1564 : SUCCESS in 17m 14s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/ee8b60e0ffe24a66aafc3848ea9eacbc : SUCCESS in 14m 55s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/d4100ffe16a9424a97d3192a0dbc67b8 : SUCCESS in 17m 44s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/51b8650f33064382b32be0e68da24077 : SUCCESS in 6m 59s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/09bfb8e4cd2e4d6c9d20b9fdfd0b0dc8 : SUCCESS in 21m 06s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/0508867ae4df495ba668808cb4f1ee5c : SUCCESS in 58m 48s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/f6d2f22a0b484474b4b9c092e1092eaf : SUCCESS in 1h 02m 21s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/889bf0f43d014ed7ada36ede5836f34a : SUCCESS in 40m 14s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/52fd77c43c5b41649c33f18e5052a509 : SUCCESS in 40m 52s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/16eebc1bcd23491abdb0f7fca2572732 : SUCCESS in 18m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6ac942af424a4ef58d7a16e84eb45f20 : SUCCESS in 5m 37s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/c735ae191c60483dbdeb3e8a391615fe : SUCCESS in 20m 43s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/70749bb6c87240e08da7a5f2f774a006 : SUCCESS in 48m 30s","accounts_in_message":[],"_revision_number":1},{"id":"d880efa7356989b0a134301c741ff2bc4c6d1c43","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-19 16:45:26.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/caff44b3ef05413591b8e6c57a48ac62 : SUCCESS in 1h 00m 41s (non-voting)\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/2024be97b6b2468a88cb61b379396911 : SUCCESS in 48m 01s (non-voting)\n- swift-probetests-centos-8-arm64 https://zuul.opendev.org/t/openstack/build/1b71ceeb4f5144e890648e75c9027f5c : FAILURE in 1h 59m 41s (non-voting)\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/c433412e44a74e05b200225f8e77da8c : SUCCESS in 53m 45s (non-voting)\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/36dcb94009044eb1a30fbbdb99f61101 : SUCCESS in 33m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"da6b6c1c5e27d7a415e1e480261138d22342f110","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-11-19 19:16:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f45323db0733b3159401cddba8dcd1ebc64b303f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-19 19:18:26.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"81e2465e0226ad3058e6eba7a4442566a65882c2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-19 21:18:21.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6c07aa1ee4784718a743c4659f6726d9 : SUCCESS in 10m 26s\n- grenade https://zuul.opendev.org/t/openstack/build/672b57cb37824eda8361a6aec86a9325 : SUCCESS in 53m 27s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/529935ae124b4e73ac9b488894d1d7c1 : SUCCESS in 52m 49s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/9ca5709640b240f39f75d25bdf8c4626 : SUCCESS in 10m 26s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/5edb788bbc35472c94e9f106f3936f4b : SUCCESS in 7m 14s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/f020ba4bad9b4bc89e19cb5f27a4e38c : SUCCESS in 18m 06s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/e8f39048310341c6bdfe89609193f6d1 : SUCCESS in 13m 41s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/e53ca43cf70c4f518511c4685ce31fbe : SUCCESS in 22m 37s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/f03e1efb75cf477397a3e0efd59f5b98 : SUCCESS in 24m 38s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/887dc6e9e3d2497aacd2272319018345 : SUCCESS in 24m 30s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/d34f68771ec6456f887022db242a06b3 : SUCCESS in 28m 16s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/bcda1ce5fc3a4c8c96a4a60fa1f2f4d5 : SUCCESS in 31m 19s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/893b646c5a8a4575bdc24f1bc9a4acef : SUCCESS in 30m 06s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/d21e4c752e464b32831b2519af1a848d : SUCCESS in 25m 57s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/4312957b3538423aa899c9336f3dfdc6 : SUCCESS in 26m 22s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/198c0936447942bc84c32b4943cfde66 : SUCCESS in 27m 16s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/d23076ac13844180ad3967c405eaa076 : SUCCESS in 8m 45s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/e5dac5338fe640848cb4cab4d043a1ee : SUCCESS in 53m 21s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/42df5a5b36134dd5aa820f20cd6d3393 : SUCCESS in 57m 27s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/8ac4daac9e4543c7add1715c22487afd : SUCCESS in 39m 49s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/d5671c2bf7d64c4b881417ed439698e8 : SUCCESS in 41m 07s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9d516e82fecf4b39ac29e261b5c40150 : SUCCESS in 26m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4c23470e7f6f48c1b59c5fbcfaca8367 : SUCCESS in 7m 05s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/cf8ccfd5bbfa445f8ba2402d231f9534 : SUCCESS in 30m 07s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c55d6919e06840918921982d8a0d552f : SUCCESS in 46m 28s","accounts_in_message":[],"_revision_number":1},{"id":"3fac9d3abac1475087a79d44eef56b7e48aa1b0f","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-19 21:18:21.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"6118637eb4a8bce5ea14b757a01b5c5f7f68b7e6","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-19 21:21:15.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ac12acac7a9e485a87f7042cfc6627c5 : SUCCESS in 1m 22s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/33a407925b7547d28e7396d541433cd7 : SUCCESS in 58s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/6e9c38cdd9954107a70f29cd3ade7ad4 : SUCCESS in 52s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e3069e6f7e0966ad55b05d3ab7838a4b61fb421c","revisions":{"e3069e6f7e0966ad55b05d3ab7838a4b61fb421c":{"kind":"REWORK","_number":1,"created":"2021-11-19 14:39:31.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/58/818558/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/58/818558/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/58/818558/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/58/818558/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/58/818558/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/58/818558/1"}}},"commit":{"parents":[{"commit":"f91074f376937699dcb0901a9c46030032730773","subject":"Merge \"Make cmp_policy_info agree with the API behaviour\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/f91074f376937699dcb0901a9c46030032730773"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-11-19 14:21:45.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-11-19 14:39:24.000000000","tz":0},"subject":"reconstructor: remove non-durable files on handoffs","message":"reconstructor: remove non-durable files on handoffs\n\nWhen a non-durable EC data fragment has been reverted from a handoff\nnode, it should removed if its mtime is older than the\ncommit_window. The test on the mtime was broken [1]: an incomplete\nfile path was given and the test always returned False i.e. the file\nwas never considered old enough to remove. As a result, non-durable\nfiles would remain on handoff nodes until their reclaim age had\npassed.\n\n[1] Related-Change: I0d519ebaaade35249fb7b17bd5f419ffdaa616c0\nChange-Id: I7f6458af3ed753ef8700a456d5a977b847f17ee8\nCloses-Bug: 1951598\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e3069e6f7e0966ad55b05d3ab7838a4b61fb421c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e3069e6f7e0966ad55b05d3ab7838a4b61fb421c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}