)]}'
{"id":"openstack%2Fswift~819931","triplet_id":"openstack%2Fswift~master~I30625d181aec68208214611fbf1a181121728abe","project":"openstack/swift","branch":"master","attention_set":{},"removed_from_attention_set":{"1179":{"account":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"last_update":"2022-01-10 20:09:59.000000000","reason":"Change was abandoned"},"15343":{"account":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"last_update":"2022-01-10 20:09:59.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I30625d181aec68208214611fbf1a181121728abe","subject":"updater: Skip updates to overloaded nodes","status":"ABANDONED","created":"2021-12-01 01:11:18.000000000","updated":"2022-01-10 20:09:59.000000000","total_comment_count":13,"unresolved_comment_count":7,"has_review_started":true,"meta_rev_id":"7f88e819583f85f36b7e6a14cb640924102329e4","_number":819931,"virtual_id_number":819931,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-12-06 20:46:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-01 03:08:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-12-01 13:55:41.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"CC"},{"updated":"2021-12-02 03:22:26.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"CC"}],"messages":[{"id":"e1efadc08f0828328b9279dec445fcec0994d9cb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-12-01 01:11:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"738a22606cc21b1c5ee22419f4b3b02c643c552e","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-12-01 01:16:29.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"640d936fb33fe796a2f6d3f07372c77e3535f6c6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-12-01 01:34:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a77557cb99ccf7505f645f0bfd5e0595181e1bc9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-01 03:08:00.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/02cdab8055a34006a424ea51d04e75dd : FAILURE in 7m 31s\n- grenade https://zuul.opendev.org/t/openstack/build/53290be6a0c84cf8b6526232a2e64c3b : SUCCESS in 50m 43s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/69d823781d4e4ffa973506e1b7884195 : SUCCESS in 42m 40s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/191a89e9d5214437a8572060e813d600 : SUCCESS in 8m 38s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/b9c90f1fb4f1477cbe2cbb93c3c7cf03 : SUCCESS in 5m 44s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/b328edaa520047da8d8125de66222139 : SUCCESS in 17m 44s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/cc3af4ea471245828b892db3fe3ecc8c : SUCCESS in 19m 20s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/7acaebc7f7d140cab5564125c1ab5d02 : SUCCESS in 17m 39s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/517b9932e084458d8a8d2d89281fc11c : SUCCESS in 17m 14s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/6d337c04db3248f4809d1372d52a17a9 : TIMED_OUT in 1h 31m 27s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/070cf77c3ff14698bb70765a452f9a41 : SUCCESS in 21m 09s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/964bbc4bb6c04d77b44b94b118c0a277 : SUCCESS in 18m 09s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/a8a0822f001b42568aa5346365d4adc9 : SUCCESS in 20m 40s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/b1fd04e1618d4d4788a0c943ab1c897e : SUCCESS in 14m 20s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/710b1e3860a14193ac4d071acf281771 : SUCCESS in 21m 24s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/38e965f9d8b142c0a1f635a735319f04 : SUCCESS in 16m 05s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/21f1de8ec8024fd2b2091c8500225a32 : SUCCESS in 5m 53s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/04af893b2adb47549d62322965cc6275 : SUCCESS in 23m 15s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/cfd14e82fad54fe5bc1ed4637667d47b : FAILURE in 1h 05m 31s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/ea93d933abc846e58233659d9fddbf28 : SUCCESS in 52m 27s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/d3b740db5f604d37aa0961c360d6d7cb : SUCCESS in 47m 59s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/32dcb8297ff54eb29d8fa40a320c170e : SUCCESS in 39m 27s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8902282448614a8083bc07c2865db3f6 : SUCCESS in 16m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/805e009f854c40efb675c7b42e301f93 : SUCCESS in 6m 09s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/59bb2ea6b98f4905a41e1e45ce331ffd : SUCCESS in 21m 58s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6ae60a1b280f477c980df4a846e20f03 : SUCCESS in 1h 11m 54s","accounts_in_message":[],"_revision_number":2},{"id":"5f5bc15c3487eb0803e47a2ec1927629a44ff8dc","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-01 03:25:00.000000000","message":"Patch Set 2:\n\nBuild failed (ARM64 pipeline).\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/5930eff3e8954c6383be6ed946a7dcd6 : SUCCESS in 31m 44s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/c55cd62c8ec64fbdba394336742d1afc : TIMED_OUT in 1h 31m 09s\n- swift-probetests-centos-8-arm64 https://zuul.opendev.org/t/openstack/build/9e54762d6a5f4317a8d9109298cec539 : FAILURE in 1h 44m 43s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/b7c703ba7ccb4426ab590e1d8696a248 : SUCCESS in 34m 55s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/a49cc86d17584efa927a251ef95bfdda : SUCCESS in 1h 12m 25s","accounts_in_message":[],"_revision_number":2},{"id":"6a2ce0bae228ed9ae6d71fd5e8537e01779988df","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-12-01 05:04:27.000000000","message":"Patch Set 2: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"067ccf7b0c067d3b007cd7552d68519247039b7f","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-12-01 13:55:41.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"40d6d17cdadc5f285d79a6111d9116596edbcc70","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-12-02 03:22:26.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6be3e27f5564fd2e9a48af78178b8ef42d78a59e","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-12-02 05:45:48.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6be572da145c31e8a233b932f390534c53701348","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-12-06 19:34:54.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b6738821a3a7c7e5c31147ae6bebc153eed79ebe","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-06 20:46:41.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/588bb7fc8ec844d8aa5539e083eb0b0c : FAILURE in 6m 33s\n- grenade https://zuul.opendev.org/t/openstack/build/b5b34ccf83354310a5058bfce5314609 : SUCCESS in 58m 11s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/8ade93817f94486b96a0f22f4f92e3c0 : SUCCESS in 36m 38s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/cfd02e583f7149b3a34f9d3d3e6e4402 : SUCCESS in 39m 23s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/eb636f0d46bd443abc39de03fc470100 : SUCCESS in 8m 24s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/938923daf2ac4fad867208e7216375c7 : SUCCESS in 6m 47s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/b6d3ca75cd2244e6821a6bc160c87afb : SUCCESS in 15m 41s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/1898e5e39e3f41db97544e5a90fb68b9 : SUCCESS in 15m 18s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/f031a490d29c41c89d6a4071d629b6c1 : SUCCESS in 15m 33s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/eb9c4dc927ee435989eea6c15175a786 : SUCCESS in 15m 45s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/70c2d82007704ce0a60441fc890e44e0 : SUCCESS in 13m 59s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/7e4792f2db9f431bba850af7a46ee8f6 : SUCCESS in 18m 01s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/93188e3a054543dcab1adfbdfc5b7738 : SUCCESS in 17m 49s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/be6a59bdcb864e1e8d4001d733286b8e : SUCCESS in 42m 32s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/cb0578e45fd148d39388e2acaa2917eb : SUCCESS in 12m 48s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/00ac596384804b57bfdd6c07cbbcde94 : SUCCESS in 13m 43s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/442c972a852843a8afbb81f616d94aa1 : SUCCESS in 15m 57s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/1aa0c7e8e2134f2e8a327ec13aa70a08 : SUCCESS in 6m 20s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/165a8a5fb3e445c790428048c7b00486 : SUCCESS in 19m 17s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/522a8a78e9494135abb049365be712fa : SUCCESS in 48m 43s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/507a2dee7c76499da68839586d1e9603 : SUCCESS in 52m 31s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/e095b0ca9fcd4784ac3bc01cc35fe1da : SUCCESS in 33m 17s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/841bc0b3f8eb43ee9abe4b93bbe6205a : SUCCESS in 26m 07s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/639b4c52d60149c58b973746eecde803 : SUCCESS in 14m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a60d7d2b608040c5a6b887620d55c643 : SUCCESS in 5m 05s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/dc921522555944e78f028e2036f7462a : SUCCESS in 19m 29s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7d4d0a26441e4441852890b685e71839 : SUCCESS in 1h 09m 30s","accounts_in_message":[],"_revision_number":3},{"id":"9a6af35d1a97284b00a2fe290d5ce3854b88a221","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-06 21:44:03.000000000","message":"Patch Set 3:\n\nBuild failed (ARM64 pipeline).\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/f9a2932bc832488495ca64f682f5ec48 : SUCCESS in 33m 32s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/d6e08255d0a54b9098b390d9fab5364b : SUCCESS in 36m 27s\n- swift-probetests-centos-8-arm64 https://zuul.opendev.org/t/openstack/build/4ea84d74402a4e0f85c649b385dfd9ca : FAILURE in 2h 05m 49s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/69a5102a95ff436ebda431c23698620f : SUCCESS in 42m 14s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/d21026d0488741d194554484886be5fd : SUCCESS in 40m 17s","accounts_in_message":[],"_revision_number":3},{"id":"1384358427d84b4b47a301412a102009b8ef663e","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-12-06 22:23:15.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"7f88e819583f85f36b7e6a14cb640924102329e4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2022-01-10 20:09:59.000000000","message":"Abandoned\n\nThe wood\u0027s going behind this arrow: https://review.opendev.org/c/openstack/swift/+/820962/7","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"62fe75a16212e356f35715ecc4b97d8ffcd21dd5","revisions":{"733c6bd0524181e2b97cf35061375a228ebb05e3":{"kind":"REWORK","_number":1,"created":"2021-12-01 01:11:18.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/31/819931/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/31/819931/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/31/819931/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/31/819931/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/31/819931/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/31/819931/1"}}},"commit":{"parents":[{"commit":"204be9221d76515186181610710c2779f0e76539","subject":"updater: Add timing stats","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/204be9221d76515186181610710c2779f0e76539"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-12-01 00:28:58.000000000","tz":-480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-12-01 00:47:38.000000000","tz":-480},"subject":"updater: Skip updates to overloaded nodes","message":"updater: Skip updates to overloaded nodes\n\nObject updates have a few different stages:\n\n  1. Connect to container server\n  2. Send update request\n  3. Wait for response\n\nWe\u0027ve got two timeouts we can configure:\n\n  * conn_timeout, which covers stages 1 and 2, and\n  * node_timeout, which covers stage 3\n\nNote that by the time we get to stage 3, the container-server is fairly\ncommitted to trying to process the request; the only question is whether\nthe updater will hang around to read the response. As a result,\noperators usually want to set node_timeout fairly high.\n\nNow that we\u0027re tracking update timings from the client perspective, we\ncan compare against the \"expected\" response timing -- if the actual\ntiming is significantly higher, skip trying to update the overloaded\nnode for a period of time, giving it a chance to recover.\n\nSkip, rather than trying to further ratelimit, so that we can continue\nto process updates destined for non-overloaded container-servers.\n\nChange-Id: I30625d181aec68208214611fbf1a181121728abe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/733c6bd0524181e2b97cf35061375a228ebb05e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/733c6bd0524181e2b97cf35061375a228ebb05e3"}]},"branch":"refs/heads/master"},"e64b94f2ba86222c473bbbed3d5d8a155cb5f781":{"kind":"REWORK","_number":2,"created":"2021-12-01 01:34:30.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/31/819931/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/31/819931/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/31/819931/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/31/819931/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/31/819931/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/31/819931/2"}}},"commit":{"parents":[{"commit":"204be9221d76515186181610710c2779f0e76539","subject":"updater: Add timing stats","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/204be9221d76515186181610710c2779f0e76539"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-12-01 00:28:58.000000000","tz":-480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-12-01 01:34:11.000000000","tz":-480},"subject":"updater: Skip updates to overloaded nodes","message":"updater: Skip updates to overloaded nodes\n\nObject updates have a few different stages:\n\n  1. Connect to container server\n  2. Send update request\n  3. Wait for response\n\nWe\u0027ve got two timeouts we can configure:\n\n  * conn_timeout, which covers stages 1 and 2, and\n  * node_timeout, which covers stage 3\n\nNote that by the time we get to stage 3, the container-server is fairly\ncommitted to trying to process the request; the only question is whether\nthe updater will hang around to read the response. As a result,\noperators usually want to set node_timeout fairly high.\n\nNow that we\u0027re tracking update timings from the client perspective, we\ncan compare against the \"expected\" response timing -- if the actual\ntiming is significantly higher, skip trying to update the overloaded\nnode for a period of time, giving it a chance to recover.\n\nSkip, rather than trying to further ratelimit, so that we can continue\nto process updates destined for non-overloaded container-servers.\n\nChange-Id: I30625d181aec68208214611fbf1a181121728abe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e64b94f2ba86222c473bbbed3d5d8a155cb5f781"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e64b94f2ba86222c473bbbed3d5d8a155cb5f781"}]},"branch":"refs/heads/master"},"62fe75a16212e356f35715ecc4b97d8ffcd21dd5":{"kind":"REWORK","_number":3,"created":"2021-12-06 19:34:54.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/31/819931/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/31/819931/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/31/819931/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/31/819931/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/31/819931/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/31/819931/3"}}},"commit":{"parents":[{"commit":"bc8377f989e113af8c44454117aa3345b68b395f","subject":"updater: Add timing stats","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/bc8377f989e113af8c44454117aa3345b68b395f"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-12-01 00:28:58.000000000","tz":-480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-12-06 19:34:14.000000000","tz":-480},"subject":"updater: Skip updates to overloaded nodes","message":"updater: Skip updates to overloaded nodes\n\nObject updates have a few different stages:\n\n  1. Connect to container server\n  2. Send update request\n  3. Wait for response\n\nWe\u0027ve got two timeouts we can configure:\n\n  * conn_timeout, which covers stages 1 and 2, and\n  * node_timeout, which covers stage 3\n\nNote that by the time we get to stage 3, the container-server is fairly\ncommitted to trying to process the request; the only question is whether\nthe updater will hang around to read the response. As a result,\noperators usually want to set node_timeout fairly high.\n\nNow that we\u0027re tracking update timings from the client perspective, we\ncan compare against the \"expected\" response timing -- if the actual\ntiming is significantly higher, skip trying to update the overloaded\nnode for a period of time, giving it a chance to recover.\n\nSkip, rather than trying to further ratelimit, so that we can continue\nto process updates destined for non-overloaded container-servers.\n\nChange-Id: I30625d181aec68208214611fbf1a181121728abe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/62fe75a16212e356f35715ecc4b97d8ffcd21dd5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/62fe75a16212e356f35715ecc4b97d8ffcd21dd5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}