)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"07c02982bfc8c42b9bd80b5e4181728dd1fff6be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79b69db8_7db6574c","updated":"2021-12-03 11:32:07.000000000","message":"recheck","commit_id":"2a715977f9afe74e17cfe941d8d9f0c051be7793"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a1138d996844aac54a1f546d9817850e3fdd67c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00232cb6_a2957776","updated":"2021-12-01 20:50:45.000000000","message":"recheck\n\npy39 TIMED_OUT, ok to recheck, right?","commit_id":"2a715977f9afe74e17cfe941d8d9f0c051be7793"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8706cd1f1744c99887a5663c15410ff384dbefd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9b345a81_c2374818","updated":"2021-12-03 21:33:03.000000000","message":"It\u0027s nice and defensive: callers have to opt-in, otherwise there\u0027s no change in behavior. Should we go ahead and update things like the reconciler, expirer, sharder, etc.?","commit_id":"b2a6f993383cb8317a9b5f2054224ec3fa4a2a59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"de5497441850410880572de49d13b3d1c0b02429","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"35f38e80_29e8521e","updated":"2021-12-06 15:45:25.000000000","message":"I applied this to the log_name use cases in https://review.opendev.org/c/openstack/swift/+/820539","commit_id":"3b0fae441e0d3b81fe9061114fa3aff2f90a02ca"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"07e0cacdec64e4e850fc6a1ff8cc0723fd22ccb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"01ae38ec_c8e78e3e","updated":"2021-12-10 10:18:39.000000000","message":"recheck","commit_id":"3b0fae441e0d3b81fe9061114fa3aff2f90a02ca"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"de3c5564bb7bc5ecbb462d99810c544f633490f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16750029_7b32f029","updated":"2021-12-08 09:52:03.000000000","message":"recheck","commit_id":"3b0fae441e0d3b81fe9061114fa3aff2f90a02ca"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"ea58f5ca3cb9a23278a906f1cb607a8a62b19387","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a71b869_f67ffa81","updated":"2021-12-09 11:27:47.000000000","message":"recheck","commit_id":"3b0fae441e0d3b81fe9061114fa3aff2f90a02ca"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"69ee7bb1988fb5c541fd3b727c236259316fbe8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"20af66ab_db963581","updated":"2021-12-09 08:50:11.000000000","message":"recheck","commit_id":"3b0fae441e0d3b81fe9061114fa3aff2f90a02ca"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"98ee71132f0f1980581235eeeb9606f1baf0c261","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"66b686dc_ba4f1cf4","updated":"2021-12-08 13:51:40.000000000","message":"recheck","commit_id":"3b0fae441e0d3b81fe9061114fa3aff2f90a02ca"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4d52940d76969a4cc53121111f61bc18fb1ceef3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e3c303b_b61dd0db","updated":"2021-12-13 19:35:18.000000000","message":"recheck","commit_id":"3b0fae441e0d3b81fe9061114fa3aff2f90a02ca"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bc5d9e7d1c243e366ce46b4f4f064f5c2faf6276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8210287_e5524f05","updated":"2021-12-07 10:28:34.000000000","message":"recheck","commit_id":"3b0fae441e0d3b81fe9061114fa3aff2f90a02ca"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"beb5e9835b09529395ef3c67772ba9310e7bd951","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ef1b9211_d17651a8","updated":"2021-12-08 16:11:06.000000000","message":"recheck","commit_id":"3b0fae441e0d3b81fe9061114fa3aff2f90a02ca"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"187f4e30b9f003f9c0a29e79803926f08d4f58fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"27e4c5f4_97e9943f","updated":"2021-12-14 10:30:08.000000000","message":"rebased to get fix https://review.opendev.org/c/openstack/swift/+/821625","commit_id":"021b6dc286f482acb6984c3ec69b75e18780f292"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0230e38227e26f880dd5cc4453200fd75a505318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"471d9770_7076a6d7","updated":"2021-12-14 17:01:14.000000000","message":"recheck","commit_id":"021b6dc286f482acb6984c3ec69b75e18780f292"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e67a5b7db84f7ce04c449f42122772493bf0d497","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4807576d_4a83dfde","updated":"2021-12-16 11:15:49.000000000","message":"recheck","commit_id":"021b6dc286f482acb6984c3ec69b75e18780f292"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0706e7ff49760abfe6c5fe89109ba2928d985cd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a56a0958_1990c281","updated":"2021-12-15 09:55:03.000000000","message":"recheck","commit_id":"021b6dc286f482acb6984c3ec69b75e18780f292"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"dac8cbdd188ba1e346f5dd57b8cf5a87232133cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cff05fdb_e8c08000","updated":"2021-12-17 20:06:30.000000000","message":"recheck","commit_id":"157426f03856c673b4be8a37848cf3f81cce8919"}],"swift/common/internal_client.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8706cd1f1744c99887a5663c15410ff384dbefd8","unresolved":true,"context_lines":[{"line_number":144,"context_line":"    :param conf_path: Full path to proxy config."},{"line_number":145,"context_line":"    :param user_agent: User agent to be sent to requests to Swift."},{"line_number":146,"context_line":"    :param request_tries: Number of tries before InternalClient.make_request()"},{"line_number":147,"context_line":"                          gives up."},{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, conf_path, user_agent, request_tries,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b3ece43_f725c114","line":147,"updated":"2021-12-03 21:33:03.000000000","message":"Docstring could use an update. Though I suppose that was true for at least two previous patches ;-)","commit_id":"b2a6f993383cb8317a9b5f2054224ec3fa4a2a59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c72be6a9c774c93863fdcb184bfaef87ceaa9bf8","unresolved":true,"context_lines":[{"line_number":144,"context_line":"    :param conf_path: Full path to proxy config."},{"line_number":145,"context_line":"    :param user_agent: User agent to be sent to requests to Swift."},{"line_number":146,"context_line":"    :param request_tries: Number of tries before InternalClient.make_request()"},{"line_number":147,"context_line":"                          gives up."},{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, conf_path, user_agent, request_tries,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf42d622_309af315","line":147,"in_reply_to":"9b3ece43_f725c114","updated":"2021-12-06 11:03:48.000000000","message":"done","commit_id":"b2a6f993383cb8317a9b5f2054224ec3fa4a2a59"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9f0cce97382be5ba816a681ea5ae1a8d4757b8fa","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        if request_tries \u003c 1:"},{"line_number":157,"context_line":"            raise ValueError(\u0027request_tries must be positive\u0027)"},{"line_number":158,"context_line":"        self.app \u003d loadapp(conf_path, global_conf\u003dglobal_conf,"},{"line_number":159,"context_line":"                           allow_modify_pipeline\u003dallow_modify_pipeline,)"},{"line_number":160,"context_line":"        self.user_agent \u003d user_agent"},{"line_number":161,"context_line":"        self.request_tries \u003d request_tries"},{"line_number":162,"context_line":"        self.use_replication_network \u003d use_replication_network"}],"source_content_type":"text/x-python","patch_set":6,"id":"95bdd0c4_0b9592bb","line":159,"updated":"2022-01-10 06:31:46.000000000","message":"This still means the passing in user_agent isn\u0027t used. I guess we could override the log_name with user_agent passed in or something before the loadapp?","commit_id":"5079d8429d9799e291d098e14487034c7e910a0d"}],"test/unit/common/test_wsgi.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f6fb32a9d5ad5d298367c2f0c5515228d92e21a6","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        app \u003d wsgi.loadapp(conf_path, global_conf\u003d{\u0027log_name\u0027: \u0027custom\u0027})"},{"line_number":168,"context_line":"        self.assertIsInstance(app, obj_server.ObjectController)"},{"line_number":169,"context_line":"        self.assertEqual(\u0027custom\u0027, app.logger.server)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # ...but global_conf items do not override conf file \u0027set\u0027 options"},{"line_number":172,"context_line":"        conf_body \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"47118161_1c7dd42e","line":169,"updated":"2021-12-03 17:10:54.000000000","message":"lower-constraints failure looks legit:\n\n #4386 test_loadapp_from_file_with_global_conf (test.unit.common.test_wsgi.TestWSGI) ... FAIL\n \n \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n FAIL: test_loadapp_from_file_with_global_conf (test.unit.common.test_wsgi.TestWSGI)\n ----------------------------------------------------------------------\n Traceback (most recent call last):\n   File \"/home/zuul/src/opendev.org/openstack/swift/test/unit/__init__.py\", line 529, in wrapped\n     return f(*args, **kwargs)\n   File \"/home/zuul/src/opendev.org/openstack/swift/test/unit/common/test_wsgi.py\", line 169, in test_loadapp_from_file_with_global_conf\n     self.assertEqual(\u0027custom\u0027, app.logger.server)\nAssertionError: \u0027custom\u0027 !\u003d \u0027swift\u0027\n     \"\u0027custom\u0027 !\u003d \u0027swift\u0027\" \u003d \u0027%s !\u003d %s\u0027 % (safe_repr(\u0027custom\u0027), safe_repr(\u0027swift\u0027))\n     \"\u0027custom\u0027 !\u003d \u0027swift\u0027\" \u003d self._formatMessage(\"\u0027custom\u0027 !\u003d \u0027swift\u0027\", \"\u0027custom\u0027 !\u003d \u0027swift\u0027\")\n \u003e\u003e  raise self.failureException(\"\u0027custom\u0027 !\u003d \u0027swift\u0027\")\n\nNot sure on the *why*, though :-/","commit_id":"2a715977f9afe74e17cfe941d8d9f0c051be7793"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"45da46d86ff8ebde7991f630324786870437861d","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        app \u003d wsgi.loadapp(conf_path, global_conf\u003d{\u0027log_name\u0027: \u0027custom\u0027})"},{"line_number":168,"context_line":"        self.assertIsInstance(app, obj_server.ObjectController)"},{"line_number":169,"context_line":"        self.assertEqual(\u0027custom\u0027, app.logger.server)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # ...but global_conf items do not override conf file \u0027set\u0027 options"},{"line_number":172,"context_line":"        conf_body \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5b77f7f5_cd6ca14a","line":169,"in_reply_to":"47118161_1c7dd42e","updated":"2021-12-03 18:47:58.000000000","message":"PasteDeploy \u003c 2.0.0 behaves differently and gives DEFAUL section options precedence over global_conf. The precedence was flipped in 2.0.0. Our lower constraint was 1.3.3, hence the test failing.","commit_id":"2a715977f9afe74e17cfe941d8d9f0c051be7793"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8706cd1f1744c99887a5663c15410ff384dbefd8","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        app \u003d wsgi.loadapp(conf_path, global_conf\u003d{\u0027log_name\u0027: \u0027custom\u0027})"},{"line_number":168,"context_line":"        self.assertIsInstance(app, obj_server.ObjectController)"},{"line_number":169,"context_line":"        self.assertEqual(\u0027custom\u0027, app.logger.server)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # ...but global_conf items do not override conf file \u0027set\u0027 options"},{"line_number":172,"context_line":"        conf_body \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"aebdb944_45164a8f","line":169,"in_reply_to":"5b77f7f5_cd6ca14a","updated":"2021-12-03 21:33:03.000000000","message":"Is there documentation laying out how these config overlays are expected to work? How much faith do we have that things will continue to work as 2.0+ PasteDeploy does?","commit_id":"2a715977f9afe74e17cfe941d8d9f0c051be7793"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c72be6a9c774c93863fdcb184bfaef87ceaa9bf8","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        app \u003d wsgi.loadapp(conf_path, global_conf\u003d{\u0027log_name\u0027: \u0027custom\u0027})"},{"line_number":168,"context_line":"        self.assertIsInstance(app, obj_server.ObjectController)"},{"line_number":169,"context_line":"        self.assertEqual(\u0027custom\u0027, app.logger.server)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # ...but global_conf items do not override conf file \u0027set\u0027 options"},{"line_number":172,"context_line":"        conf_body \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"12b53c1a_e62be25b","line":169,"in_reply_to":"aebdb944_45164a8f","updated":"2021-12-06 11:03:48.000000000","message":"Unfortunately I didn\u0027t find any documentation.","commit_id":"2a715977f9afe74e17cfe941d8d9f0c051be7793"}]}