)]}'
{"id":"openstack%2Fswift~820082","triplet_id":"openstack%2Fswift~master~I750de57bbff2fa4226780c7ae3b64218b2d208db","project":"openstack/swift","branch":"master","topic":"ec_decode_extra_logging","hashtags":[],"change_id":"I750de57bbff2fa4226780c7ae3b64218b2d208db","subject":"Optionally enable force_metadata_check in pyeclib","status":"NEW","created":"2021-12-02 00:50:16.000000000","updated":"2021-12-02 03:25:25.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e7e0a798f248050ed82791e4476f70c135cdc835","_number":820082,"virtual_id_number":820082,"owner":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-12-02 02:30:51.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-02 02:30:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8cd2fc400ec50ec2fc92ad010e2839894ccd5aa5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-12-02 00:50:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"95b522ae0729fbba74941faa2250216c4c82d4ec","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 02:30:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cf09b07070464c93ba6a0f80a3554616 : SUCCESS in 12m 50s\n- grenade https://zuul.opendev.org/t/openstack/build/f9f93c9505d34fefb0f68d5f9f85b7dd : SUCCESS in 54m 29s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/7a3057966db8434e9d906be9ac966f4b : SUCCESS in 47m 33s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/752e81f315db4946993a285f8591b3d1 : SUCCESS in 10m 03s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/6d3346dabda3405e883a19e2c7915bb1 : SUCCESS in 7m 02s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/d13442e655c64f1ba8f693b58fc3d320 : SUCCESS in 13m 21s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/a0c92845a6ba44508d312021f09c2072 : SUCCESS in 19m 45s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/7c025c2636b148c6ae5d8d292688c92c : SUCCESS in 17m 52s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/90365678701f4e8b9ae25e1153760917 : SUCCESS in 18m 38s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/0d01ad7ffc414081adef0eff946fe286 : SUCCESS in 16m 53s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/31f965c6acaf43f3bfd9e486a44ebb6d : SUCCESS in 17m 37s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/9312dc1b410147a59a35501245d19b59 : SUCCESS in 18m 36s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/f2bfc871b8f645e796d566283b549ff9 : SUCCESS in 23m 13s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/5a6a64f5ddc74eeab7460e75df0ad8cd : SUCCESS in 23m 18s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/84f83013772d4f3dad10bda4b28bd0d0 : SUCCESS in 18m 06s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/8fb650c2fdbc44eb8f79f97d5250bba5 : SUCCESS in 23m 08s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/715abb98c5dc4ec9a3147be12ea0ad82 : SUCCESS in 10m 10s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/044abedcac464c20bb7beb87c8652c8b : SUCCESS in 29m 38s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/1181941c9b3a404ba561bb9938763a72 : SUCCESS in 56m 19s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/d84d19a094834f97aa1c30fb979c4b1f : SUCCESS in 1h 00m 38s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/b20a0bd034da4cc5ba252ba66d8c24d4 : SUCCESS in 43m 54s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/16c8885488f34af1845858ee20075ef7 : SUCCESS in 45m 25s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6622294726f34b9e90ee7a0fd24af57d : SUCCESS in 21m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3739b8ca241b491c8ee7421c9817a886 : SUCCESS in 7m 42s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/b22261f5415d49f5a842aeb6d8a1b2af : SUCCESS in 31m 38s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2d058623ef854a64b14d438e289aad30 : SUCCESS in 46m 35s","accounts_in_message":[],"_revision_number":1},{"id":"e7e0a798f248050ed82791e4476f70c135cdc835","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 03:25:25.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/718a267f8a38461b95c4f66cab9b8170 : SUCCESS in 50m 06s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/696e88cfa851479b8420f3ffcb716c85 : SUCCESS in 46m 18s\n- swift-probetests-centos-8-arm64 https://zuul.opendev.org/t/openstack/build/2cfd3eba6d144b9d9ca1c5557ebbdc55 : SUCCESS in 1h 46m 30s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/77178af52cd64ba5b1e7d991610fc516 : SUCCESS in 35m 58s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/42aab9d0472848738e83fe5c0af71c18 : SUCCESS in 58m 05s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0e8d409f1ab995bcda363a32adc33259c20a2e03","revisions":{"0e8d409f1ab995bcda363a32adc33259c20a2e03":{"kind":"REWORK","_number":1,"created":"2021-12-02 00:50:16.000000000","uploader":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"ref":"refs/changes/82/820082/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/82/820082/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/82/820082/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/82/820082/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/82/820082/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/82/820082/1"}}},"commit":{"parents":[{"commit":"bbd92309fbfcef9b8b2337a2780b0d7c270234f7","subject":"Add some extra logging when EC decode fails","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/bbd92309fbfcef9b8b2337a2780b0d7c270234f7"}]}],"author":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2021-12-02 00:22:22.000000000","tz":660},"committer":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2021-12-02 00:22:22.000000000","tz":660},"subject":"Optionally enable force_metadata_check in pyeclib","message":"Optionally enable force_metadata_check in pyeclib\n\nCurrently when calling pyeclib\u0027s decode method, we always disable\n`force_metadata_checks`. Meaning we just wait for decode to fail if\nsomething is wrong in with the fragment headers.\n\nThis patch adds a `pyeclib_force_metadata_check` option to the proxy\nconfig. When set to true will set `force_metadata_checks\u003dTrue` in the\npyeclib.decode method. This allows liberasurecode to do a metadata check\nbefore decode. Liberasurecode will also start emitting reasons to how it\nfailed to syslog:\n\n  Nov 22 03:54:15 saio1 liberasurecode[30821]: Invalid fragment header \\\n  (get meta chksum)!\n  Nov 22 03:54:15 saio1 liberasurecode[30821]: Invalid fragment header \\\n  information!\n\nThis wont appear in normal swift logs, but gives us a little bit more\ninformation as to why and EC decode failed.\n\nChange-Id: I750de57bbff2fa4226780c7ae3b64218b2d208db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0e8d409f1ab995bcda363a32adc33259c20a2e03"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0e8d409f1ab995bcda363a32adc33259c20a2e03"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}