)]}'
{"id":"openstack%2Fswift~820091","triplet_id":"openstack%2Fswift~stable%2Fxena~I7f6458af3ed753ef8700a456d5a977b847f17ee8","project":"openstack/swift","branch":"stable/xena","topic":"p-reconstructor-purge-non-durable-stable/xena","attention_set":{},"removed_from_attention_set":{"7847":{"account":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"last_update":"2021-12-02 09:12:29.000000000","reason":"Alistair Coles replied on the change"},"15343":{"account":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"last_update":"2021-12-06 23:20:01.000000000","reason":"Tim Burke replied on the change"}},"hashtags":[],"change_id":"I7f6458af3ed753ef8700a456d5a977b847f17ee8","subject":"reconstructor: remove non-durable files on handoffs","status":"MERGED","created":"2021-12-02 06:45:34.000000000","updated":"2021-12-07 02:19:15.000000000","submitted":"2021-12-07 02:15:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"820091-p-reconstructor-purge-non-durable-stable/xena","cherry_pick_of_change":818558,"cherry_pick_of_patch_set":1,"meta_rev_id":"0d4544cca1b64b3ff08d40eebd276abd0085309d","_number":820091,"virtual_id_number":820091,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-12-07 02:15:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"recommended":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":1,"date":"2021-12-02 09:12:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-12-06 23:20:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-12-06 23:20:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-02 06:45:34.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2021-12-02 07:49:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"abbc508d934121afbb5d56a9c211e9795d94a188","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-12-02 06:45:34.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"f43b6ec9c150d893c60778abc5370b2a8e3a9035","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 07:49:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/74d3fdbae0d345828e8734cf3d96752a : SUCCESS in 8m 40s\n- grenade https://zuul.opendev.org/t/openstack/build/a8413956b3e047358319874e15a50d2e : SUCCESS in 1h 02m 40s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/835d10b3c2014432ac65b99785d75bf8 : SUCCESS in 45m 11s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/637f0d649eff4a22874e90eec34e359e : FAILURE in 7m 36s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/f22a08bfe6e04de0ab12425b8ceb65c4 : FAILURE in 4m 01s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/1a4ca593a810407f913785493d06f476 : SUCCESS in 15m 56s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/02d1d57a5df343c5b55abb519b5f663f : SUCCESS in 21m 25s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/1089672933aa440c8a7c44a49b93a51f : SUCCESS in 17m 26s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/723423c402954f9394b8f5bd17e46dd5 : SUCCESS in 17m 18s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/b927e3ec9f3948ab969817a6a49fbc66 : SUCCESS in 28m 19s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/6bd52c4dbf394918b7eb6fe84ca5b151 : SUCCESS in 13m 29s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/722769a4a1ff4c8eaadf5cf7246d8d27 : SUCCESS in 17m 27s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/1df777a658234357a5ce3f46db55f093 : SUCCESS in 24m 40s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/1da8f6c722754dd49e4d942daee4294a : SUCCESS in 20m 27s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/04e2b998d2e1460899892f750b621cd2 : SUCCESS in 26m 35s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/b9b36d3eb61b45f39284beda71555d61 : SUCCESS in 17m 25s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/15fbd42b2da54be7a1111b1e50d558f2 : SUCCESS in 6m 59s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/5f51776dd70f4d3cbb291863e4fc90f8 : SUCCESS in 30m 12s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/785344447aab4e1c8457a18a06274041 : SUCCESS in 46m 11s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/e56a17f022f9440aaf93151c28d73402 : SUCCESS in 55m 30s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/4696756cdd4b4f87a450adf39511d981 : SUCCESS in 47m 32s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/6ab9d42425db48eab96d4215c29faa67 : SUCCESS in 42m 30s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3a6d9677e7a64472890bc031d5982d09 : SUCCESS in 12m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/04df13ef388c4cdd8bf5c55e1d1189ed : SUCCESS in 5m 48s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/3892099acdb849a8b80721355ff7a4b9 : SUCCESS in 19m 16s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/67cbe88cab0d427da6d6a10f91713d2e : SUCCESS in 56m 24s","accounts_in_message":[],"_revision_number":1},{"id":"2a1c03402e82eb542894906632adab2e4d102a68","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 08:08:36.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/b7119c9127f54da493ed2cb6f857013b : SUCCESS in 32m 09s (non-voting)\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/74b7e02ae0a64c4a9fabc5018d43b5d5 : SUCCESS in 32m 25s (non-voting)\n- swift-probetests-centos-8-arm64 https://zuul.opendev.org/t/openstack/build/c251f83dc95546a793a8fd26f62e08b1 : SUCCESS in 1h 15m 25s (non-voting)\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/30c7b4df51784c85959e87dde22bdaf3 : SUCCESS in 31m 01s (non-voting)\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/d26943ff8d5c4f94a8b3d47f5d7fa618 : SUCCESS in 31m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"78fce247b39cee3dd3dbfdd23864331e3816780d","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-12-02 09:12:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9e92c09f240156aba120940c66b89c168b9f744a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-12-06 23:20:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a74b4759e3359d4d4b23c0daae7fb71ff2129ca1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-06 23:21:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e5027f42a99b29ab6b81fb8189daaa16fb0696b5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-07 02:15:41.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/73fbaf2949c3440bafbda72e47048bb4 : SUCCESS in 12m 02s\n- grenade https://zuul.opendev.org/t/openstack/build/7b02efea2c6c40b786fe8a3ede164a97 : SUCCESS in 45m 01s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/72cd1886b3074cd7826694761bc93b79 : SUCCESS in 52m 56s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/88a85637d3e4450995d4f2a0861e6cf6 : SUCCESS in 52m 30s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/b2823a27a08741e0afd403da519ca263 : POST_FAILURE in 9m 30s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/d49dab66c38d4164825c338cb8a84404 : POST_FAILURE in 7m 08s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/c05dfbe559e040139d5f3b13f82f05d4 : SUCCESS in 34m 54s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/4052e261a71244968bda97b82479215d : SUCCESS in 14m 58s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/74044adc4a8d4f4181bcc1686e88a6a3 : SUCCESS in 15m 36s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/a83ae4579e6f405f91293c1b58057f61 : SUCCESS in 36m 46s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/6c958755d0384f3ca9c638a0d22a8686 : SUCCESS in 21m 50s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/32c3cdd18b7d4980acf1c34c2cc5931a : SUCCESS in 14m 38s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/e0afe53023eb477fb96ab01fd34daefc : SUCCESS in 38m 03s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/2b4e9920acc04ef8a8672e915c3be6da : SUCCESS in 15m 46s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/08ae47a927334eda80e0fd604eb427e0 : SUCCESS in 24m 08s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/e9b0b44a296245c1911540dd1e70c090 : SUCCESS in 13m 26s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/97d178c1e28e4cbdae87860f6831a4c3 : SUCCESS in 17m 57s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/030e76508ae842f5b793dfa184a5a259 : SUCCESS in 5m 35s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/5d751359eb714722aa284545c2bc2017 : SUCCESS in 36m 58s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/9278b6740d804cccaa52fcd3617c9b4c : SUCCESS in 44m 56s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/86a334c4ca6441cbb13475cfa6bc78b6 : SUCCESS in 24m 36s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/565f7b86491f462783866d68620797d0 : SUCCESS in 26m 39s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b90a13a23f174d82aae7795694c9d064 : SUCCESS in 13m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2eb8563abc2d4eb588703d5ef40ee8b3 : SUCCESS in 4m 22s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/c56ef87435af459db65970b5eee6ae5a : SUCCESS in 16m 01s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f3c2a985cfca44be8d32a7c37e018384 : SUCCESS in 44m 16s","accounts_in_message":[],"_revision_number":1},{"id":"09864743b3da72d27380962d455fa3f7d398b269","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-07 02:15:41.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"0d4544cca1b64b3ff08d40eebd276abd0085309d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-07 02:19:15.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c0bee2e7d53c48d48343d367d1446aa5 : SUCCESS in 2m 04s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/cfc52cf8d11e47c281ae4b8d415192b5 : FAILURE in 1m 26s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/dc0b9e2645544b8eaf6e2256b762f853 : FAILURE in 1m 24s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8c41bf79b610ae21f4db15d9d118a54d570caf20","revisions":{"8c41bf79b610ae21f4db15d9d118a54d570caf20":{"kind":"REWORK","_number":1,"created":"2021-12-02 06:45:34.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/91/820091/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/91/820091/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/91/820091/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/91/820091/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/91/820091/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/91/820091/1"}}},"commit":{"parents":[{"commit":"7520aada3c042fe209e2e4eb9414c0c3f8dfd027","subject":"Update TOX_CONSTRAINTS_FILE for stable/xena","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/7520aada3c042fe209e2e4eb9414c0c3f8dfd027"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-11-19 14:21:45.000000000","tz":0},"committer":{"name":"Tim Burke","email":"tburke@nvidia.com","date":"2021-12-02 06:45:34.000000000","tz":0},"subject":"reconstructor: remove non-durable files on handoffs","message":"reconstructor: remove non-durable files on handoffs\n\nWhen a non-durable EC data fragment has been reverted from a handoff\nnode, it should removed if its mtime is older than the\ncommit_window. The test on the mtime was broken [1]: an incomplete\nfile path was given and the test always returned False i.e. the file\nwas never considered old enough to remove. As a result, non-durable\nfiles would remain on handoff nodes until their reclaim age had\npassed.\n\n[1] Related-Change: I0d519ebaaade35249fb7b17bd5f419ffdaa616c0\nChange-Id: I7f6458af3ed753ef8700a456d5a977b847f17ee8\nCloses-Bug: 1951598\n(cherry picked from commit e3069e6f7e0966ad55b05d3ab7838a4b61fb421c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8c41bf79b610ae21f4db15d9d118a54d570caf20"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8c41bf79b610ae21f4db15d9d118a54d570caf20"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}