)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0ce0635d221cbcca1dc4403cf7ec1b0ccaa18c69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93f92ecd_b6991377","updated":"2021-12-06 15:44:43.000000000","message":"I\u0027m open to suggestions for a better suffix that \u0027-ic\u0027.\n\nI wanted to avoid \u0027-proxy\u0027 and \u0027-swift\u0027 in case someone uncomments the DEFAULT section log name (\u0027swift\u0027) which IIUC would result in \u0027swift-proxy\u0027 or \u0027swift-swift\u0027.\n\nI also feared that \u0027-internal-client\u0027 was too verbose ??","commit_id":"3c5c577d78e45d3675daf36f858b01b56e4df282"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c98cb73c30315e035252c7ce2f1cc14fb9583641","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a98f708_1f4f3001","updated":"2021-12-07 12:00:23.000000000","message":"just want to check for any possible impact on stasd metric names","commit_id":"3c5c577d78e45d3675daf36f858b01b56e4df282"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9eeea496c33a539a3781a012cf0b2c2bfebd90d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6b03390a_3dba80f6","updated":"2022-01-10 18:24:09.000000000","message":"I\u0027d like to at least add a test to verify the relationship between the new global_conf log_name and a \"set log_name \u003d foo\" entry in the internal-client.conf file, and perhaps update the docs a little to get better clarity as to how log_name configuration is applied.","commit_id":"e3289fafda6bcf351f3f499a039e3977c6a2ac02"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c956e729da007af4881ae262d06c1c3a9840fc2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"885b0a21_b87ad7b5","updated":"2022-01-11 17:10:30.000000000","message":"Added some more tests. I\u0027m happy with this now.","commit_id":"60b08391d2deb6dd25328cf1833b0957069ac1e2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"10a7f9c2e508b759307cac804908a47afeabddc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"896aab91_b5a7c2f6","updated":"2022-01-26 10:06:54.000000000","message":"recheck\n","commit_id":"035d91dce5dfc2fdaf842e9fbeb36684bceab278"}],"etc/internal-client.conf-sample":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0220e8a371140698c1c2d1a3f8cc356fa9e20eda","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# You can specify default log routing here if you want:"},{"line_number":5,"context_line":"# Note: the \u0027set\u0027 syntax is necessary to override the log_name that some"},{"line_number":6,"context_line":"# daemons specify when instantiating an internal client."},{"line_number":7,"context_line":"# set log_name \u003d swift"},{"line_number":8,"context_line":"# log_facility \u003d LOG_LOCAL0"},{"line_number":9,"context_line":"# log_level \u003d INFO"},{"line_number":10,"context_line":"# log_address \u003d /dev/log"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"997d81e8_eb77dbd1","line":7,"updated":"2022-01-25 21:36:27.000000000","message":"Cool; looks like the set syntax works prior to upgrade, too. And we\u0027ve already got it called out in the commit message -- I should remember to mention it in the next set of release notes.","commit_id":"035d91dce5dfc2fdaf842e9fbeb36684bceab278"}],"swift/common/utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0220e8a371140698c1c2d1a3f8cc356fa9e20eda","unresolved":true,"context_lines":[{"line_number":2396,"context_line":"                      to separate logging configurations; defaults to the value"},{"line_number":2397,"context_line":"                      of ``name`` or whatever ``name`` defaults to. This value"},{"line_number":2398,"context_line":"                      is used as the name attribute of the"},{"line_number":2399,"context_line":"                      ``logging.LogAdapter`` that is returned."},{"line_number":2400,"context_line":"    :param fmt: Override log format"},{"line_number":2401,"context_line":"    :return: an instance of ``LogAdapter``"},{"line_number":2402,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"884f8f52_c144ab14","line":2399,"updated":"2022-01-25 21:36:27.000000000","message":"Another significant thing (perhaps worth mentioning here): if provided, this is going to be *developer-specified*, whereas there\u0027s an assumption that `name` may (will?) be *operator-specified*.","commit_id":"035d91dce5dfc2fdaf842e9fbeb36684bceab278"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"70d9a557d40d8fe019738edb16bacdaead337388","unresolved":true,"context_lines":[{"line_number":2396,"context_line":"                      to separate logging configurations; defaults to the value"},{"line_number":2397,"context_line":"                      of ``name`` or whatever ``name`` defaults to. This value"},{"line_number":2398,"context_line":"                      is used as the name attribute of the"},{"line_number":2399,"context_line":"                      ``logging.LogAdapter`` that is returned."},{"line_number":2400,"context_line":"    :param fmt: Override log format"},{"line_number":2401,"context_line":"    :return: an instance of ``LogAdapter``"},{"line_number":2402,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"4cea8a55_c42c4e3d","line":2399,"in_reply_to":"884f8f52_c144ab14","updated":"2022-01-26 10:20:59.000000000","message":"https://review.opendev.org/c/openstack/swift/+/826434","commit_id":"035d91dce5dfc2fdaf842e9fbeb36684bceab278"}],"test/unit/container/test_sync.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d2c9649aaf4a85afb511150f11c7bfe7ec958daf","unresolved":true,"context_lines":[{"line_number":158,"context_line":"        expected_conf \u003d readconf(sample_conf_filename)"},{"line_number":159,"context_line":"        actual_conf.pop(\u0027__file__\u0027)"},{"line_number":160,"context_line":"        expected_conf.pop(\u0027__file__\u0027)"},{"line_number":161,"context_line":"        self.assertEqual(expected_conf, actual_conf)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_init_internal_client_log_name(self):"},{"line_number":164,"context_line":"        def _do_test_init_ic_log_name(conf, exp_internal_client_log_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"85dcaf43_ca564a16","line":161,"updated":"2022-01-12 11:10:45.000000000","message":"this fixes the test failure on the last patchset. The test previously asserted that the default internal client conf in sync.py was identical to the text of internal-client.conf, so failed because I added a comment to internal-client.conf. \n\nI don\u0027t think that assertion was reasonable: we shouldn\u0027t have to maintain identical comments in both places (in fact the comments are irrelevant in sync.py), so I have changed the assertion to be that the parsed configs are identical.","commit_id":"035d91dce5dfc2fdaf842e9fbeb36684bceab278"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"70d9a557d40d8fe019738edb16bacdaead337388","unresolved":true,"context_lines":[{"line_number":158,"context_line":"        expected_conf \u003d readconf(sample_conf_filename)"},{"line_number":159,"context_line":"        actual_conf.pop(\u0027__file__\u0027)"},{"line_number":160,"context_line":"        expected_conf.pop(\u0027__file__\u0027)"},{"line_number":161,"context_line":"        self.assertEqual(expected_conf, actual_conf)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_init_internal_client_log_name(self):"},{"line_number":164,"context_line":"        def _do_test_init_ic_log_name(conf, exp_internal_client_log_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"643ae172_57b43429","line":161,"in_reply_to":"772de134_70a9936e","updated":"2022-01-26 10:20:59.000000000","message":"https://review.opendev.org/c/openstack/swift/+/826434","commit_id":"035d91dce5dfc2fdaf842e9fbeb36684bceab278"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0220e8a371140698c1c2d1a3f8cc356fa9e20eda","unresolved":true,"context_lines":[{"line_number":158,"context_line":"        expected_conf \u003d readconf(sample_conf_filename)"},{"line_number":159,"context_line":"        actual_conf.pop(\u0027__file__\u0027)"},{"line_number":160,"context_line":"        expected_conf.pop(\u0027__file__\u0027)"},{"line_number":161,"context_line":"        self.assertEqual(expected_conf, actual_conf)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_init_internal_client_log_name(self):"},{"line_number":164,"context_line":"        def _do_test_init_ic_log_name(conf, exp_internal_client_log_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"772de134_70a9936e","line":161,"in_reply_to":"85dcaf43_ca564a16","updated":"2022-01-25 21:36:27.000000000","message":"I think I like it -- and I think we could probably get ic_conf_body down to just 2 or 3 lines now, if we wanted...","commit_id":"035d91dce5dfc2fdaf842e9fbeb36684bceab278"}]}