)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"d6d8a46f45fa95093f682a051d8067eee7c1b1a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"820a063c_a2342e8e","updated":"2024-09-03 23:23:15.000000000","message":"Looks good, just curious about the format change.. which is fine but does seem out of scope. Happy to change to a +2 to let it though just curious.","commit_id":"4d888fb13a6bc5094b53915fd48c947e2c6c1736"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"50d881050c8840fe8fec0e9fb6f26310987a66f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3761aad3_46854198","updated":"2024-09-06 15:40:34.000000000","message":"recheck\n\nhttps://bugs.launchpad.net/swift/+bug/2028175","commit_id":"4d888fb13a6bc5094b53915fd48c947e2c6c1736"}],"swift/common/db.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"7f4baafd5fd25a86c146e5eb4780b8d66e75683d","unresolved":true,"context_lines":[{"line_number":490,"context_line":"                                   \u0027quar_path\u0027: quar_path,"},{"line_number":491,"context_line":"                                   \u0027reason\u0027: reason}"},{"line_number":492,"context_line":"        self.logger.error(detail)"},{"line_number":493,"context_line":"        raise sqlite3.DatabaseError(detail)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def possibly_quarantine(self, exc_type, exc_value, exc_traceback):"},{"line_number":496,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"468e6735_9b97a146","line":493,"updated":"2022-01-04 18:38:39.000000000","message":"Technically, the translation was also showing up in the exception, but as a backend service, I\u0027m fairly certain that could only ever end up in logs.","commit_id":"f6554b82671483bcca80561a1e517a363d7e7547"}],"swift/common/db_auditor.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"d6d8a46f45fa95093f682a051d8067eee7c1b1a8","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    def run_once(self, *args, **kwargs):"},{"line_number":117,"context_line":"        \"\"\"Run the database audit once.\"\"\""},{"line_number":118,"context_line":"        self.logger.info("},{"line_number":119,"context_line":"            \u0027Begin {} audit \"once\" mode\u0027.format(self.server_type))"},{"line_number":120,"context_line":"        begin \u003d reported \u003d time.time()"},{"line_number":121,"context_line":"        self._one_audit_pass(reported)"},{"line_number":122,"context_line":"        elapsed \u003d time.time() - begin"}],"source_content_type":"text/x-python","patch_set":2,"id":"003a0bae_7da844d0","side":"PARENT","line":119,"updated":"2024-09-03 23:23:15.000000000","message":"This isn\u0027t removing translation it\u0027s just changing from using .format. Which is fine but doesn\u0027t seem to be relevant to the patch, unless I\u0027m mistaken.","commit_id":"769baae36e2e47b57b6390c7bc5e5b210d4fb2c3"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ba3dca5dbd6994e33644573d8cb9356fe659369d","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    def run_once(self, *args, **kwargs):"},{"line_number":117,"context_line":"        \"\"\"Run the database audit once.\"\"\""},{"line_number":118,"context_line":"        self.logger.info("},{"line_number":119,"context_line":"            \u0027Begin {} audit \"once\" mode\u0027.format(self.server_type))"},{"line_number":120,"context_line":"        begin \u003d reported \u003d time.time()"},{"line_number":121,"context_line":"        self._one_audit_pass(reported)"},{"line_number":122,"context_line":"        elapsed \u003d time.time() - begin"}],"source_content_type":"text/x-python","patch_set":2,"id":"7e3a8e23_d9e84cd5","side":"PARENT","line":119,"in_reply_to":"003a0bae_7da844d0","updated":"2024-09-04 15:23:35.000000000","message":"It\u0027s an old patch -- it used to remove translations here, too. When I rebased to pick up [`26c86c0e`](https://github.com/openstack/swift/commit/26c86c0e4103a6bb9d33b47c6a566d5e8230f9bd) I continued to drop formatting, since there\u0027s a (slight) performance benefit to not needing to do the string interpolation when the log line wouldn\u0027t be emitted.","commit_id":"769baae36e2e47b57b6390c7bc5e5b210d4fb2c3"}]}