)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b8c719d237c889a6e50c094b183b9757c3f59378","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e96ee7d_42097c5b","updated":"2022-01-12 23:23:00.000000000","message":"Although, we\u0027d need to fix the missing FakeInternalClient not having a container_ring which is why the unit tests aren\u0027t happy.","commit_id":"bd5ba8e601c9cf3b1f8cd5d866b42276ae7ae713"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"c772167ab3ba153c36eb561957a596d406ba4b10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9553b4f3_fbe39c90","updated":"2022-01-13 01:46:19.000000000","message":"Gone and fixed the reconiler and expirer tests here:  https://review.opendev.org/c/openstack/swift/+/824497\n\nFeel free to squash it in.","commit_id":"bd5ba8e601c9cf3b1f8cd5d866b42276ae7ae713"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"edd3923a5c548024462c284ec1e7937f634cd83d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"72669cf3_89abff33","updated":"2022-01-12 23:41:57.000000000","message":"Seems being able to optinally pass in an app to internal client like Clay did https://review.opendev.org/c/openstack/swift/+/824239/1/swift/common/internal_client.py might be exactly what we need to fix the reconiler unit tests here.\n\nMaybe we should make the app internal_client change as seperate patch and base it all of it, now that it\u0027s needed in 2 different chains.","commit_id":"bd5ba8e601c9cf3b1f8cd5d866b42276ae7ae713"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ecb1de14d70215c8733cabc8338d0fe5ddf96c49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eb62422b_dbe34fb5","updated":"2022-01-12 23:21:17.000000000","message":"Yeah awesome, good riddence pipeline_property. If you can sqaush this down that I can use it in my user_agent internal client chain. ","commit_id":"bd5ba8e601c9cf3b1f8cd5d866b42276ae7ae713"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bf2ebb47d5eda830a9682b70dd83f1ab9b12cbc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"198f3064_d75f6b8d","updated":"2022-01-12 18:01:03.000000000","message":"Yeah, I can squash this down.","commit_id":"bd5ba8e601c9cf3b1f8cd5d866b42276ae7ae713"}],"swift/common/internal_client.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bf2ebb47d5eda830a9682b70dd83f1ab9b12cbc0","unresolved":true,"context_lines":[{"line_number":139,"context_line":"    def getter(self):"},{"line_number":140,"context_line":"        return getattr(self.app._pipeline_final_app, name)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    return property(getter)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"class InternalClient(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c6298bb1_a5b64d88","line":142,"updated":"2022-01-12 18:01:03.000000000","message":"All this can go now, too, yeah?","commit_id":"bd5ba8e601c9cf3b1f8cd5d866b42276ae7ae713"}]}