)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c903e11c9f3ad3ef68128a3d646be37d787661ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a32bc466_a4e397cb","updated":"2022-01-28 17:15:41.000000000","message":"Even better, thanks to Al\n\n\tdiff --git a/test/unit/obj/test_updater.py b/test/unit/obj/test_updater.py\n\tindex 4e457df8a..cf0c73ead 100644\n\t--- a/test/unit/obj/test_updater.py\n\t+++ b/test/unit/obj/test_updater.py\n\t@@ -618,13 +618,9 @@ class TestObjectUpdater(unittest.TestCase):\n\t \n\t\t # final update has Timeout\n\t\t ou.logger.clear()\n\t-        mock_connect \u003d mock.MagicMock()\n\t-        exc \u003d Timeout(99)\n\t-        exc.cancel()\n\t-        mock_connect.getresponse \u003d mock.MagicMock(side_effect\u003dexc)\n\t-\n\t-        with mock.patch(\u0027swift.obj.updater.http_connect\u0027,\n\t-                        return_value\u003dmock_connect):\n\t+        with Timeout(99) as exc, \\\n\t+                mock.patch(\u0027swift.obj.updater.http_connect\u0027) as mock_connect:\n\t+            mock_connect.return_value.getresponse.side_effect \u003d exc\n\t\t     ou.run_once()\n\t\t self.assertTrue(os.path.exists(op_path))\n\t\t self.assertEqual(ou.logger.get_increment_counts(),\n\n","commit_id":"ba8b854ceaa4cf839592279920e489d7544c4c17"}],"test/unit/obj/test_updater.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"325967351cb29075f3908ce6a683de2c9e22900e","unresolved":true,"context_lines":[{"line_number":643,"context_line":"        ou.logger.clear()"},{"line_number":644,"context_line":"        mock_connect \u003d mock.MagicMock()"},{"line_number":645,"context_line":"        exc \u003d ConnectionTimeout(9)"},{"line_number":646,"context_line":"        exc.cancel()"},{"line_number":647,"context_line":"        mock_connect.getresponse \u003d mock.MagicMock(side_effect\u003dexc)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        with mock.patch(\u0027swift.obj.updater.http_connect\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b00cd30_7cd9dd52","line":646,"updated":"2022-01-28 16:48:53.000000000","message":"These two were the real problem; the other files were mostly about making it more obvious that the Timeouts were being used properly when grepping.","commit_id":"ba8b854ceaa4cf839592279920e489d7544c4c17"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ca306dac77aab535321330c58cfbccbbaa9e5103","unresolved":true,"context_lines":[{"line_number":643,"context_line":"        ou.logger.clear()"},{"line_number":644,"context_line":"        mock_connect \u003d mock.MagicMock()"},{"line_number":645,"context_line":"        exc \u003d ConnectionTimeout(9)"},{"line_number":646,"context_line":"        exc.cancel()"},{"line_number":647,"context_line":"        mock_connect.getresponse \u003d mock.MagicMock(side_effect\u003dexc)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        with mock.patch(\u0027swift.obj.updater.http_connect\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3e7b7cdc_2fc64bf6","line":646,"in_reply_to":"3b00cd30_7cd9dd52","updated":"2022-01-28 17:13:13.000000000","message":"this also works\n\n\tdiff --git a/test/unit/obj/test_updater.py b/test/unit/obj/test_updater.py\n\tindex 4e457df8a..c87b3ec27 100644\n\t--- a/test/unit/obj/test_updater.py\n\t+++ b/test/unit/obj/test_updater.py\n\t@@ -619,13 +619,12 @@ class TestObjectUpdater(unittest.TestCase):\n\t\t # final update has Timeout\n\t\t ou.logger.clear()\n\t\t mock_connect \u003d mock.MagicMock()\n\t-        exc \u003d Timeout(99)\n\t-        exc.cancel()\n\t-        mock_connect.getresponse \u003d mock.MagicMock(side_effect\u003dexc)\n\t \n\t\t with mock.patch(\u0027swift.obj.updater.http_connect\u0027,\n\t\t\t\t return_value\u003dmock_connect):\n\t-            ou.run_once()\n\t+            with Timeout(99) as exc:\n\t+                mock_connect.getresponse \u003d mock.MagicMock(side_effect\u003dexc)\n\t+                ou.run_once()\n\t\t self.assertTrue(os.path.exists(op_path))\n\t\t self.assertEqual(ou.logger.get_increment_counts(),\n\t\t\t\t  {\u0027failures\u0027: 1})","commit_id":"ba8b854ceaa4cf839592279920e489d7544c4c17"}]}
