)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"90eeec75d1b3edaa29f453d5f0ca5f95e078bbd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a4e78049_4c76b6f9","updated":"2022-02-07 23:56:47.000000000","message":"recheck","commit_id":"eda7d5fe3c9527ae20850b38f8b626782dd5efec"}],"swift/common/utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bbf518f653f2547f738af0a717e049a38da0b99a","unresolved":false,"context_lines":[{"line_number":1921,"context_line":"        else:"},{"line_number":1922,"context_line":"            self._target \u003d (host, port)"},{"line_number":1923,"context_line":""},{"line_number":1924,"context_line":"    def set_prefix(self, new_prefix):"},{"line_number":1925,"context_line":"        if new_prefix and self._base_prefix:"},{"line_number":1926,"context_line":"            self._prefix \u003d \u0027.\u0027.join([self._base_prefix, new_prefix, \u0027\u0027])"},{"line_number":1927,"context_line":"        elif new_prefix:"}],"source_content_type":"text/x-python","patch_set":1,"id":"caf93d0b_ebc9b603","side":"PARENT","line":1924,"range":{"start_line":1924,"start_character":25,"end_line":1924,"end_character":35},"updated":"2022-02-04 20:33:07.000000000","message":"Yeah, that name was definitely misleading before.","commit_id":"2a60c91f6fcf9ed165a008c8800e475e5f2fc777"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bbf518f653f2547f738af0a717e049a38da0b99a","unresolved":true,"context_lines":[{"line_number":1926,"context_line":"        Modifies the prefix that is added to metric names. The resulting prefix"},{"line_number":1927,"context_line":"        is the concatenation of the component parts `base_prefix` and"},{"line_number":1928,"context_line":"        `tail_prefix`. Only truthy components are included. Each included"},{"line_number":1929,"context_line":"        component is followed by a period, e.g.::"},{"line_number":1930,"context_line":""},{"line_number":1931,"context_line":"            \u003cbase_prefix\u003e.\u003ctail_prefix\u003e."},{"line_number":1932,"context_line":"            \u003ctail_prefix\u003e."}],"source_content_type":"text/x-python","patch_set":1,"id":"3ada6ce1_4c9a102a","line":1929,"updated":"2022-02-04 20:33:07.000000000","message":"Should we call out how  we expect this to only be called once, during __init__? Maybe even move all this to a _set_prefix() method, have this one shim to that, but issue a DeprecationWarning?","commit_id":"0b7b09ff4ff3a67adf251c6f83481ef3c5058901"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0ce121b53856488d82e6837e7e91e8f226b37eb5","unresolved":false,"context_lines":[{"line_number":1926,"context_line":"        Modifies the prefix that is added to metric names. The resulting prefix"},{"line_number":1927,"context_line":"        is the concatenation of the component parts `base_prefix` and"},{"line_number":1928,"context_line":"        `tail_prefix`. Only truthy components are included. Each included"},{"line_number":1929,"context_line":"        component is followed by a period, e.g.::"},{"line_number":1930,"context_line":""},{"line_number":1931,"context_line":"            \u003cbase_prefix\u003e.\u003ctail_prefix\u003e."},{"line_number":1932,"context_line":"            \u003ctail_prefix\u003e."}],"source_content_type":"text/x-python","patch_set":1,"id":"9623eabf_97166ef6","line":1929,"in_reply_to":"3ada6ce1_4c9a102a","updated":"2022-02-07 14:08:50.000000000","message":"Done","commit_id":"0b7b09ff4ff3a67adf251c6f83481ef3c5058901"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bbf518f653f2547f738af0a717e049a38da0b99a","unresolved":true,"context_lines":[{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"    def set_statsd_prefix(self, prefix):"},{"line_number":2244,"context_line":"        \"\"\""},{"line_number":2245,"context_line":"        This method is deprecated. Callers should use the"},{"line_number":2246,"context_line":"        ``statsd_tail_prefix`` argument of ``get_logger`` when instantiating a"},{"line_number":2247,"context_line":"        logger."},{"line_number":2248,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c055a00f_ad117b5f","line":2245,"range":{"start_line":2245,"start_character":23,"end_line":2245,"end_character":33},"updated":"2022-02-04 20:33:07.000000000","message":"Should we go ahead and actually issue a DeprecationWarning?","commit_id":"0b7b09ff4ff3a67adf251c6f83481ef3c5058901"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"90eeec75d1b3edaa29f453d5f0ca5f95e078bbd1","unresolved":false,"context_lines":[{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"    def set_statsd_prefix(self, prefix):"},{"line_number":2244,"context_line":"        \"\"\""},{"line_number":2245,"context_line":"        This method is deprecated. Callers should use the"},{"line_number":2246,"context_line":"        ``statsd_tail_prefix`` argument of ``get_logger`` when instantiating a"},{"line_number":2247,"context_line":"        logger."},{"line_number":2248,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4a18c7e2_8b757fa2","line":2245,"range":{"start_line":2245,"start_character":23,"end_line":2245,"end_character":33},"in_reply_to":"0bbfeded_b05104a0","updated":"2022-02-07 23:56:47.000000000","message":"I was thinking that we could warn here, then call the _set_prefix method -- but as long as there\u0027s a warning, I feel like we\u0027re in a pretty good spot.","commit_id":"0b7b09ff4ff3a67adf251c6f83481ef3c5058901"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0ce121b53856488d82e6837e7e91e8f226b37eb5","unresolved":false,"context_lines":[{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"    def set_statsd_prefix(self, prefix):"},{"line_number":2244,"context_line":"        \"\"\""},{"line_number":2245,"context_line":"        This method is deprecated. Callers should use the"},{"line_number":2246,"context_line":"        ``statsd_tail_prefix`` argument of ``get_logger`` when instantiating a"},{"line_number":2247,"context_line":"        logger."},{"line_number":2248,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ef0bf064_27c42418","line":2245,"range":{"start_line":2245,"start_character":23,"end_line":2245,"end_character":33},"in_reply_to":"c055a00f_ad117b5f","updated":"2022-02-07 14:08:50.000000000","message":"Done","commit_id":"0b7b09ff4ff3a67adf251c6f83481ef3c5058901"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8cd6ba0014751c141d61b7111d4de4067378ce13","unresolved":false,"context_lines":[{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"    def set_statsd_prefix(self, prefix):"},{"line_number":2244,"context_line":"        \"\"\""},{"line_number":2245,"context_line":"        This method is deprecated. Callers should use the"},{"line_number":2246,"context_line":"        ``statsd_tail_prefix`` argument of ``get_logger`` when instantiating a"},{"line_number":2247,"context_line":"        logger."},{"line_number":2248,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0bbfeded_b05104a0","line":2245,"range":{"start_line":2245,"start_character":23,"end_line":2245,"end_character":33},"in_reply_to":"ef0bf064_27c42418","updated":"2022-02-07 14:41:01.000000000","message":"for now I only added a warning when set_prefix is called to avoid double-warning here. Not sure what the \u0027right thing\u0027 would be when deprecated calls are nested.","commit_id":"0b7b09ff4ff3a67adf251c6f83481ef3c5058901"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bbf518f653f2547f738af0a717e049a38da0b99a","unresolved":true,"context_lines":[{"line_number":2170,"context_line":"        self.assertEqual(\u0027proxy-server\u0027, app.logger.name)"},{"line_number":2171,"context_line":"        # server is defined by log_name option"},{"line_number":2172,"context_line":"        self.assertEqual(\u0027test-name\u0027, app.logger.server)"},{"line_number":2173,"context_line":"        # statsd prefix is defined by log_name option"},{"line_number":2174,"context_line":"        mock_statsd.assert_called_once_with("},{"line_number":2175,"context_line":"            \u0027example.com\u0027, 8125, \u0027\u0027, \u0027test-name\u0027, 1.0, 1.0,"},{"line_number":2176,"context_line":"            logger\u003dapp.logger.logger)"}],"source_content_type":"text/x-python","patch_set":1,"id":"13171b5c_8e23ecfc","side":"PARENT","line":2173,"range":{"start_line":2173,"start_character":38,"end_line":2173,"end_character":46},"updated":"2022-02-04 20:33:07.000000000","message":"Hold up -- isn\u0027t this a behavioral change? Or was it just that we weren\u0027t tracking the subsequent call to set_prefix()?","commit_id":"2a60c91f6fcf9ed165a008c8800e475e5f2fc777"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0ce121b53856488d82e6837e7e91e8f226b37eb5","unresolved":true,"context_lines":[{"line_number":2170,"context_line":"        self.assertEqual(\u0027proxy-server\u0027, app.logger.name)"},{"line_number":2171,"context_line":"        # server is defined by log_name option"},{"line_number":2172,"context_line":"        self.assertEqual(\u0027test-name\u0027, app.logger.server)"},{"line_number":2173,"context_line":"        # statsd prefix is defined by log_name option"},{"line_number":2174,"context_line":"        mock_statsd.assert_called_once_with("},{"line_number":2175,"context_line":"            \u0027example.com\u0027, 8125, \u0027\u0027, \u0027test-name\u0027, 1.0, 1.0,"},{"line_number":2176,"context_line":"            logger\u003dapp.logger.logger)"}],"source_content_type":"text/x-python","patch_set":1,"id":"90a63c74_dacea370","side":"PARENT","line":2173,"range":{"start_line":2173,"start_character":38,"end_line":2173,"end_character":46},"in_reply_to":"13171b5c_8e23ecfc","updated":"2022-02-07 14:08:50.000000000","message":"hehe - I paused on this too, but satisfied myself that the test was asserting only the call to the StatsdClient constructor and ignoring the subsequent call to set_statsd_prefix. As such, the test comment was misleading.","commit_id":"2a60c91f6fcf9ed165a008c8800e475e5f2fc777"}]}