)]}'
{"swift/common/middleware/tempurl.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0ddd0752e924976b7b048a69937480795f657105","unresolved":true,"context_lines":[{"line_number":750,"context_line":"        if not request_method:"},{"line_number":751,"context_line":"            request_method \u003d env[\u0027REQUEST_METHOD\u0027]"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        digest \u003d functools.partial(hashlib.new, hash_algorithm)"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        return ["},{"line_number":756,"context_line":"            (get_hmac("}],"source_content_type":"text/x-python","patch_set":1,"id":"b72fad2e_47435055","side":"PARENT","line":753,"updated":"2022-03-16 18:23:16.000000000","message":"I wonder if it\u0027d work to just switch this to\n\n digest \u003d getattr(hashlib, hash_algorithm)\n\nWe\u0027ve even already got input validation up at L526-527.","commit_id":"cb8b3cdab262af1d223c0536220400b13c1d0a9a"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"6eab69d43ff8b7f5ad7fac3668b8b59a35c6312d","unresolved":true,"context_lines":[{"line_number":750,"context_line":"        if not request_method:"},{"line_number":751,"context_line":"            request_method \u003d env[\u0027REQUEST_METHOD\u0027]"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        digest \u003d functools.partial(hashlib.new, hash_algorithm)"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        return ["},{"line_number":756,"context_line":"            (get_hmac("}],"source_content_type":"text/x-python","patch_set":1,"id":"366a8eaf_39a6dec8","side":"PARENT","line":753,"in_reply_to":"b72fad2e_47435055","updated":"2022-03-17 14:21:42.000000000","message":"That\u0027s possible, the hmac.new accepts both formats for the digestmod. But I see this change is already on the latest patch from your patchset: https://review.opendev.org/c/openstack/swift/+/525771\nI\u0027ll abandon this one due to that.","commit_id":"cb8b3cdab262af1d223c0536220400b13c1d0a9a"}],"swift/common/utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0ddd0752e924976b7b048a69937480795f657105","unresolved":true,"context_lines":[{"line_number":283,"context_line":"    pass"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"def get_hmac(request_method, path, expires, key, digest\u003dsha256,"},{"line_number":287,"context_line":"             ip_range\u003dNone):"},{"line_number":288,"context_line":"    \"\"\""},{"line_number":289,"context_line":"    Returns the hexdigest string of the HMAC (see RFC 2104) for"}],"source_content_type":"text/x-python","patch_set":1,"id":"1432b348_c3621115","line":286,"updated":"2022-03-16 18:23:16.000000000","message":"This default change will likely break callers. The formpost middleware will be able to tolerate it once we land https://review.opendev.org/c/openstack/swift/+/833713 -- but the signing for /info admin requests still needs updating.","commit_id":"83b1e64d053784b595c47186c2561cafb2ea43c2"}]}