)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eaf01a03b7f32888986c16bb3993415e03a34b65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bd8f656c_6e915232","updated":"2022-04-04 05:29:06.000000000","message":"You\u0027ve got more patience than me ;-)","commit_id":"fce7ad5f1811d9dde82de69516258f9fde08e90e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"3f7914d542f770fcb7cdc40503ef6d5e61df78de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a94ac635_596ba59a","updated":"2022-04-05 18:48:14.000000000","message":"recheck","commit_id":"fce7ad5f1811d9dde82de69516258f9fde08e90e"}],"test/unit/common/ring/test_builder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eaf01a03b7f32888986c16bb3993415e03a34b65","unresolved":true,"context_lines":[{"line_number":2543,"context_line":"        # move \"the right\" part-replicas, resulting in near optimal balance"},{"line_number":2544,"context_line":"        changed_part, _, _ \u003d rb.rebalance(seed\u003d5)"},{"line_number":2545,"context_line":"        self.assertEqual(changed_part, 167)"},{"line_number":2546,"context_line":"        self.assertEqual(rb.get_balance(), 14.453125)"},{"line_number":2547,"context_line":"        self.assertEqual(rb.dispersion, 16.6015625)"},{"line_number":2548,"context_line":""},{"line_number":2549,"context_line":"    @unittest.skipIf(sys.version_info \u003c (3,),"}],"source_content_type":"text/x-python","patch_set":1,"id":"a9125db9_d6cc0a80","line":2546,"updated":"2022-04-04 05:29:06.000000000","message":"Feels like a sizeable difference, but it\u0027s definitely still moving in the right direction, so... *shrug*","commit_id":"fce7ad5f1811d9dde82de69516258f9fde08e90e"}],"test/unit/common/ring/test_ring.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eaf01a03b7f32888986c16bb3993415e03a34b65","unresolved":true,"context_lines":[{"line_number":531,"context_line":"    @unittest.skipIf(sys.version_info \u003c (3,),"},{"line_number":532,"context_line":"                     \"Seed-specific tests don\u0027t work well between python \""},{"line_number":533,"context_line":"                     \"versions. This test is now PY3 only\")"},{"line_number":534,"context_line":"    def test_get_more_nodes(self):"},{"line_number":535,"context_line":"        # Yes, these tests are deliberately very fragile. We want to make sure"},{"line_number":536,"context_line":"        # that if someone changes the results the ring produces, they know it."},{"line_number":537,"context_line":"        exp_part \u003d 6"}],"source_content_type":"text/x-python","patch_set":1,"id":"5e018e20_56ac5131","line":534,"updated":"2022-04-04 05:29:06.000000000","message":"Man, I hate this test.","commit_id":"fce7ad5f1811d9dde82de69516258f9fde08e90e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eaf01a03b7f32888986c16bb3993415e03a34b65","unresolved":true,"context_lines":[{"line_number":703,"context_line":"                first_matches +\u003d 1"},{"line_number":704,"context_line":"        self.assertEqual(devs, exp_handoffs)"},{"line_number":705,"context_line":"        # the first 32 handoffs were the same across the rebalance"},{"line_number":706,"context_line":"        self.assertEqual(first_matches, 32)"},{"line_number":707,"context_line":"        # but as you dig deeper some of the differences show up"},{"line_number":708,"context_line":"        self.assertEqual(total_changed, 27)"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"52fdd93d_b46bae0a","line":706,"updated":"2022-04-04 05:29:06.000000000","message":"The bounce up seems surprising","commit_id":"fce7ad5f1811d9dde82de69516258f9fde08e90e"}],"test/unit/common/ring/test_utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eaf01a03b7f32888986c16bb3993415e03a34b65","unresolved":true,"context_lines":[{"line_number":750,"context_line":"        report \u003d dispersion_report(rb, verbose\u003dTrue)"},{"line_number":751,"context_line":"        self.assertEqual(rb.dispersion, 2.8645833333333335)"},{"line_number":752,"context_line":"        self.assertEqual(report[\u0027worst_tier\u0027], \u0027r1z1-127.0.0.1\u0027)"},{"line_number":753,"context_line":"        self.assertEqual(report[\u0027max_dispersion\u0027], 6.593406593406593)"},{"line_number":754,"context_line":"        # do a sencond rebalance"},{"line_number":755,"context_line":"        rb.rebalance(seed\u003d100)"},{"line_number":756,"context_line":"        report \u003d dispersion_report(rb, verbose\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"29dc939e_0aeb2f37","line":753,"updated":"2022-04-04 05:29:06.000000000","message":"Feels weird ot me that we don\u0027t have any assertions on balance here... I mean, that\u0027s what we\u0027re trading off on, right?","commit_id":"fce7ad5f1811d9dde82de69516258f9fde08e90e"}]}
