)]}'
{"swift/common/memcached.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f430caca626b4d10a2441edb15c02c9758e866a6","unresolved":true,"context_lines":[{"line_number":343,"context_line":"            except (Exception, Timeout) as e:"},{"line_number":344,"context_line":"                self._exception_occurred(server, e, sock\u003dsock, fp\u003dfp)"},{"line_number":345,"context_line":"        msg \u003d \"No Memcached connections succeeded (set).\""},{"line_number":346,"context_line":"        self.logger.error(msg)"},{"line_number":347,"context_line":"        if raise_on_error:"},{"line_number":348,"context_line":"            raise MemcacheConnectionError(msg)"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"68d6f0c7_1cf98281","line":346,"updated":"2022-04-28 20:17:20.000000000","message":"This seems off... I think I\u0027ve got two main concerns:\n\n- If raise_on_error is True, it seems perfectly reasonable that the caller may want to log about it, too, resulting in doubled-up messages.\n- Even when we\u0027re not raising an error, we\u0027ve already got logs from the _exception_occurred() calls.\n\n*Maybe* I could see some utility in emitting a counter... but the last time I started down that path, I fairly quickly realized that I *actually* wanted the stats to have more application context than I could get down here. Maybe actual errors (as opposed to cache hits/misses) would prove more useful?\n\nThe logging which command tripped the exception *does* seem useful... maybe I\u0027ll propose that as a follow-up.","commit_id":"175eac19f6b444321409121cbd86098d2a89d07a"}]}