)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"66e7fb0b6c47cc851239260255929961fdca8f74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c7d118a_4437dcd2","updated":"2022-05-12 15:34:19.000000000","message":"Looks sane.","commit_id":"cd3b0d36b3a4862481d8a9306c1ee55c64cb3bb4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e9878a1768610f2cb5de70d2671a541d310a0cd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"00e0bc9d_152b1977","updated":"2022-05-18 22:31:12.000000000","message":"recheck\n\nTempest failure looks unrelated to us.","commit_id":"019c955e1cff406a6a7c944d5e66a7bab61ab472"}],"swift/container/sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"66e7fb0b6c47cc851239260255929961fdca8f74","unresolved":true,"context_lines":[{"line_number":1233,"context_line":"                self.cleave_row_batch_size,"},{"line_number":1234,"context_line":"                marker\u003dmarker,"},{"line_number":1235,"context_line":"                end_marker\u003dsrc_shard_range.end_marker,"},{"line_number":1236,"context_line":"                include_deleted\u003d\"give me everything\","},{"line_number":1237,"context_line":"                since_row\u003dsince_row)"},{"line_number":1238,"context_line":"            if objects:"},{"line_number":1239,"context_line":"                self.logger.debug(\u0027got %s objects from %s in %ss\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5916746_129e3c89","line":1236,"updated":"2022-05-12 15:34:19.000000000","message":"I think the idea behind the API was to pass True, False, or None ;-)","commit_id":"cd3b0d36b3a4862481d8a9306c1ee55c64cb3bb4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e9878a1768610f2cb5de70d2671a541d310a0cd6","unresolved":true,"context_lines":[{"line_number":1233,"context_line":"                self.cleave_row_batch_size,"},{"line_number":1234,"context_line":"                marker\u003dmarker,"},{"line_number":1235,"context_line":"                end_marker\u003dsrc_shard_range.end_marker,"},{"line_number":1236,"context_line":"                include_deleted\u003d\"give me everything\","},{"line_number":1237,"context_line":"                since_row\u003dsince_row)"},{"line_number":1238,"context_line":"            if objects:"},{"line_number":1239,"context_line":"                self.logger.debug(\u0027got %s objects from %s in %ss\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"811704cb_bddfd076","line":1236,"in_reply_to":"dd28ebbd_03e84dd3","updated":"2022-05-18 22:31:12.000000000","message":"+1","commit_id":"cd3b0d36b3a4862481d8a9306c1ee55c64cb3bb4"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a51277981fd89ae4df8bd848bde1cdebd95f1c14","unresolved":true,"context_lines":[{"line_number":1233,"context_line":"                self.cleave_row_batch_size,"},{"line_number":1234,"context_line":"                marker\u003dmarker,"},{"line_number":1235,"context_line":"                end_marker\u003dsrc_shard_range.end_marker,"},{"line_number":1236,"context_line":"                include_deleted\u003d\"give me everything\","},{"line_number":1237,"context_line":"                since_row\u003dsince_row)"},{"line_number":1238,"context_line":"            if objects:"},{"line_number":1239,"context_line":"                self.logger.debug(\u0027got %s objects from %s in %ss\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dd28ebbd_03e84dd3","line":1236,"in_reply_to":"f5916746_129e3c89","updated":"2022-05-13 07:41:51.000000000","message":"😄\n\nI\u0027ll change in case the intention is ever enforced ;)\n\nI\u0027d like to explicitly pass the arg despite it being unnecessary, if only to provide a place to hang the comment","commit_id":"cd3b0d36b3a4862481d8a9306c1ee55c64cb3bb4"}],"test/unit/container/test_sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e9878a1768610f2cb5de70d2671a541d310a0cd6","unresolved":true,"context_lines":[{"line_number":3417,"context_line":"            sharder._move_misplaced_objects(broker)"},{"line_number":3418,"context_line":"        sharder._replicate_object.assert_has_calls("},{"line_number":3419,"context_line":"            [mock.call(0, db, 0)"},{"line_number":3420,"context_line":"             for db in (expected_shard_dbs[0], expected_shard_dbs[-1])],"},{"line_number":3421,"context_line":"            any_order\u003dTrue"},{"line_number":3422,"context_line":"        )"},{"line_number":3423,"context_line":"        expected_stats \u003d {\u0027attempted\u0027: 1, \u0027success\u0027: 1, \u0027failure\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0571a5a8_fe3f0c46","line":3420,"updated":"2022-05-18 22:31:12.000000000","message":"Test failure isn\u0027t exactly intuitive:\n\n FAIL: test_misplaced_objects_root_container (test.unit.container.test_sharder.TestSharder)\n ----------------------------------------------------------------------\n Traceback (most recent call last):\n   File \"/vagrant/swift/test/unit/container/test_sharder.py\", line 3418, in test_misplaced_objects_root_container\n     sharder._replicate_object.assert_has_calls(\n   File \"/usr/local/lib/python3.10/dist-packages/mock/mock.py\", line 967, in assert_has_calls\n     raise AssertionError(\n AssertionError: \u0027mock\u0027 does not contain all of (call(0, \u0027/mnt/tmp/tmp2ic86qwg/sda/containers/0/fbf/0ec254c5d4ca63494db92986b7086fbf/0ec254c5d4ca63494db92986b7086fbf.db\u0027, 0),) in its call list, found [] instead\n\nSomething like https://paste.opendev.org/show/bzmbebJZwPmk0EJGz3Ov/ might be better?","commit_id":"019c955e1cff406a6a7c944d5e66a7bab61ab472"}]}