)]}'
{"swift/common/ring/io.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"efa69e7a50f02a8aeb3d3f3e41b8f62c0b0b50a8","unresolved":true,"context_lines":[{"line_number":323,"context_line":"        if checksum_method in (\u0027md5\u0027, \u0027sha1\u0027, \u0027sha256\u0027, \u0027sha512\u0027):"},{"line_number":324,"context_line":"            checksum \u003d getattr(hashlib, checksum_method)(prefix)"},{"line_number":325,"context_line":"        elif checksum_method:"},{"line_number":326,"context_line":"            raise ValueError(\"Checksum digest %s is not supported\""},{"line_number":327,"context_line":"                             % checksum_method)"},{"line_number":328,"context_line":"        else:"},{"line_number":329,"context_line":"            checksum \u003d checksum_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f2fcecd_3674f6dd","line":326,"updated":"2022-05-25 21:25:32.000000000","message":"I\u0027m not convinced this should be an error. If we later come along and add support for blake2 (say), do we really want to require that all nodes be upgraded before thinking about changing the checksum we use? How long would we need to wait before considering changing the default?\n\nAlso consider: we don\u0027t have this validation at all today. Ignoring unknown/unhandled checksums leaves us no worse than v1 rings.","commit_id":"5517287fdb4ef51ca4ca9ea18c8a444604cc967e"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"d61b73f5eaccdaf27314a5b021ebb4546728c8bf","unresolved":true,"context_lines":[{"line_number":323,"context_line":"        if checksum_method in (\u0027md5\u0027, \u0027sha1\u0027, \u0027sha256\u0027, \u0027sha512\u0027):"},{"line_number":324,"context_line":"            checksum \u003d getattr(hashlib, checksum_method)(prefix)"},{"line_number":325,"context_line":"        elif checksum_method:"},{"line_number":326,"context_line":"            raise ValueError(\"Checksum digest %s is not supported\""},{"line_number":327,"context_line":"                             % checksum_method)"},{"line_number":328,"context_line":"        else:"},{"line_number":329,"context_line":"            checksum \u003d checksum_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"d153feb2_0d8f5144","line":326,"in_reply_to":"1f2fcecd_3674f6dd","updated":"2022-05-27 03:22:20.000000000","message":"Yeah I see your point. But do we want the ring reader to grow a logger so we can want people? I guess we could and use it if one is provided.","commit_id":"5517287fdb4ef51ca4ca9ea18c8a444604cc967e"}]}