)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5acb8f921a8d2c22b5cedc19e162424fdac4a412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54844a20_29554ce5","updated":"2022-06-15 00:28:26.000000000","message":"This wasn\u0027t too bad to write up, based on Al\u0027s ideas from last week\u0027s meeting. I think I\u0027d want a better sense of when we could actually remove sha1 from the default before moving forward with this, though.","commit_id":"d5cf79d9b002b88de731645cff8c88231b0bac57"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"fc86b15a9d5a6985d8318b74a05066d3b58f17d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7e51cb2_6c93ca2e","updated":"2022-06-15 00:37:11.000000000","message":"the test churn looks kinda sus and doesn\u0027t seem to validate the new logging behavior - which is a little non-obvious with all the \u0027warned_about_digests.add\" and stuff (which will still be per-worker)","commit_id":"d5cf79d9b002b88de731645cff8c88231b0bac57"}],"swift/common/middleware/tempurl.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"fc86b15a9d5a6985d8318b74a05066d3b58f17d3","unresolved":true,"context_lines":[{"line_number":341,"context_line":"#: \u0027*\u0027 to indicate a prefix match."},{"line_number":342,"context_line":"DEFAULT_OUTGOING_ALLOW_HEADERS \u003d \u0027x-object-meta-public-*\u0027"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"DEFAULT_ALLOWED_DIGESTS \u003d \u0027sha1 sha256 sha512\u0027"},{"line_number":345,"context_line":"DEPRECATED_DIGESTS \u003d {\u0027sha1\u0027}"},{"line_number":346,"context_line":"SUPPORTED_DIGESTS \u003d set(DEFAULT_ALLOWED_DIGESTS.split()) | DEPRECATED_DIGESTS"},{"line_number":347,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ec6ffbb1_3ce57cb4","line":344,"updated":"2022-06-15 00:37:11.000000000","message":"this is nice, but for us the cat is already out of the bag","commit_id":"d5cf79d9b002b88de731645cff8c88231b0bac57"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"fc86b15a9d5a6985d8318b74a05066d3b58f17d3","unresolved":true,"context_lines":[{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    deprecated \u003d allowed_digests \u0026 DEPRECATED_DIGESTS"},{"line_number":884,"context_line":"    if not conf.get(\u0027allowed_digests\u0027):"},{"line_number":885,"context_line":"        conf[\u0027default_allowed_digests\u0027] \u003d True"},{"line_number":886,"context_line":"    elif deprecated:"},{"line_number":887,"context_line":"        logger.warning(\u0027The following digest algorithms are configured but \u0027"},{"line_number":888,"context_line":"                       \u0027deprecated: %s. Support will be removed in a future \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"2afac967_e3d5b078","line":885,"updated":"2022-06-15 00:37:11.000000000","message":"Another idea, we could warn anytime you haven\u0027t configured allowed_digests explicitly - that way we teach ops to ask for the digests their clients are using","commit_id":"d5cf79d9b002b88de731645cff8c88231b0bac57"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"94f09eadd7d0b14597f842aa189f7dda8f7815d7","unresolved":true,"context_lines":[{"line_number":870,"context_line":"                         \u0027for tempurls\u0027)"},{"line_number":871,"context_line":"    info_conf[\u0027allowed_digests\u0027] \u003d sorted(allowed_digests)"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"    register_swift_info(\u0027tempurl\u0027, **info_conf)"},{"line_number":874,"context_line":"    conf.update(info_conf)"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"    register_sensitive_param(\u0027temp_url_sig\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3dd56b32_c1562df6","line":873,"updated":"2022-07-20 04:50:45.000000000","message":"Christian suggested in the formpost patch (the follow up to this) maybe adding a deprecated_digests to the info too, as the logs tell the ops, but this could tell users that a digest is currently allowed but will soon be going away.\n\nSee: https://review.opendev.org/c/openstack/swift/+/833713/13/swift/common/middleware/formpost.py#489 \nKinda like the idea!\n\nCan be a follow up though","commit_id":"25b6bd9f2cf1d0f9956c99cd418ba295196d2e6a"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"3082697ec77cec491ba08e06ba7ef5e8ede82258","unresolved":true,"context_lines":[{"line_number":870,"context_line":"                         \u0027for tempurls\u0027)"},{"line_number":871,"context_line":"    info_conf[\u0027allowed_digests\u0027] \u003d sorted(allowed_digests)"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"    register_swift_info(\u0027tempurl\u0027, **info_conf)"},{"line_number":874,"context_line":"    conf.update(info_conf)"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"    register_sensitive_param(\u0027temp_url_sig\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"14bc7384_3d32a4ee","line":873,"in_reply_to":"3dd56b32_c1562df6","updated":"2022-07-20 05:40:34.000000000","message":"Made it happen in the follow up, seeing as it\u0027s unifiying the tempurl and formpost digest stuff anyway.","commit_id":"25b6bd9f2cf1d0f9956c99cd418ba295196d2e6a"}]}