)]}'
{"swift/common/constraints.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"8c25ff6986a40fd00be44627e0142f604a7a431e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \u0027max_object_name_length\u0027: MAX_OBJECT_NAME_LENGTH,"},{"line_number":45,"context_line":"    \u0027container_listing_limit\u0027: CONTAINER_LISTING_LIMIT,"},{"line_number":46,"context_line":"    \u0027account_listing_limit\u0027: ACCOUNT_LISTING_LIMIT,"},{"line_number":47,"context_line":"    \u0027max_account_name_length\u0027: MAX_ACCOUNT_NAME_LENGTH,"},{"line_number":48,"context_line":"    \u0027max_container_name_length\u0027: MAX_CONTAINER_NAME_LENGTH,"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9jTI%3D","line":47,"updated":"2014-04-03 19:00:24.000000000","message":"What about max_large_object_get_time and max_upload_time? Maybe we should add them here as well to avoid default values in other modules? That said I think there are some more default limits that are not 0 (for example files_per_second and bytes_per_second in swift/obj/auditor.py).","commit_id":"07fcf50c3ac8d95d59901992affea82c45719340"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"01cd994643859a81d17914162293a3dd25e71ee4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \u0027max_object_name_length\u0027: MAX_OBJECT_NAME_LENGTH,"},{"line_number":45,"context_line":"    \u0027container_listing_limit\u0027: CONTAINER_LISTING_LIMIT,"},{"line_number":46,"context_line":"    \u0027account_listing_limit\u0027: ACCOUNT_LISTING_LIMIT,"},{"line_number":47,"context_line":"    \u0027max_account_name_length\u0027: MAX_ACCOUNT_NAME_LENGTH,"},{"line_number":48,"context_line":"    \u0027max_container_name_length\u0027: MAX_CONTAINER_NAME_LENGTH,"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9i4w%3D","line":47,"in_reply_to":"AAAAWH%2F9jTI%3D","updated":"2014-04-03 19:42:13.000000000","message":"I think adding the other constraints would be fine, though not sure about the constraints used by the object auditor, not sure that should be exposed to an external client.\n\nI\u0027d like to see that as a separate patch so that this patch can stay focused on the movement of existing constraints.","commit_id":"07fcf50c3ac8d95d59901992affea82c45719340"}],"test/unit/common/middleware/test_bulk.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2b8cdb22ceab91fafe28f5022ee2068b4065a169","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from swift.common.middleware import bulk"},{"line_number":30,"context_line":"from swift.common.swob import Request, Response, HTTPException"},{"line_number":31,"context_line":"from swift.common.http import HTTP_NOT_FOUND, HTTP_UNAUTHORIZED"},{"line_number":32,"context_line":"from swift.common.utils import json"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class FakeApp(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9j5U%3D","side":"PARENT","line":32,"updated":"2014-04-03 17:32:41.000000000","message":"What does mucking with json have with the stated objective of the patch? I do not like the result. It was plain json, which utils substituted. Now it\u0027s explicit utils.json? Why?","commit_id":"95dcc99a5f76348949fcec7986b44e56efdd7a8d"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"3dc3e637b213b43b760f231a42f90a2f2ce377ff","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from swift.common.middleware import bulk"},{"line_number":30,"context_line":"from swift.common.swob import Request, Response, HTTPException"},{"line_number":31,"context_line":"from swift.common.http import HTTP_NOT_FOUND, HTTP_UNAUTHORIZED"},{"line_number":32,"context_line":"from swift.common.utils import json"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class FakeApp(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9jko%3D","side":"PARENT","line":32,"in_reply_to":"AAAAWH%2F9j5U%3D","updated":"2014-04-03 18:27:59.000000000","message":"You are right, this change does not apply to this patch I\u0027ll move it to another one so we can debate the merits there.","commit_id":"95dcc99a5f76348949fcec7986b44e56efdd7a8d"}],"test/unit/common/middleware/test_recon.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2b8cdb22ceab91fafe28f5022ee2068b4065a169","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from swift import __version__ as swiftver"},{"line_number":25,"context_line":"from swift.common.swob import Request"},{"line_number":26,"context_line":"from swift.common.middleware import recon"},{"line_number":27,"context_line":"from swift.common.utils import json"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def fake_check_mount(a, b):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9j4k%3D","side":"PARENT","line":27,"updated":"2014-04-03 17:32:41.000000000","message":"json here as well","commit_id":"95dcc99a5f76348949fcec7986b44e56efdd7a8d"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"3dc3e637b213b43b760f231a42f90a2f2ce377ff","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from swift import __version__ as swiftver"},{"line_number":25,"context_line":"from swift.common.swob import Request"},{"line_number":26,"context_line":"from swift.common.middleware import recon"},{"line_number":27,"context_line":"from swift.common.utils import json"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def fake_check_mount(a, b):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9ji8%3D","side":"PARENT","line":27,"in_reply_to":"AAAAWH%2F9j4k%3D","updated":"2014-04-03 18:27:59.000000000","message":"Here the change was made because I added the import of utils to get ismount so that it can be overridden, and dropped the existing single import of json.  Which I believe is a good change, both for clarity and elimination of redundancy.","commit_id":"95dcc99a5f76348949fcec7986b44e56efdd7a8d"}]}