)]}'
{"id":"openstack%2Fswift~848909","triplet_id":"openstack%2Fswift~master~If0d57e7a2b253a1ee81c2953504141063060d102","project":"openstack/swift","branch":"master","topic":"p-sharder-deleted","attention_set":{},"removed_from_attention_set":{"7847":{"account":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"last_update":"2023-01-10 18:08:53.000000000","reason":"Change was abandoned"},"1179":{"account":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"last_update":"2022-07-08 17:25:54.000000000","reason":"\u003cGERRIT_ACCOUNT_1179\u003e replied on the change","reason_account":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}}},"hashtags":[],"change_id":"If0d57e7a2b253a1ee81c2953504141063060d102","subject":"Make in-memory databases worse","status":"ABANDONED","created":"2022-07-06 22:50:34.000000000","updated":"2023-01-10 18:08:53.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"76a2afd4802bd144f83532d71e8a224aa2e28f85","_number":848909,"virtual_id_number":848909,"owner":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:check","value":1,"date":"2022-07-08 17:08:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":-2,"date":"2022-07-08 17:25:54.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":-1,"date":"2022-07-08 17:25:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-06 23:55:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-07-06 23:57:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-07 07:31:58.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"CC"}],"messages":[{"id":"b9f4467211fbfce83e4c7ae0e8389876d8ed1ba1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2022-07-06 22:50:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f5623c1a22c1420597e8e0ac223e84884d4c756a","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-06 23:55:31.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bb9eb81eef9245c28548fb46ab3f1a12\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/a9c7ec113d124c1db65d7473a5c580ad : SUCCESS in 51m 35s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/6365a51e12894bf182819d891d22c0be : SUCCESS in 49m 36s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/fc3b4967f11e44c781c9b7a6c37fb0fa : SUCCESS in 1h 03m 12s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/ea9cb0f4491145098324dbfba4b1003b : SUCCESS in 42m 16s","accounts_in_message":[],"_revision_number":1},{"id":"04753c89569e92ea1681482e1fafac02147f6c86","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-06 23:57:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2eb68ce521384031a55fe7aad7ebd97f\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa5e82fa2d8240929bbbe0e9ebce1228 : SUCCESS in 8m 23s\n- grenade https://zuul.opendev.org/t/openstack/build/c4e7a6df71494e65b9cbaa11e31688b1 : SUCCESS in 50m 37s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/40bb4a57ae4e44d3805000be38f74e2f : SUCCESS in 35m 08s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ce3500cc7fcb4689896d412f83b6a0ba : SUCCESS in 44m 19s\n- swift-tox-func-py36-centos-8-stream-fips https://zuul.opendev.org/t/openstack/build/91bc43b2c9024afb933cf4c8da84aad0 : RETRY_LIMIT in 4m 35s (non-voting)\n- swift-tox-func-encryption-py36-centos-8-stream-fips https://zuul.opendev.org/t/openstack/build/788862b0dedf4e98977b317e8c8af519 : RETRY_LIMIT in 4m 47s (non-voting)\n- swift-tox-func-ec-py36-centos-8-stream-fips https://zuul.opendev.org/t/openstack/build/ae2f27c339bf453ea2762831a456565a : RETRY_LIMIT in 4m 18s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/4c014ad8ed65460d8fa18fc39e4d9da9 : SUCCESS in 6m 54s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/3b6044cfca1246748fa23d86c29788c7 : SUCCESS in 5m 11s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/2f20fe13ba6e4864887e129ce1b9c865 : SUCCESS in 19m 58s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/46fe808c54fa4372b14c01832797c115 : SUCCESS in 20m 53s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/20363568dbfe44ec811118647a0986cb : SUCCESS in 18m 39s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/ad6271a987854f3a8dea67497a02d2b9 : SUCCESS in 21m 20s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/45138481e56a46749fc32b6e9d3d5402 : SUCCESS in 21m 11s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/c2397794473c4adea92312f6318665db : SUCCESS in 22m 57s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/430d0a28b9164eacb68b22eb63e1f22f : SUCCESS in 21m 14s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/0bebc4f781724b2682a43097ed9981c3 : SUCCESS in 21m 09s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/f91c5d5b094944d680eb09a4ce1b576c : SUCCESS in 22m 05s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/f8d29c71134347019c779348967a78f5 : SUCCESS in 6m 09s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/a12de3ef1e7b455c8dc13cb283169ae2 : SUCCESS in 19m 15s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/c6c3636049be45de962fd640088bdce0 : SUCCESS in 7m 00s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/123dbb4ca7f7489c844e2011226912df : SUCCESS in 1h 00m 00s\n- swift-probetests-centos-8-stream https://zuul.opendev.org/t/openstack/build/c5d4293c5f1a4176a532992ed5dfb793 : SUCCESS in 1h 05m 35s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/4e017b3d2cfb458f80fc7d51d6764450 : SUCCESS in 39m 57s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/edc6ae3edf144ebab7107ab98e0f9b64 : SUCCESS in 41m 08s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a0ed2c19731a4d4f8ce38a47a97a7a73 : SUCCESS in 20m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/39b5b08703cb4bff8d3c54245f0c941f : SUCCESS in 5m 11s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/b4b1f01463fe47d4a2985803636c4c47 : SUCCESS in 25m 52s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/0ab1a2400cf14f059cefe642d7c9e102 : SUCCESS in 44m 46s","accounts_in_message":[],"_revision_number":1},{"id":"0dfdf188b3531497c1adafda50d7f2358c19ae48","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2022-07-07 07:31:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1cd6ce6093e0302cef98f4e487a1946f84cd88cd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2022-07-08 16:01:45.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"4771091241a61dcc47eee8454a77a4441f52f393","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-08 17:08:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d3461658dd864510aa34028ac8ed5502\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9d1fc8d091614a2a8b667fb8dfa1b0db : SUCCESS in 7m 48s\n- grenade https://zuul.opendev.org/t/openstack/build/86fd128318e147d999cb0a5873032ebc : SUCCESS in 1h 01m 16s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/e6c4f9291a7942dd9c01807ee9006a87 : SUCCESS in 50m 56s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/59c07ac9dcd847b38c48f3f996bbe810 : SUCCESS in 49m 37s\n- swift-tox-func-py36-centos-8-stream-fips https://zuul.opendev.org/t/openstack/build/a8a2c39660214b7ab927d91de6a70108 : RETRY_LIMIT in 3m 54s (non-voting)\n- swift-tox-func-encryption-py36-centos-8-stream-fips https://zuul.opendev.org/t/openstack/build/b964f9e19cc745c694de87fa2544c1f0 : RETRY_LIMIT in 4m 17s (non-voting)\n- swift-tox-func-ec-py36-centos-8-stream-fips https://zuul.opendev.org/t/openstack/build/c7e7c5a662074a0ea9766df8343efc17 : RETRY_LIMIT in 4m 47s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/b3282b34e8284689b57950ffccf3c2da : SUCCESS in 7m 29s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/7c864209aba74900adcb9eb67f0eec6c : SUCCESS in 4m 40s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/72bf7dee43d5477190bb8afb8d58f877 : SUCCESS in 15m 41s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/1fdad0c5d0e84395b22182a3ad11f357 : SUCCESS in 15m 12s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/aff076f162f64c91a691364c57e0afc8 : SUCCESS in 15m 16s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/6b507f2d65224306ad158a774787524a : SUCCESS in 14m 57s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/b9354c14ae09446ba0019eb5afff7daf : SUCCESS in 15m 16s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/be5554080b874ed394ae533f3b8d0d3b : SUCCESS in 17m 09s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/5b0a8682b64446d7a1c1f71414288c10 : SUCCESS in 13m 33s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/bb441acb9e1c4a73b4de619b3885c4c6 : SUCCESS in 14m 47s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/7f68147630664e38ac1bf67bf79f560c : SUCCESS in 14m 23s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/1a8c70bc1af54fb78ed93bf2dcb6d471 : SUCCESS in 6m 32s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/32a94e25c24c49b5a576e5e33162ee6a : SUCCESS in 15m 33s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/29f75216707542b39d985500ae60a17b : SUCCESS in 6m 58s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/80851b3e17ef4bbcafd85b23b532e81d : SUCCESS in 51m 14s\n- swift-probetests-centos-8-stream https://zuul.opendev.org/t/openstack/build/de3703d791354ed8924a25168a0f4454 : SUCCESS in 59m 36s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/4a8e1dd0441a42efa29657eb02ebb84d : SUCCESS in 39m 11s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/28df251bbff74d6f8e9e6223728b1380 : SUCCESS in 42m 04s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c86d328594e74cd3babfddabc2d561c9 : SUCCESS in 14m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e7c423abaa134dbabef2dea2b43d699c : SUCCESS in 5m 19s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/c28a71cd42c74b8c8a196ea7e8e44d58 : SUCCESS in 17m 47s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/34b5190e64684f679587a25f948d8427 : SUCCESS in 56m 35s","accounts_in_message":[],"_revision_number":2},{"id":"46f1b8c9127f0ccc36aa460469b83c450109b102","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-08 17:12:26.000000000","message":"Patch Set 2:\n\nBuild failed (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d5ecdf6bca8844929028a70a5e9365b5\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/292f95117d144341bfcbdea08922c2a1 : SUCCESS in 1h 08m 18s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/98f98662b53c48138f6dc91b4f122a97 : SUCCESS in 43m 08s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/21e7909fa189457791607d8a442b2c0b : FAILURE in 1h 00m 49s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/6da649fde94947909417a803669f48fc : SUCCESS in 46m 40s","accounts_in_message":[],"_revision_number":2},{"id":"d73e7db92262ef9163ac5de542385ec909e13e0d","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2022-07-08 17:25:54.000000000","message":"Patch Set 2: Code-Review-2 Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"76a2afd4802bd144f83532d71e8a224aa2e28f85","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2023-01-10 18:08:53.000000000","message":"Abandoned\n\nPretty sure this was related to some shard-range investigation a while ago and is no longer needed/relevant -- feel free to revive it if I\u0027m off-base.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6de2880af61997b1d5c389e65d059e4a6a015c06","revisions":{"668028143556d49a85f439e09fa3df44fafb9958":{"kind":"REWORK","_number":1,"created":"2022-07-06 22:50:34.000000000","uploader":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"ref":"refs/changes/09/848909/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/09/848909/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/09/848909/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/09/848909/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/09/848909/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/09/848909/1"}}},"commit":{"parents":[{"commit":"475cdba65bcd29871b840395576572c0d8399a6b","subject":"Emit metrics for tempurl \u0026 formpost digest usage","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/475cdba65bcd29871b840395576572c0d8399a6b"}]}],"author":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2022-07-06 22:43:05.000000000","tz":-300},"committer":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2022-07-06 22:43:05.000000000","tz":-300},"subject":"Make in-memory databases worse","message":"Make in-memory databases worse\n\nOur tests use in-memory sqlite databases a lot for some reason; and they\ndo NOT work the same as a file database.  Specifically when you close a\nconnection to an in-memory database it goes away.  If you open two\nconnections to an in-memory database - they are different databases.\n\nOur database brokers routinely open a connection to an existing database\nwhile they have another connection open, and our get connection handler\nmakes sure that they are NOT the same connection - any test that tried\nthat with an in-memory database would discover instead of two\nconnections to the same database, they have two connections to different\ndatbases.\n\nThis change tries to start to un-cover and paper over the difference a\nlittle bit in an effort to prepare for the next change in the series\nwhich wants to add a call to a broker helper method that manages it\u0027s\nown connection inside a helper method that is passed in a connection.\n\nA future refactoring of brokers might try to standardize our broker\nmethod signatures so that the BYOC (bring your own connection) pattern\nis more universally supported and in-memory databases don\u0027t need a\nre-entrant .get() method.\n\nChange-Id: If0d57e7a2b253a1ee81c2953504141063060d102\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/668028143556d49a85f439e09fa3df44fafb9958"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/668028143556d49a85f439e09fa3df44fafb9958"}]},"branch":"refs/heads/master"},"6de2880af61997b1d5c389e65d059e4a6a015c06":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-07-08 16:01:45.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/09/848909/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/09/848909/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/09/848909/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/09/848909/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/09/848909/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/09/848909/2"}}},"commit":{"parents":[{"commit":"e3dddea0d1b5c6982ed542e3d251d573ca79299e","subject":"sharder: add unit test for skipping deleted containers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e3dddea0d1b5c6982ed542e3d251d573ca79299e"}]}],"author":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2022-07-06 22:43:05.000000000","tz":-300},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2022-07-08 15:55:57.000000000","tz":60},"subject":"Make in-memory databases worse","message":"Make in-memory databases worse\n\nOur tests use in-memory sqlite databases a lot for some reason; and they\ndo NOT work the same as a file database.  Specifically when you close a\nconnection to an in-memory database it goes away.  If you open two\nconnections to an in-memory database - they are different databases.\n\nOur database brokers routinely open a connection to an existing database\nwhile they have another connection open, and our get connection handler\nmakes sure that they are NOT the same connection - any test that tried\nthat with an in-memory database would discover instead of two\nconnections to the same database, they have two connections to different\ndatbases.\n\nThis change tries to start to un-cover and paper over the difference a\nlittle bit in an effort to prepare for the next change in the series\nwhich wants to add a call to a broker helper method that manages it\u0027s\nown connection inside a helper method that is passed in a connection.\n\nA future refactoring of brokers might try to standardize our broker\nmethod signatures so that the BYOC (bring your own connection) pattern\nis more universally supported and in-memory databases don\u0027t need a\nre-entrant .get() method.\n\nChange-Id: If0d57e7a2b253a1ee81c2953504141063060d102\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6de2880af61997b1d5c389e65d059e4a6a015c06"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6de2880af61997b1d5c389e65d059e4a6a015c06"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}