)]}'
{"swift/container/replicator.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"c825bc533cedfeefec49e3faa0f219d006cab3ca","unresolved":true,"context_lines":[{"line_number":156,"context_line":"                return node"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # not much point in trying to minimize handoff depth"},{"line_number":159,"context_line":"        return choice(list(self._local_device_ids.values()))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def get_reconciler_broker(self, timestamp):"},{"line_number":162,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"88c85467_0e1b2a4f","line":159,"updated":"2022-07-29 07:02:04.000000000","message":"As discussed this morning, I\u0027m definitely coming onboard this idea. Why loop through an entire get_more_nodes iterator which could be thousands of nodes just to in the end find a local device. When we know have a list of local devices!\n\nGoing though get_part_nodes, yes! going through get_more_nodes when we already and the local dev.. no.\n\nIf we do this, I don\u0027t think we loose anything, if anything we get a speed increase because we can unwrap a interator loop and just return a local device for this ring.\n\nOnly thing I think we can improve is to attempt to only select a node with some weight because we might be trying to drain a drive on the node, but we keep adding to it. So maybe something like: https://paste.opendev.org/show/815666/\n\n@al what do you think. Maybe we sqaush this down and use it?","commit_id":"f9c80b7c8888e0211858c9786a6936cf7553b6d1"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b138d5ad8ddd9e4db6e2e6e834127aef5f29f08a","unresolved":true,"context_lines":[{"line_number":156,"context_line":"                return node"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # not much point in trying to minimize handoff depth"},{"line_number":159,"context_line":"        return choice(list(self._local_device_ids.values()))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def get_reconciler_broker(self, timestamp):"},{"line_number":162,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3741edac_6e28dd18","line":159,"in_reply_to":"88c85467_0e1b2a4f","updated":"2022-07-29 13:57:16.000000000","message":"I prefer this with the diff in Matt\u0027s paste - i.e. try to use a device with weight first.","commit_id":"f9c80b7c8888e0211858c9786a6936cf7553b6d1"}]}