)]}'
{"test/functional/tests.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"653a9da084762fb26778c35b7190ee0db8cd3c31","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# In order to get the proper blocking behavior of sockets without using"},{"line_number":41,"context_line":"# threads, were we can set an arbitrary timeout for some piece of code under"},{"line_number":42,"context_line":"# test, we use eventlet with the standard sosket library patched. We have to"},{"line_number":43,"context_line":"# perform this setup at module import time, since all the socket module"},{"line_number":44,"context_line":"# bindings in the swiftclient code will have been made run package or class"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F5Jg%3D","line":41,"updated":"2014-04-09 17:03:17.000000000","message":"\"were\"? Is this an less used English conditional \u0027were we to do something, then...\u0027 or \u0027where we can\u0027?","commit_id":"3f37e3da45df032f93cb9934f2d7779449e74c17"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"8456571c485418f1ecb1f6cf1fe444b3b8a343c7","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# In order to get the proper blocking behavior of sockets without using"},{"line_number":41,"context_line":"# threads, were we can set an arbitrary timeout for some piece of code under"},{"line_number":42,"context_line":"# test, we use eventlet with the standard sosket library patched. We have to"},{"line_number":43,"context_line":"# perform this setup at module import time, since all the socket module"},{"line_number":44,"context_line":"# bindings in the swiftclient code will have been made run package or class"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F4uk%3D","line":41,"in_reply_to":"AAAAW3%2F%2F41w%3D","updated":"2014-04-09 17:28:19.000000000","message":"Done","commit_id":"3f37e3da45df032f93cb9934f2d7779449e74c17"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"7bf351c1e1c23518a8c560fcf46da2d18d5e66ba","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# In order to get the proper blocking behavior of sockets without using"},{"line_number":41,"context_line":"# threads, were we can set an arbitrary timeout for some piece of code under"},{"line_number":42,"context_line":"# test, we use eventlet with the standard sosket library patched. We have to"},{"line_number":43,"context_line":"# perform this setup at module import time, since all the socket module"},{"line_number":44,"context_line":"# bindings in the swiftclient code will have been made run package or class"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F41w%3D","line":41,"in_reply_to":"AAAAW3%2F%2F5Jg%3D","updated":"2014-04-09 17:17:41.000000000","message":"Thanks, I\u0027ll fix that.","commit_id":"3f37e3da45df032f93cb9934f2d7779449e74c17"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"653a9da084762fb26778c35b7190ee0db8cd3c31","unresolved":false,"context_lines":[{"line_number":1461,"context_line":"            raise SkipTest(\"Chunked PUT can only be tested with apache2 web\""},{"line_number":1462,"context_line":"                           \" front end\")"},{"line_number":1463,"context_line":""},{"line_number":1464,"context_line":"        def chunks(s, length\u003d3):"},{"line_number":1465,"context_line":"            i, j \u003d 0, length"},{"line_number":1466,"context_line":"            while i \u003c len(s):"},{"line_number":1467,"context_line":"                yield s[i:j]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F49U%3D","line":1464,"updated":"2014-04-09 17:03:17.000000000","message":"An unnecessarily scoped function again? You are persistent if anything.","commit_id":"3f37e3da45df032f93cb9934f2d7779449e74c17"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"7bf351c1e1c23518a8c560fcf46da2d18d5e66ba","unresolved":false,"context_lines":[{"line_number":1461,"context_line":"            raise SkipTest(\"Chunked PUT can only be tested with apache2 web\""},{"line_number":1462,"context_line":"                           \" front end\")"},{"line_number":1463,"context_line":""},{"line_number":1464,"context_line":"        def chunks(s, length\u003d3):"},{"line_number":1465,"context_line":"            i, j \u003d 0, length"},{"line_number":1466,"context_line":"            while i \u003c len(s):"},{"line_number":1467,"context_line":"                yield s[i:j]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F42E%3D","line":1464,"in_reply_to":"AAAAW3%2F%2F49U%3D","updated":"2014-04-09 17:17:41.000000000","message":";)\n\nModule globals can send a message: \"this method is shared in more than one scope, used outside of this module\".  When trying to figure out how to solve the threading issue, it was assumed that the timeout() method, being a module global, was used by other tests. That meant that changing it would have a potentially bigger impact and that considering an another approach might be required. Once it was clear that it was only used by the one test, that meant a change to that method\u0027s behavior would not have a global impact, and became a much more palatable solution.\n\nSo in that light, moving a module method to the one test that uses it more clearly communicates the current use.","commit_id":"3f37e3da45df032f93cb9934f2d7779449e74c17"},{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"f16c822a89b416416dadda5e5e55964b812f2d44","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"        limit \u003d load_constraint(\u0027max_file_size\u0027)"},{"line_number":1141,"context_line":"        tsecs \u003d 3"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"        def timeout(seconds, method, *args, **kwargs):"},{"line_number":1144,"context_line":"            try:"},{"line_number":1145,"context_line":"                with eventlet.Timeout(seconds):"},{"line_number":1146,"context_line":"                    method(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2Fznk%3D","line":1143,"updated":"2014-04-10 09:34:05.000000000","message":"is timeout function only used inside of this test?","commit_id":"5ff6a4d5d6cdbf39ba9f6d5d416cdd1c6c6a52ac"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"f67f94bc351328c6fb9c6e387b583e1ca65caaeb","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"        limit \u003d load_constraint(\u0027max_file_size\u0027)"},{"line_number":1141,"context_line":"        tsecs \u003d 3"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"        def timeout(seconds, method, *args, **kwargs):"},{"line_number":1144,"context_line":"            try:"},{"line_number":1145,"context_line":"                with eventlet.Timeout(seconds):"},{"line_number":1146,"context_line":"                    method(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FzIw%3D","line":1143,"in_reply_to":"AAAAW3%2F%2Fznk%3D","updated":"2014-04-10 10:36:37.000000000","message":"Yes, that is why I moved it in here, because if it was used by other tests, then this solution might not be a good one. But because it is only used by this test, it was easy to verify and we have confidence that it won\u0027t disrupt the other tests.","commit_id":"5ff6a4d5d6cdbf39ba9f6d5d416cdd1c6c6a52ac"}]}