)]}'
{"swift/account/auditor.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9519a0b5706a87b76a8095a873a1797f05dbe6f7","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            broker \u003d AccountBroker(path)"},{"line_number":117,"context_line":"            if not broker.is_deleted():"},{"line_number":118,"context_line":"                broker.get_info()"},{"line_number":119,"context_line":"                if {} \u003d\u003d broker.get_policy_stats():"},{"line_number":120,"context_line":"                    with broker.get() as conn:"},{"line_number":121,"context_line":"                        broker.set_storage_policy_info(conn)"},{"line_number":122,"context_line":"                self.logger.increment(\u0027passes\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F4iA%3D","line":119,"updated":"2014-04-08 19:12:13.000000000","message":"\"if not broker.get_policy_stats()\" would place less restriction on the interface of the empty condition.  Since set_storage_policy_info is idempotent I think it\u0027d be better to error on the side of too loose than too strict.\n\nAlso the yoda ordering isn\u0027t very common in python.  Since \"if x \u003d 1\" is syntactically invalid python tends to read the natural ordering of test operations.","commit_id":"428a1cd57bcc1a0586f1d4ffeffc2b9cdadc2837"}],"swift/account/backend.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9519a0b5706a87b76a8095a873a1797f05dbe6f7","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        \"\"\""},{"line_number":528,"context_line":"        Wrapper for _migrate_add_storage_policy_index"},{"line_number":529,"context_line":"        \"\"\""},{"line_number":530,"context_line":"        self._migrate_add_storage_policy_index(conn)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F4a0%3D","line":530,"updated":"2014-04-08 19:12:13.000000000","message":"Ither _migrate_add_storage_policy_index should be a part of the public interface or not.  I see no value in a mis-direction wrapper that exists only to cause confusion and make a \"private\" method public.  Maybe just remove the underscore from _migrate and the one place it\u0027s called and then let the auditor use it.","commit_id":"428a1cd57bcc1a0586f1d4ffeffc2b9cdadc2837"}],"test/unit/account/test_auditor.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9519a0b5706a87b76a8095a873a1797f05dbe6f7","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @contextmanager"},{"line_number":39,"context_line":"    def get(self):"},{"line_number":40,"context_line":"        yield {}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def get_info(self):"},{"line_number":43,"context_line":"        if self.file.startswith(\u0027fail\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F4lI%3D","line":40,"updated":"2014-04-08 19:12:13.000000000","message":"is this the connection?  I think maybe just a bare yield (None), or yield \u0027mock_connection\u0027 would be better...","commit_id":"428a1cd57bcc1a0586f1d4ffeffc2b9cdadc2837"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9519a0b5706a87b76a8095a873a1797f05dbe6f7","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def set_storage_policy_info(self, conn):"},{"line_number":57,"context_line":"        with open(self.db_file, \u0027w+\u0027) as f:"},{"line_number":58,"context_line":"            f.write(\u0027{\"storage_policy_index\": 0}\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class TestAuditor(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F4kc%3D","line":58,"updated":"2014-04-08 19:12:13.000000000","message":"I think the value of json here is questionable at best - I found it pretty confusing.","commit_id":"428a1cd57bcc1a0586f1d4ffeffc2b9cdadc2837"}]}