)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ba2fff01a19d7d437d54e1ee3d63650b450c20b6","unresolved":true,"context_lines":[{"line_number":15,"context_line":"including /etc/fstab) after editing /etc/fstab on systems where"},{"line_number":16,"context_line":"systemd is the running init. Check for that case by looking for the"},{"line_number":17,"context_line":"existence of the directory /run/systemd/system, as documented in"},{"line_number":18,"context_line":"sd_booted(3)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Signed-off-by: Matthew Vernon \u003cmvernon@wikimedia.org\u003e"},{"line_number":21,"context_line":"Change-Id: I8830e3da9b6b085224511ac351f2d2860119c432"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"40a7540b_036e3880","line":18,"updated":"2022-10-12 06:19:56.000000000","message":"Oh nice! I\u0027ll have to remember that, it\u0027s a nice way to know if systemd is running on a system.\n\nI\u0027ll throw this on a SAIO and test it out!","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"},{"author":{"_account_id":34175,"name":"Matthew Vernon","email":"mvernon@wikimedia.org","username":"mvernon"},"change_message_id":"83b95da77199db7787703d50d0044ca795f2f86f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"including /etc/fstab) after editing /etc/fstab on systems where"},{"line_number":16,"context_line":"systemd is the running init. Check for that case by looking for the"},{"line_number":17,"context_line":"existence of the directory /run/systemd/system, as documented in"},{"line_number":18,"context_line":"sd_booted(3)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Signed-off-by: Matthew Vernon \u003cmvernon@wikimedia.org\u003e"},{"line_number":21,"context_line":"Change-Id: I8830e3da9b6b085224511ac351f2d2860119c432"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fe0e1dba_6111cb88","line":18,"in_reply_to":"40a7540b_036e3880","updated":"2022-10-14 08:48:28.000000000","message":"Done","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34175,"name":"Matthew Vernon","email":"mvernon@wikimedia.org","username":"mvernon"},"change_message_id":"003b0661101790f367b741a86da49f3660ef84a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7fa91854_fc95fe18","updated":"2022-10-03 14:15:46.000000000","message":"Hi Tim,\n\nI don\u0027t suppose you might be able to have a look at this change request, please?\n\nThanks,\n\nMatthew","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"},{"author":{"_account_id":34175,"name":"Matthew Vernon","email":"mvernon@wikimedia.org","username":"mvernon"},"change_message_id":"d4e5abb78052cf08b78cf99e23bf4164b7ae983a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7efea0f4_b9d517ae","updated":"2022-10-17 10:40:28.000000000","message":"I tried just updating the requirements.txt file (cf https://review.opendev.org/c/openstack/swift/+/861583 ) but that fails CI because the version restriction isn\u0027t in global requirements. I don\u0027t know if it\u0027s worth pushing there because this is an issue with trying to still support old versions of python?","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b79b1c35ba2dfb4d1271af4d039333e82160ea14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5cbb778b_9b25f6a9","updated":"2022-10-17 05:01:26.000000000","message":"I\u0027ve been testing this a SAIO env. I\u0027m confirmed that systemd doesn\u0027t watch /etc/fstab. And this code seems to all run fine for me.\n\nThanks so much for improving and adding systemd awareness to the script Matthew!","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"},{"author":{"_account_id":34175,"name":"Matthew Vernon","email":"mvernon@wikimedia.org","username":"mvernon"},"change_message_id":"01f5ca2ef8021a218d690ca7d6102d72c68545be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d2466291_b08c553a","updated":"2022-10-17 08:15:57.000000000","message":"The gating jobs are failing on python2 incompatibility, which is nothing to do with the code I changed. In every failing case the error is:\n```\n  File \"/home/zuul/src/opendev.org/openstack/swift/.tox/py27/lib/python2.7/site-packages/paste/deploy/loadwsgi.py\", line 82\n    args[0] \u003d f\u0027Error in file {parser.filename}: {e}\u0027\n                                                    ^\nSyntaxError: invalid syntax\n```\n\nf-strings are a python3-only feature, so this is never going to pass python2 tests. But that\u0027s nothing to do with my changes. Python-pastedeploy has worked in py2 in the past.\n\nAh, looking at the upstream release news: https://docs.pylonsproject.org/projects/pastedeploy/en/latest/news.html I see\n\n```\n3.0 (2022-10-16)\n\n    Drop support for Python 2, as well as 3.4, 3.5, and 3.6.\n```\n\n...so it looks like the requirements.txt needs updating to specify a maximum version of PasteDeploy of 2.1.1?\n\nDo you want me to try that with this otherwise-unrelated change, or via some other process? At a guess no swift gate jobs will work on python 2 in the mean time...","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"47b1b8f0f5f4d310c680737be7ebdd41808aa262","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fbca2975_b905676f","updated":"2022-10-12 11:15:10.000000000","message":"my VSAIO systemd-remount-fs service is a oneshot. Do you have yours on an automount. Or does it somehow get triggered every now and again.\nSo the code seems to work.. but trying to figure out how long I need to wait to trigger the remount from systemd.\n\nIt\u0027s getting late here, so probably just missing something obvious. I\u0027ll play a little bit more in the morning to recreate the issue. However, having it do the reload definitely doesn\u0027t hurt or break anything. So either way I might +2/+A.. especialy as it obviously fixes it for you Matthew, and thats really importnat :) ","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6bafb79831357a18af8a4880be8ccf0e83e102b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0edb035c_d0914934","updated":"2022-10-17 17:29:46.000000000","message":"recheck","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"},{"author":{"_account_id":34175,"name":"Matthew Vernon","email":"mvernon@wikimedia.org","username":"mvernon"},"change_message_id":"2a4673d6b05cd5fce218bc01cb6cfff1a4ea9882","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"67b78e22_676fb4ab","in_reply_to":"fbca2975_b905676f","updated":"2022-10-12 12:21:47.000000000","message":"systemd-remount-fs.service is (rather confusingly) not about regular filesystems - it\u0027s only /, /usr, and the kernel API filesystems (cf.  https://www.freedesktop.org/software/systemd/man/systemd-remount-fs.service.html ).\n\nI can\u0027t find documentation of how often systemd will remount unmounted filesystems, sorry (though I do have upstream noting that this change of behaviour compared to system V init is intentional - https://github.com/systemd/systemd/issues/3568#issuecomment-227470699 )","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"}],"bin/swift-drive-audit":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b79b1c35ba2dfb4d1271af4d039333e82160ea14","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    if unmounts \u003d\u003d 0:"},{"line_number":225,"context_line":"        logger.info(\"No drives were unmounted\")"},{"line_number":226,"context_line":"    elif os.path.isdir(\"/run/systemd/system\"):"},{"line_number":227,"context_line":"        logger.debug(\"fstab updated, calling systemctl daemon-reload\")"},{"line_number":228,"context_line":"        subprocess.call([\"/usr/bin/systemctl\", \"daemon-reload\"])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"73f14c60_975625a5","line":227,"updated":"2022-10-17 05:01:26.000000000","message":"Yup, looking around this does seem to be the way others look to see if it\u0027s a systemd controlled host.","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"},{"author":{"_account_id":34175,"name":"Matthew Vernon","email":"mvernon@wikimedia.org","username":"mvernon"},"change_message_id":"c6f81229eef2daebe0f4c00c6f59a8b7422cf183","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    if unmounts \u003d\u003d 0:"},{"line_number":225,"context_line":"        logger.info(\"No drives were unmounted\")"},{"line_number":226,"context_line":"    elif os.path.isdir(\"/run/systemd/system\"):"},{"line_number":227,"context_line":"        logger.debug(\"fstab updated, calling systemctl daemon-reload\")"},{"line_number":228,"context_line":"        subprocess.call([\"/usr/bin/systemctl\", \"daemon-reload\"])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"2c161575_ec8d5012","line":227,"in_reply_to":"73f14c60_975625a5","updated":"2022-10-17 10:40:46.000000000","message":"Done","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b79b1c35ba2dfb4d1271af4d039333e82160ea14","unresolved":true,"context_lines":[{"line_number":225,"context_line":"        logger.info(\"No drives were unmounted\")"},{"line_number":226,"context_line":"    elif os.path.isdir(\"/run/systemd/system\"):"},{"line_number":227,"context_line":"        logger.debug(\"fstab updated, calling systemctl daemon-reload\")"},{"line_number":228,"context_line":"        subprocess.call([\"/usr/bin/systemctl\", \"daemon-reload\"])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"33719fa7_4b151d89","line":228,"updated":"2022-10-17 05:01:26.000000000","message":"And systemd does indeed not refresh fstab as stated by Matthew.","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"},{"author":{"_account_id":34175,"name":"Matthew Vernon","email":"mvernon@wikimedia.org","username":"mvernon"},"change_message_id":"c6f81229eef2daebe0f4c00c6f59a8b7422cf183","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        logger.info(\"No drives were unmounted\")"},{"line_number":226,"context_line":"    elif os.path.isdir(\"/run/systemd/system\"):"},{"line_number":227,"context_line":"        logger.debug(\"fstab updated, calling systemctl daemon-reload\")"},{"line_number":228,"context_line":"        subprocess.call([\"/usr/bin/systemctl\", \"daemon-reload\"])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"2a653f1d_689b5155","line":228,"in_reply_to":"33719fa7_4b151d89","updated":"2022-10-17 10:40:46.000000000","message":"Done","commit_id":"e838d8a9475242c6e8e47f1229cabecce0fc3281"}]}