)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"f5e66f05d5d3f9fecd374d195f4b9dfdc0e9f4e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10e9629b_d08f0c67","updated":"2022-10-05 22:20:13.000000000","message":"thanks for the refactoring! I squashed it, improving code readability patch by patch.","commit_id":"b40f156d12ac6b760c928320f4591db7297120d9"}],"swift/proxy/controllers/base.py":[{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"f5e66f05d5d3f9fecd374d195f4b9dfdc0e9f4e4","unresolved":true,"context_lines":[{"line_number":2458,"context_line":"        :return: an instance of :class:`swift.common.utils.ShardRange`,"},{"line_number":2459,"context_line":"            or None if the update should go back to the root"},{"line_number":2460,"context_line":"        \"\"\""},{"line_number":2461,"context_line":"        cache_key \u003d get_cache_key(account, container, shard\u003d\u0027updating\u0027)"},{"line_number":2462,"context_line":"        infocache \u003d req.environ.setdefault(\u0027swift.infocache\u0027, {})"},{"line_number":2463,"context_line":"        memcache \u003d cache_from_env(req.environ, True)"},{"line_number":2464,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"594cee23_1b6166f4","line":2461,"updated":"2022-10-05 22:20:13.000000000","message":"I moved those three lines to line 2473.","commit_id":"b40f156d12ac6b760c928320f4591db7297120d9"}],"swift/proxy/controllers/container.py":[{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"f5e66f05d5d3f9fecd374d195f4b9dfdc0e9f4e4","unresolved":true,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _translate_resp_from_cache(self, req, info):"},{"line_number":130,"context_line":"        headers \u003d headers_from_container_info(info)"},{"line_number":131,"context_line":"        if not (headers and is_success(info[\u0027status\u0027]) and"},{"line_number":132,"context_line":"                info.get(\u0027sharding_state\u0027) \u003d\u003d \u0027sharded\u0027):"},{"line_number":133,"context_line":"            # XXX not sure if \u0027miss\u0027 is the correct cache state"},{"line_number":134,"context_line":"            return None, \u0027miss\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c046bc5_bf617b1f","line":131,"updated":"2022-10-05 22:20:13.000000000","message":"I added checking of \u0027info\u0027","commit_id":"b40f156d12ac6b760c928320f4591db7297120d9"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"f5e66f05d5d3f9fecd374d195f4b9dfdc0e9f4e4","unresolved":true,"context_lines":[{"line_number":258,"context_line":"                  \u0027shard\u0027 for shard range listing, \u0027object\u0027 for object listing."},{"line_number":259,"context_line":"        :param  info: the cached container info."},{"line_number":260,"context_line":"        \"\"\""},{"line_number":261,"context_line":"        record_cache_op_metrics("},{"line_number":262,"context_line":"            self.logger, \u0027shard_listing\u0027, cache_state, resp)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def GETorHEAD(self, req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ebe5c505_303da7f4","line":261,"updated":"2022-10-05 22:20:13.000000000","message":"I reverted your changes to this function. New changes will record shard listing metrics even if request failed.","commit_id":"b40f156d12ac6b760c928320f4591db7297120d9"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"f5e66f05d5d3f9fecd374d195f4b9dfdc0e9f4e4","unresolved":true,"context_lines":[{"line_number":4580,"context_line":"                resp \u003d req.get_response(self.app)"},{"line_number":4581,"context_line":""},{"line_number":4582,"context_line":"            self.assertEqual(resp.status_int, 202)"},{"line_number":4583,"context_line":"            self.assertEqual(["},{"line_number":4584,"context_line":"                \u0027container.shard_listing.cache.disabled.200\u0027,"},{"line_number":4585,"context_line":"                \u0027container.shard_listing.cache.disabled.404\u0027,"},{"line_number":4586,"context_line":"                \u0027object.shard_updating.cache.disabled.404\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"8927bcbe_80b78456","line":4583,"updated":"2022-10-05 22:20:13.000000000","message":"I reverted back this change. Under this test condition, shard_listing metrics shouldn\u0027t appear here. We need record shard listing errors in following MR though.","commit_id":"b40f156d12ac6b760c928320f4591db7297120d9"}]}