)]}'
{"swift/common/utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ad498e87c8c9e2f009b2d56816a810890e075037","unresolved":true,"context_lines":[{"line_number":1944,"context_line":"                             \u0027tail_prefix %r is invalid\u0027 % tail_prefix)"},{"line_number":1945,"context_line":"        if \u0027\\n\u0027 in tail_prefix:"},{"line_number":1946,"context_line":"            raise ValueError(\u0027statsd metric names may not contain a newline; \u0027"},{"line_number":1947,"context_line":"                             \u0027tail_prefix %r is invalid\u0027 % tail_prefix)"},{"line_number":1948,"context_line":""},{"line_number":1949,"context_line":"        if tail_prefix and self._base_prefix:"},{"line_number":1950,"context_line":"            self._prefix \u003d \u0027.\u0027.join([self._base_prefix, tail_prefix, \u0027\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"d54597e0_d41387ee","line":1947,"updated":"2022-10-21 04:38:45.000000000","message":"Here (and above) we\u0027re still configuring the service; failing hard seems reasonable and appropriate.","commit_id":"ebbe02f38da5c6a2d5b7eec7ceda186d71cb19d9"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ad498e87c8c9e2f009b2d56816a810890e075037","unresolved":true,"context_lines":[{"line_number":1973,"context_line":"                             \u0027metric %r is invalid\u0027 % m_name)"},{"line_number":1974,"context_line":"        if \u0027\\n\u0027 in m_name:"},{"line_number":1975,"context_line":"            raise ValueError(\u0027statsd metric names may not contain a newline; \u0027"},{"line_number":1976,"context_line":"                             \u0027metric %r is invalid\u0027 % m_name)"},{"line_number":1977,"context_line":""},{"line_number":1978,"context_line":"        if sample_rate is None:"},{"line_number":1979,"context_line":"            sample_rate \u003d self._default_sample_rate"}],"source_content_type":"text/x-python","patch_set":1,"id":"c318ee81_c7bddb66","line":1976,"updated":"2022-10-21 04:38:45.000000000","message":"Arguably, maybe it\u0027d be better to log an error/warning and just drop the metric on the floor?","commit_id":"ebbe02f38da5c6a2d5b7eec7ceda186d71cb19d9"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"68cdc4d1d86212ba83aa14eee95e293dfa491951","unresolved":true,"context_lines":[{"line_number":2494,"context_line":"        sample_rate_factor \u003d float(conf.get("},{"line_number":2495,"context_line":"            \u0027log_statsd_sample_rate_factor\u0027, 1))"},{"line_number":2496,"context_line":"        if statsd_tail_prefix is None:"},{"line_number":2497,"context_line":"            statsd_tail_prefix \u003d name"},{"line_number":2498,"context_line":"        statsd_client \u003d StatsdClient(statsd_host, statsd_port, base_prefix,"},{"line_number":2499,"context_line":"                                     statsd_tail_prefix, default_sample_rate,"},{"line_number":2500,"context_line":"                                     sample_rate_factor, logger\u003dlogger)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4d005f8_dab51fe4","line":2497,"updated":"2022-10-21 05:01:08.000000000","message":"Oh, but we almost certainly need to change this to\n\n statsd_tail_prefix \u003d name.replace(\u0027:\u0027, \u0027.\u0027)\n\nor\n\n statsd_tail_prefix \u003d name.replace(\u0027:\u0027, \u0027-\u0027)\n\nor something...","commit_id":"ebbe02f38da5c6a2d5b7eec7ceda186d71cb19d9"}]}