)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"aba00e68755e8e0c90b51f255407352ea1c21b52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b1780087_ec88a8f7","updated":"2022-10-27 09:28:30.000000000","message":"Tim is fixing the probe test issue https://review.opendev.org/c/openstack/swift/+/862758\n\nThese are useful additions but I think we could avoid adding another log message","commit_id":"d544aabfd875edf51786622a5901fcf6732bf471"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"2765a24b2d915bed722bf859d363d9562dc37bc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e22d674_77ac56ef","updated":"2022-10-27 23:48:57.000000000","message":"thanks!","commit_id":"d544aabfd875edf51786622a5901fcf6732bf471"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c3daf1a88921f719747db18a1e986c9cd01e7029","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d6e53f76_ebfa0f2a","updated":"2022-10-28 10:58:25.000000000","message":"It\u0027s sad that no tests needed fixing. If we care enough about the logs to invest in changing them then we ought to be testing them 😊\n\ntest changes here, please squash if you agree: https://review.opendev.org/c/openstack/swift/+/862882","commit_id":"60db258d60c5667510856c164c25b0fb08f32d27"}],"swift/container/sharder.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"aba00e68755e8e0c90b51f255407352ea1c21b52","unresolved":true,"context_lines":[{"line_number":1968,"context_line":"            own_shard_range \u003d broker.get_own_shard_range()"},{"line_number":1969,"context_line":"            cleaving_context.cursor \u003d own_shard_range.lower_str"},{"line_number":1970,"context_line":"            cleaving_context.ranges_todo \u003d len(ranges_todo)"},{"line_number":1971,"context_line":"            self.logger.info(\u0027Starting to cleave (%s todo): %s\u0027,"},{"line_number":1972,"context_line":"                              cleaving_context.ranges_todo, quote(broker.path))"},{"line_number":1973,"context_line":""},{"line_number":1974,"context_line":"        own_shard_range \u003d broker.get_own_shard_range(no_default\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"de1a5cd2_7e496033","line":1971,"range":{"start_line":1971,"start_character":23,"end_line":1971,"end_character":28},"updated":"2022-10-27 09:28:30.000000000","message":"I think I am in favour of this - it is consistent with logging cleaving completed at info level and enables us to better track how long cleaving takes.","commit_id":"d544aabfd875edf51786622a5901fcf6732bf471"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"2765a24b2d915bed722bf859d363d9562dc37bc8","unresolved":false,"context_lines":[{"line_number":1968,"context_line":"            own_shard_range \u003d broker.get_own_shard_range()"},{"line_number":1969,"context_line":"            cleaving_context.cursor \u003d own_shard_range.lower_str"},{"line_number":1970,"context_line":"            cleaving_context.ranges_todo \u003d len(ranges_todo)"},{"line_number":1971,"context_line":"            self.logger.info(\u0027Starting to cleave (%s todo): %s\u0027,"},{"line_number":1972,"context_line":"                              cleaving_context.ranges_todo, quote(broker.path))"},{"line_number":1973,"context_line":""},{"line_number":1974,"context_line":"        own_shard_range \u003d broker.get_own_shard_range(no_default\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6f35dd_9a3366dc","line":1971,"range":{"start_line":1971,"start_character":23,"end_line":1971,"end_character":28},"in_reply_to":"de1a5cd2_7e496033","updated":"2022-10-27 23:48:57.000000000","message":"Ack","commit_id":"d544aabfd875edf51786622a5901fcf6732bf471"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"aba00e68755e8e0c90b51f255407352ea1c21b52","unresolved":true,"context_lines":[{"line_number":2210,"context_line":"            if cleave_complete:"},{"line_number":2211,"context_line":"                self.logger.info(\u0027Completed cleaving of %s\u0027,"},{"line_number":2212,"context_line":"                                 quote(broker.path))"},{"line_number":2213,"context_line":"                if self._complete_sharding(broker):"},{"line_number":2214,"context_line":"                    state \u003d SHARDED"},{"line_number":2215,"context_line":"                    self._increment_stat(\u0027visited\u0027, \u0027completed\u0027, statsd\u003dTrue)"},{"line_number":2216,"context_line":"                    self.logger.info("}],"source_content_type":"text/x-python","patch_set":1,"id":"63592de6_9e5ddebf","line":2213,"range":{"start_line":2213,"start_character":25,"end_line":2213,"end_character":42},"updated":"2022-10-27 09:28:30.000000000","message":"I think we always log a warning if this returns False","commit_id":"d544aabfd875edf51786622a5901fcf6732bf471"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"2765a24b2d915bed722bf859d363d9562dc37bc8","unresolved":false,"context_lines":[{"line_number":2210,"context_line":"            if cleave_complete:"},{"line_number":2211,"context_line":"                self.logger.info(\u0027Completed cleaving of %s\u0027,"},{"line_number":2212,"context_line":"                                 quote(broker.path))"},{"line_number":2213,"context_line":"                if self._complete_sharding(broker):"},{"line_number":2214,"context_line":"                    state \u003d SHARDED"},{"line_number":2215,"context_line":"                    self._increment_stat(\u0027visited\u0027, \u0027completed\u0027, statsd\u003dTrue)"},{"line_number":2216,"context_line":"                    self.logger.info("}],"source_content_type":"text/x-python","patch_set":1,"id":"dcc6dbfc_3e079693","line":2213,"range":{"start_line":2213,"start_character":25,"end_line":2213,"end_character":42},"in_reply_to":"63592de6_9e5ddebf","updated":"2022-10-27 23:48:57.000000000","message":"Ack","commit_id":"d544aabfd875edf51786622a5901fcf6732bf471"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"aba00e68755e8e0c90b51f255407352ea1c21b52","unresolved":true,"context_lines":[{"line_number":2215,"context_line":"                    self._increment_stat(\u0027visited\u0027, \u0027completed\u0027, statsd\u003dTrue)"},{"line_number":2216,"context_line":"                    self.logger.info("},{"line_number":2217,"context_line":"                        \u0027Completed unlinking retiring db file of %s\u0027,"},{"line_number":2218,"context_line":"                        quote(broker.path))"},{"line_number":2219,"context_line":"                else:"},{"line_number":2220,"context_line":"                    self.logger.debug(\u0027Remaining in sharding state %s\u0027,"},{"line_number":2221,"context_line":"                                      quote(broker.path))"}],"source_content_type":"text/x-python","patch_set":1,"id":"53fed70b_46c1c575","line":2218,"updated":"2022-10-27 09:28:30.000000000","message":"instead of adding another log line I might suggest moving the existing info log (line 2211) to here and also to replace the debug log at 2220\n\nSo remove line 2211 and here log at info level something like\n\n  Completed cleaving (DB set to sharded state)\n  \nthen at line 2220 log at info level:\n\n  Completed cleaving (DB not set to sharded state)","commit_id":"d544aabfd875edf51786622a5901fcf6732bf471"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"2765a24b2d915bed722bf859d363d9562dc37bc8","unresolved":false,"context_lines":[{"line_number":2215,"context_line":"                    self._increment_stat(\u0027visited\u0027, \u0027completed\u0027, statsd\u003dTrue)"},{"line_number":2216,"context_line":"                    self.logger.info("},{"line_number":2217,"context_line":"                        \u0027Completed unlinking retiring db file of %s\u0027,"},{"line_number":2218,"context_line":"                        quote(broker.path))"},{"line_number":2219,"context_line":"                else:"},{"line_number":2220,"context_line":"                    self.logger.debug(\u0027Remaining in sharding state %s\u0027,"},{"line_number":2221,"context_line":"                                      quote(broker.path))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d68c4ff_2233b538","line":2218,"in_reply_to":"53fed70b_46c1c575","updated":"2022-10-27 23:48:57.000000000","message":"Done","commit_id":"d544aabfd875edf51786622a5901fcf6732bf471"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c3daf1a88921f719747db18a1e986c9cd01e7029","unresolved":true,"context_lines":[{"line_number":2181,"context_line":"                        self.logger.info(\u0027Kick off container cleaving on %s, \u0027"},{"line_number":2182,"context_line":"                                         \u0027own shard range in state %r\u0027,"},{"line_number":2183,"context_line":"                                         quote(broker.path),"},{"line_number":2184,"context_line":"                                         own_shard_range.state_text)"},{"line_number":2185,"context_line":"                elif is_leader:"},{"line_number":2186,"context_line":"                    if broker.set_sharding_state():"},{"line_number":2187,"context_line":"                        state \u003d SHARDING"}],"source_content_type":"text/x-python","patch_set":2,"id":"dd72a313_47ceb8b5","line":2184,"updated":"2022-10-28 10:58:25.000000000","message":"if we add this info line I\u0027m not sure we need to change line 1971 from debug to info - I think we\u0027ll always get both lines logged?? (see test in follow on patch)","commit_id":"60db258d60c5667510856c164c25b0fb08f32d27"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"7f5643a741807d7dd250f40d4db95865869cf5d0","unresolved":false,"context_lines":[{"line_number":2181,"context_line":"                        self.logger.info(\u0027Kick off container cleaving on %s, \u0027"},{"line_number":2182,"context_line":"                                         \u0027own shard range in state %r\u0027,"},{"line_number":2183,"context_line":"                                         quote(broker.path),"},{"line_number":2184,"context_line":"                                         own_shard_range.state_text)"},{"line_number":2185,"context_line":"                elif is_leader:"},{"line_number":2186,"context_line":"                    if broker.set_sharding_state():"},{"line_number":2187,"context_line":"                        state \u003d SHARDING"}],"source_content_type":"text/x-python","patch_set":2,"id":"278fc534_3823835b","line":2184,"in_reply_to":"8e458f46_b93e9e7e","updated":"2022-10-28 17:44:09.000000000","message":"oh, wait, 1971 needs to be INFO, because it prints out how many shard ranges it\u0027s going to cleave. And then we can check the INFO log from the end of cleaving, how many shard ranges it actually has done.","commit_id":"60db258d60c5667510856c164c25b0fb08f32d27"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"69d3f207cdf29873223ebc35a332d57b911252c5","unresolved":false,"context_lines":[{"line_number":2181,"context_line":"                        self.logger.info(\u0027Kick off container cleaving on %s, \u0027"},{"line_number":2182,"context_line":"                                         \u0027own shard range in state %r\u0027,"},{"line_number":2183,"context_line":"                                         quote(broker.path),"},{"line_number":2184,"context_line":"                                         own_shard_range.state_text)"},{"line_number":2185,"context_line":"                elif is_leader:"},{"line_number":2186,"context_line":"                    if broker.set_sharding_state():"},{"line_number":2187,"context_line":"                        state \u003d SHARDING"}],"source_content_type":"text/x-python","patch_set":2,"id":"8e458f46_b93e9e7e","line":2184,"in_reply_to":"dd72a313_47ceb8b5","updated":"2022-10-28 17:40:07.000000000","message":"agreed, I turned 1971 from debug back to info.","commit_id":"60db258d60c5667510856c164c25b0fb08f32d27"}]}