)]}'
{"id":"openstack%2Fswift~862826","triplet_id":"openstack%2Fswift~master~Ic378ea85fa9fe139af6c5a2d985c6e01699e43a8","project":"openstack/swift","branch":"master","topic":"p-node-iter","hashtags":[],"change_id":"Ic378ea85fa9fe139af6c5a2d985c6e01699e43a8","subject":"proxy: reduce repeated logic in NodeIter","status":"ABANDONED","created":"2022-10-27 15:40:52.000000000","updated":"2022-10-28 13:36:00.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"31c86697e775f6ce105cc9d737cded6894334c3e","_number":862826,"virtual_id_number":862826,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2022-10-27 17:06:28.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-27 15:55:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-10-27 17:06:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4541289de917d045ce1f239e2b9f5b6ff7c9792f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2022-10-27 15:40:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e2fbd35a3f87ee3c59807d75537b33432d4b0d10","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-10-27 15:55:57.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d44065db5bc742659e5c01b966e4ae6d\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/95956dcfecbb46828c9294277e19f406 : FAILURE in 5m 04s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/16a1c05432094fcaa52825737af4694a : FAILURE in 5m 29s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/971388023f534f4796aaf2cd47bb453f : FAILURE in 4m 23s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/bc9dae02cbaf4458bcda4cf0db9323ba : FAILURE in 5m 05s","accounts_in_message":[],"_revision_number":1},{"id":"6a5638653d2f74b7f124e53fff30be4c7cf9a43d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-10-27 17:06:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f29fb8af123c4551bc75c1b859c58317\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d7283181dbcf45cb8ff6ff98138d60e2 : SUCCESS in 7m 42s\n- grenade https://zuul.opendev.org/t/openstack/build/baa3bdc0a0d648d79af145abebd964d4 : SUCCESS in 41m 12s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/96fea443a9624b5d9c98df8dc2f8a139 : SUCCESS in 33m 41s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/10dc434f6cad4afd99d75069c2aaa222 : SUCCESS in 39m 12s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/bee55ef453d94ee59ed4a8eef4495461 : FAILURE in 14m 58s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/c41f3888e5fb4d15932025c2a274804a : FAILURE in 16m 57s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/6b87d2f1e2e84a07a7aaabbb492bf6c6 : FAILURE in 15m 30s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/991530b434eb493aab85c88c197701d0 : SUCCESS in 8m 16s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/2c448e3e5a334227812413d84fbcab81 : SUCCESS in 5m 30s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/bffcb91a07df4a569b476b30eb2e2a54 : SUCCESS in 13m 22s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/0e455f560db1407593b48198c4201ef3 : SUCCESS in 12m 33s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/c72cf8422d9e4f118764a975c020c820 : SUCCESS in 12m 59s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/9f06994020104bfe999d7a6022d9ee4f : SUCCESS in 15m 03s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/bfd9b8a4992f445c9675ae0e68b92f84 : SUCCESS in 15m 55s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/b06443651bb14bad82a12315c3f469e5 : SUCCESS in 15m 42s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/22c3a88519f2432da9495665e93dff29 : SUCCESS in 13m 16s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/1cafab5cea5b4827831651e7e25a7baf : SUCCESS in 11m 38s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/774111d671dc471a9ceec87c9ff7d636 : SUCCESS in 14m 15s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/2e2bd5d3e9dc466f8366dc901c8ec2fd : SUCCESS in 6m 03s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/494ac8e4a3c04fa8865ef52c02dfd043 : SUCCESS in 14m 20s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/f76d2e92bd2641c5a3184e6ceb483dd7 : SUCCESS in 7m 11s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/9198ce4d835d4ac09526c4e3bd65cef8 : SUCCESS in 52m 23s\n- swift-probetests-centos-8-stream https://zuul.opendev.org/t/openstack/build/f929d7ffc030474a8ccf42581671e8d6 : SUCCESS in 53m 36s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/1470b409bc2f4b2c82ac036bfccf4153 : SUCCESS in 46m 48s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/d12cf18cc93a4c799c335da96a53fa17 : SUCCESS in 51m 43s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1bc05e01616f4f96b29b563e2b1479c6 : SUCCESS in 17m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a1eb779553734e35afb04f32abc7f748 : SUCCESS in 5m 58s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/73cb099b62cf404b97840b5f1be2a0ce : SUCCESS in 27m 44s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9ee3a0ae522d455b8ce247edaf4d32df : SUCCESS in 40m 51s","accounts_in_message":[],"_revision_number":1},{"id":"31c86697e775f6ce105cc9d737cded6894334c3e","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2022-10-28 13:36:00.000000000","message":"Abandoned\n\nsquashed into parent","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2a5915fce1ff65365fe4b4280f9eb8274fecb0a6","revisions":{"2a5915fce1ff65365fe4b4280f9eb8274fecb0a6":{"kind":"REWORK","_number":1,"created":"2022-10-27 15:40:52.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/26/862826/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/26/862826/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/26/862826/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/26/862826/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/26/862826/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/26/862826/1"}}},"commit":{"parents":[{"commit":"bf06e3bbddcee64b7f585b0711a7ca1df28bd651","subject":"proxy: fix NodeIter nodes_left decrementing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/bf06e3bbddcee64b7f585b0711a7ca1df28bd651"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2022-10-27 13:45:36.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2022-10-27 13:50:37.000000000","tz":60},"subject":"proxy: reduce repeated logic in NodeIter","message":"proxy: reduce repeated logic in NodeIter\n\nConsolidate logic around yielding extra nodes in a single place.\n\nAdd a comment which is best guess as to the historic behavior of\nyielding an extra handoff.\n\nImprove test coverage of NodeIter.\n\nChange-Id: Ic378ea85fa9fe139af6c5a2d985c6e01699e43a8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2a5915fce1ff65365fe4b4280f9eb8274fecb0a6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2a5915fce1ff65365fe4b4280f9eb8274fecb0a6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}