)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"87caa5b42ca832916227e708add10b1205cc9ad1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e1c6c9f5_3fa16bd5","updated":"2022-11-11 01:22:00.000000000","message":"LGTM, thanks a lot!","commit_id":"d9cfd3847d8ba0a056d0e42bc035c99f8e9e3f0a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6256d0b7f6a09fd72ab9e3a97b6aa22940cb302f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fb44f3b3_e0493edc","updated":"2022-11-14 16:22:11.000000000","message":"this change raises some questions for me, maybe it would have looked better squashed into the parent?","commit_id":"d9cfd3847d8ba0a056d0e42bc035c99f8e9e3f0a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8019a5c0d9a53d5164cb79e5ec0eaad8d4ab64c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fe78b71e_1a24b99d","updated":"2022-11-18 16:49:32.000000000","message":"i think the wording is weird, but having the floats in the log lines (so we don\u0027t have to look at configs?) is probably fine.","commit_id":"10829bc9642048dd5a9e0ce0acecd3055c2edaf2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cc85f8d4043163539c341949a7f95f5624f7de84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"20661881_17fb6e62","in_reply_to":"fe78b71e_1a24b99d","updated":"2022-11-18 17:43:36.000000000","message":"reducing the places i have to go and look things up to build a picture of what is happening is precisely my motivation","commit_id":"10829bc9642048dd5a9e0ce0acecd3055c2edaf2"}],"swift/proxy/server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d4eef0165dc1056b296434e9193da5f0c070ceb1","unresolved":true,"context_lines":[{"line_number":675,"context_line":"        self.error_limiter.limit(node)"},{"line_number":676,"context_line":"        self.logger.increment(\u0027error_limiter.forced_limit\u0027)"},{"line_number":677,"context_line":"        self.logger.error("},{"line_number":678,"context_line":"            \u0027Node will be error limited from now: %s, error: %s\u0027,"},{"line_number":679,"context_line":"            node_to_string(node),"},{"line_number":680,"context_line":"            msg)"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"74434cd0_ab97d78e","line":678,"updated":"2022-11-14 17:35:10.000000000","message":"Should we add the suppression_interval here, too?","commit_id":"d9cfd3847d8ba0a056d0e42bc035c99f8e9e3f0a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"665ac3ce1ea23a3270db32233180d96dbc99e069","unresolved":false,"context_lines":[{"line_number":675,"context_line":"        self.error_limiter.limit(node)"},{"line_number":676,"context_line":"        self.logger.increment(\u0027error_limiter.forced_limit\u0027)"},{"line_number":677,"context_line":"        self.logger.error("},{"line_number":678,"context_line":"            \u0027Node will be error limited from now: %s, error: %s\u0027,"},{"line_number":679,"context_line":"            node_to_string(node),"},{"line_number":680,"context_line":"            msg)"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"568c4d06_3fca3583","line":678,"in_reply_to":"3e1969ac_029aad44","updated":"2022-11-16 15:02:43.000000000","message":"Done","commit_id":"d9cfd3847d8ba0a056d0e42bc035c99f8e9e3f0a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"1786c7499348c9293b16850cc5942df9db0e0496","unresolved":true,"context_lines":[{"line_number":675,"context_line":"        self.error_limiter.limit(node)"},{"line_number":676,"context_line":"        self.logger.increment(\u0027error_limiter.forced_limit\u0027)"},{"line_number":677,"context_line":"        self.logger.error("},{"line_number":678,"context_line":"            \u0027Node will be error limited from now: %s, error: %s\u0027,"},{"line_number":679,"context_line":"            node_to_string(node),"},{"line_number":680,"context_line":"            msg)"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3e1969ac_029aad44","line":678,"in_reply_to":"74434cd0_ab97d78e","updated":"2022-11-14 20:23:25.000000000","message":"will fix","commit_id":"d9cfd3847d8ba0a056d0e42bc035c99f8e9e3f0a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6256d0b7f6a09fd72ab9e3a97b6aa22940cb302f","unresolved":true,"context_lines":[{"line_number":689,"context_line":"        if self.error_limiter.increment(node):"},{"line_number":690,"context_line":"            self.logger.increment(\u0027error_limiter.incremented_limit\u0027)"},{"line_number":691,"context_line":"            self.logger.error("},{"line_number":692,"context_line":"                \u0027Node will be error limited from now for %.2fs: %s\u0027,"},{"line_number":693,"context_line":"                self.error_limiter.suppression_interval, node_to_string(node))"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    def error_occurred(self, node, msg):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb9412f_de01787c","line":692,"updated":"2022-11-14 16:22:11.000000000","message":"I would prefer:\n\n\"%(node_to_string)s will be error limited for %(suppression_interval)s\"","commit_id":"d9cfd3847d8ba0a056d0e42bc035c99f8e9e3f0a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8019a5c0d9a53d5164cb79e5ec0eaad8d4ab64c0","unresolved":true,"context_lines":[{"line_number":689,"context_line":"        if self.error_limiter.increment(node):"},{"line_number":690,"context_line":"            self.logger.increment(\u0027error_limiter.incremented_limit\u0027)"},{"line_number":691,"context_line":"            self.logger.error("},{"line_number":692,"context_line":"                \u0027Node will be error limited from now for %.2fs: %s\u0027,"},{"line_number":693,"context_line":"                self.error_limiter.suppression_interval, node_to_string(node))"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    def error_occurred(self, node, msg):"}],"source_content_type":"text/x-python","patch_set":3,"id":"722d4807_0d5630cb","line":692,"in_reply_to":"2c0eec65_89905b94","updated":"2022-11-18 16:49:32.000000000","message":"fine\n\nNode will be error limited for %(supression_internval)s: %(node_to_string)\n\ni thought the parent patch added \"limited from now\" and it doesn\u0027t read correctly to me.","commit_id":"d9cfd3847d8ba0a056d0e42bc035c99f8e9e3f0a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cc85f8d4043163539c341949a7f95f5624f7de84","unresolved":true,"context_lines":[{"line_number":689,"context_line":"        if self.error_limiter.increment(node):"},{"line_number":690,"context_line":"            self.logger.increment(\u0027error_limiter.incremented_limit\u0027)"},{"line_number":691,"context_line":"            self.logger.error("},{"line_number":692,"context_line":"                \u0027Node will be error limited from now for %.2fs: %s\u0027,"},{"line_number":693,"context_line":"                self.error_limiter.suppression_interval, node_to_string(node))"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    def error_occurred(self, node, msg):"}],"source_content_type":"text/x-python","patch_set":3,"id":"4071fc41_c5635252","line":692,"in_reply_to":"722d4807_0d5630cb","updated":"2022-11-18 17:43:36.000000000","message":"ok that\u0027s better, will fix","commit_id":"d9cfd3847d8ba0a056d0e42bc035c99f8e9e3f0a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"1786c7499348c9293b16850cc5942df9db0e0496","unresolved":true,"context_lines":[{"line_number":689,"context_line":"        if self.error_limiter.increment(node):"},{"line_number":690,"context_line":"            self.logger.increment(\u0027error_limiter.incremented_limit\u0027)"},{"line_number":691,"context_line":"            self.logger.error("},{"line_number":692,"context_line":"                \u0027Node will be error limited from now for %.2fs: %s\u0027,"},{"line_number":693,"context_line":"                self.error_limiter.suppression_interval, node_to_string(node))"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    def error_occurred(self, node, msg):"}],"source_content_type":"text/x-python","patch_set":3,"id":"2c0eec65_89905b94","line":692,"in_reply_to":"9fb9412f_de01787c","updated":"2022-11-14 20:23:25.000000000","message":"IIRC The existing error limiting logs have the node at the end, and did before the parent patch, so we\u0027re just sticking with existing pattern but adding an interval.","commit_id":"d9cfd3847d8ba0a056d0e42bc035c99f8e9e3f0a"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6256d0b7f6a09fd72ab9e3a97b6aa22940cb302f","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"                 node_to_string(node)),"},{"line_number":1226,"context_line":"                lines[-1])"},{"line_number":1227,"context_line":"            self.assertEqual(1, logger.get_increment_counts().get("},{"line_number":1228,"context_line":"                \u0027error_limiter.incremented_limit\u0027, 0))"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        do_test(\u0027success\u0027)"},{"line_number":1231,"context_line":"        do_test(\u0027succès\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"76a3a3e8_9936a721","side":"PARENT","line":1228,"updated":"2022-11-14 16:22:11.000000000","message":"i don\u0027t understand why this was still 0?","commit_id":"704c0254f594f42a474268b7a9b22efb2d43ad23"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cc85f8d4043163539c341949a7f95f5624f7de84","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"                 node_to_string(node)),"},{"line_number":1226,"context_line":"                lines[-1])"},{"line_number":1227,"context_line":"            self.assertEqual(1, logger.get_increment_counts().get("},{"line_number":1228,"context_line":"                \u0027error_limiter.incremented_limit\u0027, 0))"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        do_test(\u0027success\u0027)"},{"line_number":1231,"context_line":"        do_test(\u0027succès\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c02b0a8_316527a3","side":"PARENT","line":1228,"in_reply_to":"0dc14f22_8ae35c4b","updated":"2022-11-18 17:43:36.000000000","message":"oh yeah, I kept tripping up over that too!","commit_id":"704c0254f594f42a474268b7a9b22efb2d43ad23"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8019a5c0d9a53d5164cb79e5ec0eaad8d4ab64c0","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"                 node_to_string(node)),"},{"line_number":1226,"context_line":"                lines[-1])"},{"line_number":1227,"context_line":"            self.assertEqual(1, logger.get_increment_counts().get("},{"line_number":1228,"context_line":"                \u0027error_limiter.incremented_limit\u0027, 0))"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        do_test(\u0027success\u0027)"},{"line_number":1231,"context_line":"        do_test(\u0027succès\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0dc14f22_8ae35c4b","side":"PARENT","line":1228,"in_reply_to":"76a3a3e8_9936a721","updated":"2022-11-18 16:49:32.000000000","message":"oh, i read it wrong, the default get was 0 - the assert value was 1","commit_id":"704c0254f594f42a474268b7a9b22efb2d43ad23"}]}