)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ad3e284c736a9d7b40ff0fa9ff4a0f2a173babbd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Clay Gerrard \u003cclay.gerrard@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-02 18:34:35 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix backend policy leak"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I124afa825a3158eef7023abd5ec87fad54c0beab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9cb8f06f_aa322941","line":7,"updated":"2023-10-03 22:27:44.000000000","message":"worst commit message ever","commit_id":"8d8e8e2112eee528eb6ba1eaf3a2139b2f788c48"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4dc23bc4cb8dd35b27ed519ca661e3f3bcb84243","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d5ddbc9_1129fc56","updated":"2023-03-20 21:38:33.000000000","message":"i think i just added all these commits as I was working, it might make more sense to pull all the probetest refactoring into the first commit","commit_id":"8d8e8e2112eee528eb6ba1eaf3a2139b2f788c48"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ad3e284c736a9d7b40ff0fa9ff4a0f2a173babbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60dce845_0fa220a2","updated":"2023-10-03 22:27:44.000000000","message":"ok, i think the plan should be to dump the \"passing probe with bad behavior\" - that was just an informative place to document the current behavior (which has multiple issues)\n\nI think the fix is reasonable, but it needs some tests to validate the proxy-logging behavior is maintained and and a better commit message.","commit_id":"8d8e8e2112eee528eb6ba1eaf3a2139b2f788c48"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"eb56390f0e679be98c7ba88723821197643a3fc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37cbba2b_4d4e90cd","updated":"2023-03-31 18:34:51.000000000","message":"there needs to be some test to demonstrate proxy-logging will associate the correct storage-policy with the s3api logging from the x-backend resp header","commit_id":"8d8e8e2112eee528eb6ba1eaf3a2139b2f788c48"}],"swift/common/middleware/s3api/s3request.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ad3e284c736a9d7b40ff0fa9ff4a0f2a173babbd","unresolved":true,"context_lines":[{"line_number":1363,"context_line":"        # because it\u0027ll contaminate sub-requests"},{"line_number":1364,"context_line":"        spi_header \u003d \u0027X-Backend-Storage-Policy-Index\u0027"},{"line_number":1365,"context_line":"        if spi_header in sw_req.headers:"},{"line_number":1366,"context_line":"            resp.headers[spi_header] \u003d sw_req.headers[spi_header]"},{"line_number":1367,"context_line":"        status \u003d resp.status_int  # pylint: disable-msg\u003dE1101"},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"        if not self.user_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"01707ef9_ac7bf6cf","line":1366,"updated":"2023-10-03 22:27:44.000000000","message":"i think this is trying to say it\u0027s a better way to get the spi into proxy logging (using resp headers)","commit_id":"8d8e8e2112eee528eb6ba1eaf3a2139b2f788c48"}],"test/probe/test_mixed_policy_mpu.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ad3e284c736a9d7b40ff0fa9ff4a0f2a173babbd","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        _, listing \u003d swiftclient.get_container("},{"line_number":97,"context_line":"            self.url, self.token, self.bucket_name)"},{"line_number":98,"context_line":"        self.assertEqual(listing, [{"},{"line_number":99,"context_line":"            \u0027bytes\u0027: 624,"},{"line_number":100,"context_line":"            \u0027content_type\u0027: \u0027application/octet-stream\u0027,"},{"line_number":101,"context_line":"            \u0027hash\u0027: headers[\u0027x-manifest-etag\u0027],"},{"line_number":102,"context_line":"            \u0027last_modified\u0027: mock.ANY,"}],"source_content_type":"text/x-python","patch_set":1,"id":"422adbfa_05e796bc","side":"PARENT","line":99,"updated":"2023-10-03 22:27:44.000000000","message":"it doesn\u0027t seem like we\u0027re getting that much out of the the pre-req test since we change","commit_id":"9d370c9057961e44122ba0d45b06b77abc20bd4e"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4dc23bc4cb8dd35b27ed519ca661e3f3bcb84243","unresolved":true,"context_lines":[{"line_number":90,"context_line":"            \u0027s3_etag\u0027: \u0027\"b935cf6f134c4efd984a3c72ad23949d-2\"\u0027,"},{"line_number":91,"context_line":"            \u0027slo_etag\u0027: \u0027\"7ea6e9eaa029441578351a1771a2c519\"\u0027,"},{"line_number":92,"context_line":"        }])"},{"line_number":93,"context_line":"        self.assertEqual(stat[\u0027x-storage-policy\u0027], policy.name)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_mixed_policy_upload(self):"},{"line_number":96,"context_line":"        self.s3.create_bucket(Bucket\u003dself.bucket_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c31aaf2f_0f72946b","line":93,"updated":"2023-03-20 21:38:33.000000000","message":"this little method extraction refactor could probably be pulled into the first probetest change","commit_id":"8d8e8e2112eee528eb6ba1eaf3a2139b2f788c48"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ad3e284c736a9d7b40ff0fa9ff4a0f2a173babbd","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        # the SLO manifest with the wrong x-backned-storage-policy-index (it"},{"line_number":109,"context_line":"        # reads the upload-id-marker from +segments), so the manifest was"},{"line_number":110,"context_line":"        # stored in the wrong policy and swift would 404"},{"line_number":111,"context_line":"        self.check_head_and_listing_bytes()"},{"line_number":112,"context_line":"        # ... now the reconciler has nothing to move"},{"line_number":113,"context_line":"        self.get_to_final_state()"},{"line_number":114,"context_line":"        Manager([\u0027container-reconciler\u0027]).once()"}],"source_content_type":"text/x-python","patch_set":1,"id":"074d2d82_a542818e","line":111,"updated":"2023-10-03 22:27:44.000000000","message":"i\u0027m guessing this fails if you revert the spi leak fix?","commit_id":"8d8e8e2112eee528eb6ba1eaf3a2139b2f788c48"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4dc23bc4cb8dd35b27ed519ca661e3f3bcb84243","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        # ... so the container swift_bytes are intact"},{"line_number":116,"context_line":"        self.check_head_and_listing_bytes()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def change_storage_policy_index(self, container, policy_index):"},{"line_number":119,"context_line":"        broker \u003d self.get_broker(self.bucket_brain.nodes[0],"},{"line_number":120,"context_line":"                                 self.bucket_brain.part, self.account,"},{"line_number":121,"context_line":"                                 self.bucket_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"be3ed80a_b225271c","line":118,"updated":"2023-03-20 21:38:33.000000000","message":"hrm... so this method isn\u0027t used until the next patch in the chain we were force the reconciler to move swift-bytes","commit_id":"8d8e8e2112eee528eb6ba1eaf3a2139b2f788c48"}]}