)]}'
{"swift/common/internal_client.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ed1fb00abae8c214ace669df410926bb0066c857","unresolved":true,"context_lines":[{"line_number":201,"context_line":"                path, environ\u003d{\u0027REQUEST_METHOD\u0027: method}, headers\u003dheaders)"},{"line_number":202,"context_line":"            if \u0027swift_bytes\u0027 in headers.get(\u0027Content-Type\u0027, \u0027\u0027):"},{"line_number":203,"context_line":"                # XXX does this really need to be conditional for internal use?"},{"line_number":204,"context_line":"                req.environ[\u0027swift.content_type_overridden\u0027] \u003d True"},{"line_number":205,"context_line":"                pass"},{"line_number":206,"context_line":"            if body_file is not None:"},{"line_number":207,"context_line":"                if hasattr(body_file, \u0027seek\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4fe7ef65_4c3e98af","line":204,"updated":"2023-03-20 21:43:37.000000000","message":"i forget who looks at this or what the XXX is about","commit_id":"a903010edf80021acb35b508f6ce2c0c3d0ca952"}],"swift/proxy/controllers/obj.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ed1fb00abae8c214ace669df410926bb0066c857","unresolved":true,"context_lines":[{"line_number":256,"context_line":"        resp \u003d self._get_or_head_response(req, node_iter, partition, policy)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        is_internal_request \u003d req.headers.get("},{"line_number":259,"context_line":"            \u0027x-backend-allow-reserved-names\u0027, \u0027false\u0027) \u003d\u003d \u0027true\u0027"},{"line_number":260,"context_line":"        if \u0027;\u0027 in resp.headers.get(\u0027content-type\u0027, \u0027\u0027) and \\"},{"line_number":261,"context_line":"                not is_internal_request:"},{"line_number":262,"context_line":"            resp.content_type \u003d clean_content_type("}],"source_content_type":"text/x-python","patch_set":1,"id":"b63004f4_1377cff3","line":259,"updated":"2023-03-20 21:43:37.000000000","message":"this might look better wrapped in config_true_value","commit_id":"a903010edf80021acb35b508f6ce2c0c3d0ca952"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ed1fb00abae8c214ace669df410926bb0066c857","unresolved":true,"context_lines":[{"line_number":258,"context_line":"        is_internal_request \u003d req.headers.get("},{"line_number":259,"context_line":"            \u0027x-backend-allow-reserved-names\u0027, \u0027false\u0027) \u003d\u003d \u0027true\u0027"},{"line_number":260,"context_line":"        if \u0027;\u0027 in resp.headers.get(\u0027content-type\u0027, \u0027\u0027) and \\"},{"line_number":261,"context_line":"                not is_internal_request:"},{"line_number":262,"context_line":"            resp.content_type \u003d clean_content_type("},{"line_number":263,"context_line":"                resp.headers[\u0027content-type\u0027])"},{"line_number":264,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":1,"id":"e1839674_00a048f2","line":261,"updated":"2023-03-20 21:43:37.000000000","message":"right so we only clean external requests, there might be some better ways to phrase this wrt variable names and boolean logic (i.e. is_external vs not is_internal)","commit_id":"a903010edf80021acb35b508f6ce2c0c3d0ca952"}],"test/probe/common.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ed1fb00abae8c214ace669df410926bb0066c857","unresolved":true,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def get_broker(self, node, part, account, container):"},{"line_number":494,"context_line":"        db_file \u003d self.get_db_file(node, part, account, container)"},{"line_number":495,"context_line":"        return ContainerBroker(db_file)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def config_number(self, node):"},{"line_number":498,"context_line":"        _server_type, config_number \u003d get_server_number("}],"source_content_type":"text/x-python","patch_set":1,"id":"40c81822_4253707d","line":495,"updated":"2023-03-20 21:43:37.000000000","message":"maybe it\u0027d make sense to pull all of this into the first change","commit_id":"a903010edf80021acb35b508f6ce2c0c3d0ca952"}],"test/probe/test_mixed_policy_mpu.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ed1fb00abae8c214ace669df410926bb0066c857","unresolved":true,"context_lines":[{"line_number":118,"context_line":"    def change_storage_policy_index(self, container, policy_index):"},{"line_number":119,"context_line":"        broker \u003d self.get_broker(self.bucket_brain.nodes[0],"},{"line_number":120,"context_line":"                                 self.bucket_brain.part, self.account,"},{"line_number":121,"context_line":"                                 self.bucket_name)"},{"line_number":122,"context_line":"        now \u003d time.time()"},{"line_number":123,"context_line":"        put_ts \u003d Timestamp(now, offset\u003d2)"},{"line_number":124,"context_line":"        del_ts \u003d Timestamp(now, offset\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf25c83b_670668a1","line":121,"updated":"2023-03-20 21:43:37.000000000","message":"these don\u0027t get moved to common until this patch, so maybe the previous patch is broken?","commit_id":"a903010edf80021acb35b508f6ce2c0c3d0ca952"}],"test/probe/test_sharder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ed1fb00abae8c214ace669df410926bb0066c857","unresolved":true,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def get_broker(self, part, node, account\u003dNone, container\u003dNone):"},{"line_number":215,"context_line":"        return ContainerBroker("},{"line_number":216,"context_line":"            self.get_db_file(part, node, account, container))"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def get_shard_broker(self, shard_range, node_index\u003d0):"},{"line_number":219,"context_line":"        shard_part, shard_nodes \u003d self.brain.ring.get_nodes("}],"source_content_type":"text/x-python","patch_set":1,"id":"49ef0001_437d8e83","side":"PARENT","line":216,"updated":"2023-03-20 21:43:37.000000000","message":"this all just got moved into common","commit_id":"8d8e8e2112eee528eb6ba1eaf3a2139b2f788c48"}]}