)]}'
{"swift/common/storage_policy.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"fc1d28cafbd15f41c324cbcf6247d036e83fda69","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _validate_policies(self, policies):"},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        Validates semantics of policies read in from conf file."},{"line_number":129,"context_line":"        - if no pol 0 or no policies defined, pol 0 is declared"},{"line_number":130,"context_line":"        - policy index must be integer"},{"line_number":131,"context_line":"        - if no policy is decalred default, pol 0 is the default"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2Fc7Y%3D","line":128,"updated":"2014-04-21 17:02:56.000000000","message":"some of these rules are now enforced elsewhere, not sure how important it is to specify what\u0027s done in this function versus the StoragePolicy constructor","commit_id":"a79a21e6cc111e9d8ffff1dda24618672c0968d8"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dc9092b225c38f1b524e033f63f0fbc53c0b61b9","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _validate_policies(self, policies):"},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        Validates semantics of policies read in from conf file."},{"line_number":129,"context_line":"        - if no pol 0 or no policies defined, pol 0 is declared"},{"line_number":130,"context_line":"        - policy index must be integer"},{"line_number":131,"context_line":"        - if no policy is decalred default, pol 0 is the default"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FRpE%3D","line":128,"in_reply_to":"AAAAXH%2F%2Fc7Y%3D","updated":"2014-04-22 20:02:45.000000000","message":"probably good to have the rules documented in a single spot.  I should probably move it to the Collection class doc string tho...","commit_id":"a79a21e6cc111e9d8ffff1dda24618672c0968d8"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"fc1d28cafbd15f41c324cbcf6247d036e83fda69","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            raise PolicyError(\u0027Invalid storage-policy section %r\u0027 % section)"},{"line_number":242,"context_line":"        if policy_prefix !\u003d \u0027storage-policy\u0027:"},{"line_number":243,"context_line":"            raise PolicyError(\u0027Invalid storage-policy section %r\u0027 % section)"},{"line_number":244,"context_line":"        options \u003d dict((\u0027policy_%s\u0027 % k, v) for k, v in conf.items(section))"},{"line_number":245,"context_line":"        policy \u003d StoragePolicy(policy_index, **options)"},{"line_number":246,"context_line":"        policies.append(policy)"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2Fc7Q%3D","line":244,"updated":"2014-04-21 17:02:56.000000000","message":"so that\u0027s cool...","commit_id":"a79a21e6cc111e9d8ffff1dda24618672c0968d8"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dc9092b225c38f1b524e033f63f0fbc53c0b61b9","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            raise PolicyError(\u0027Invalid storage-policy section %r\u0027 % section)"},{"line_number":242,"context_line":"        if policy_prefix !\u003d \u0027storage-policy\u0027:"},{"line_number":243,"context_line":"            raise PolicyError(\u0027Invalid storage-policy section %r\u0027 % section)"},{"line_number":244,"context_line":"        options \u003d dict((\u0027policy_%s\u0027 % k, v) for k, v in conf.items(section))"},{"line_number":245,"context_line":"        policy \u003d StoragePolicy(policy_index, **options)"},{"line_number":246,"context_line":"        policies.append(policy)"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FRpw%3D","line":244,"in_reply_to":"AAAAXH%2F%2Fc7Q%3D","updated":"2014-04-22 20:02:45.000000000","message":"I actually thought it was kinda janky - not sure why I went with it.  I probably should have just built up an explicit map.","commit_id":"a79a21e6cc111e9d8ffff1dda24618672c0968d8"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"fc1d28cafbd15f41c324cbcf6247d036e83fda69","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        return repr(_POLICIES)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"def reload_storage_policies():"},{"line_number":279,"context_line":"    global _POLICIES"},{"line_number":280,"context_line":"    policy_conf \u003d ConfigParser()"},{"line_number":281,"context_line":"    policy_conf.read(SWIFT_CONF_FILE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2Fc68%3D","line":278,"updated":"2014-04-21 17:02:56.000000000","message":"for my own education, is there a functional difference between this and previous (other than the exception which could have been done at the module level right?)","commit_id":"a79a21e6cc111e9d8ffff1dda24618672c0968d8"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dc9092b225c38f1b524e033f63f0fbc53c0b61b9","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        return repr(_POLICIES)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"def reload_storage_policies():"},{"line_number":279,"context_line":"    global _POLICIES"},{"line_number":280,"context_line":"    policy_conf \u003d ConfigParser()"},{"line_number":281,"context_line":"    policy_conf.read(SWIFT_CONF_FILE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FRqY%3D","line":278,"in_reply_to":"AAAAXH%2F%2Fc68%3D","updated":"2014-04-22 20:02:45.000000000","message":"i just wanted a hook that I could call to reparse swift.conf after import time.  Since it\u0027s called on the initial load it should be functionally equivalent - at least that was the intent.","commit_id":"a79a21e6cc111e9d8ffff1dda24618672c0968d8"}]}
